emacs-elpa-diffs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[elpa] externals/org 1f48d2d751: org-element-cache-map: Do not byte-comp


From: ELPA Syncer
Subject: [elpa] externals/org 1f48d2d751: org-element-cache-map: Do not byte-compile FUNC
Date: Mon, 10 Jan 2022 09:57:45 -0500 (EST)

branch: externals/org
commit 1f48d2d75165d552adea213882e378253ed2c886
Author: Ihor Radchenko <yantar92@gmail.com>
Commit: Ihor Radchenko <yantar92@gmail.com>

    org-element-cache-map: Do not byte-compile FUNC
    
    Byte compilation can unpredictably break agenda searches in some Emacs
    builds.
    
    See 
https://list.orgmode.org/PAXPR08MB6640260AFA03FCDFABE245A3A34F9@PAXPR08MB6640.eurprd08.prod.outlook.com/T/#t
---
 lisp/org-element.el | 30 ------------------------------
 1 file changed, 30 deletions(-)

diff --git a/lisp/org-element.el b/lisp/org-element.el
index 33f7f27671..e7ccd3ba80 100644
--- a/lisp/org-element.el
+++ b/lisp/org-element.el
@@ -7362,36 +7362,6 @@ the cache."
                  ;; returned non-nil).
                  (last-match t)
                  continue-flag
-                 ;; Byte-compile FUNC making sure that it is as performant
-                 ;; as it could be.
-                 (func (if (or (byte-code-function-p func)
-                               (and (symbolp func)
-                                    (subrp (symbol-function func)))
-                               (and (symbolp func)
-                                    (fboundp 'native-comp-available-p)
-                                    (native-comp-available-p)
-                                    (fboundp 'subr-native-elisp-p)
-                                    (subr-native-elisp-p (symbol-function 
func)))
-                               ;; FIXME: Working around bug
-                               ;; 
https://list.orgmode.org/87tuha62rq.fsf@localhost/T/#t
-                               ;; Byte-compilation in
-                               ;; `org-agenda-get-scheduled' call
-                               ;; somehow alters the FUNC result in
-                               ;; Emacs 26 and 27, but not in Emacs
-                               ;; >=28.
-                               (version< emacs-version "29"))
-                           func
-                         (let ((warning-minimum-log-level :error)
-                               (inhibit-message t))
-                           (condition-case nil
-                               (if (and (fboundp 'native-comp-available-p)
-                                        (fboundp 'native-compile)
-                                        (native-comp-available-p))
-                                   ;; Use native compilation to even better
-                                   ;; performance.
-                                   (native-compile func)
-                                 (byte-compile func))
-                             (error func)))))
                  ;; Generic regexp to search next potential match.  If it
                  ;; is a cons of (regexp . 'match-beg), we are 100% sure
                  ;; that the match beginning is the existing element



reply via email to

[Prev in Thread] Current Thread [Next in Thread]