[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[nongnu] elpa/keycast 2c94648442 30/31: Fix keycast-log-mode breakage wh
From: |
ELPA Syncer |
Subject: |
[nongnu] elpa/keycast 2c94648442 30/31: Fix keycast-log-mode breakage when reading a password |
Date: |
Sun, 9 Jan 2022 05:58:53 -0500 (EST) |
branch: elpa/keycast
commit 2c9464844292edb5bf2b1779ea6ad1f908c176a2
Author: Jonas Bernoulli <jonas@bernoul.li>
Commit: Jonas Bernoulli <jonas@bernoul.li>
Fix keycast-log-mode breakage when reading a password
When a password is being read then `keycast--format' returns nil,
which is the right thing to do for `keycast-mode'. The returned value
is used in the mode-line and if it is nil, that causes nothing to
appear in the mode-line, as opposed to the last binding from before
the password reading started to stick around.
However in the case of `keycast-log-mode' the value is being inserted
next to the previously inserted values using `insert' and that errors
on nil. So for that mode `keycast--reading-password' has to be taken
into account elsewhere.
Fixes #20.
---
keycast.el | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/keycast.el b/keycast.el
index 0cdb3a59e7..3f16a52904 100644
--- a/keycast.el
+++ b/keycast.el
@@ -1,6 +1,6 @@
;;; keycast.el --- Show current command and its key in the mode line -*-
lexical-binding: t -*-
-;; Copyright (C) 2018-2021 Jonas Bernoulli
+;; Copyright (C) 2018-2022 Jonas Bernoulli
;; Author: Jonas Bernoulli <jonas@bernoul.li>
;; Homepage: https://github.com/tarsius/keycast
@@ -219,7 +219,8 @@ instead."
(cond ((symbolp this-command) this-command)
((eq (car-safe this-command) 'lambda) "<lambda>")
(t (format "<%s>" (type-of this-command)))))
- (when keycast-log-mode
+ (when (and keycast-log-mode
+ (not keycast--reading-passwd))
(keycast-log-update-buffer))
(when keycast-mode
(force-mode-line-update (minibufferp))))
- [nongnu] elpa/keycast a3a0798349 25/31: Explicitly support compact mode line, (continued)
- [nongnu] elpa/keycast a3a0798349 25/31: Explicitly support compact mode line, ELPA Syncer, 2022/01/09
- [nongnu] elpa/keycast 038475c178 15/31: mode-line-keycast-format: New variable, ELPA Syncer, 2022/01/09
- [nongnu] elpa/keycast eecef23534 23/31: Use this-single-command-keys, ELPA Syncer, 2022/01/09
- [nongnu] elpa/keycast a12ef1fb48 28/31: Add SPDX-License-Identifier library header, ELPA Syncer, 2022/01/09
- [nongnu] elpa/keycast c855511785 04/31: Insert `mode-line-keycast` into `mode-line-format` before `(cdr cons)`, ELPA Syncer, 2022/01/09
- [nongnu] elpa/keycast fe416461b1 07/31: keycast-mode: Add usage hint to error message, ELPA Syncer, 2022/01/09
- [nongnu] elpa/keycast e635c7fbe4 19/31: keycast--format: Don't pad %K, ELPA Syncer, 2022/01/09
- [nongnu] elpa/keycast 6d75f149a7 20/31: keycast--update: New name for keycast-mode-line-update, ELPA Syncer, 2022/01/09
- [nongnu] elpa/keycast 3a8c4db51a 21/31: keycast-log-mode: New mode, ELPA Syncer, 2022/01/09
- [nongnu] elpa/keycast 04ba7519f3 29/31: Use keycast--tree-member when disabling keycast-mode as well, ELPA Syncer, 2022/01/09
- [nongnu] elpa/keycast 2c94648442 30/31: Fix keycast-log-mode breakage when reading a password,
ELPA Syncer <=