[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[nongnu] elpa/pacmacs ca32745bcb 224/472: Refactor char making duplicate
From: |
ELPA Syncer |
Subject: |
[nongnu] elpa/pacmacs ca32745bcb 224/472: Refactor char making duplicate code (#81) |
Date: |
Thu, 6 Jan 2022 21:59:26 -0500 (EST) |
branch: elpa/pacmacs
commit ca32745bcb37af5c91ac76cf9707e8fee7523cc3
Author: rexim <reximkut@gmail.com>
Commit: rexim <reximkut@gmail.com>
Refactor char making duplicate code (#81)
---
pacmacs.el | 38 ++++++++++++++------------------------
1 file changed, 14 insertions(+), 24 deletions(-)
diff --git a/pacmacs.el b/pacmacs.el
index 86028da966..d6e85227c4 100644
--- a/pacmacs.el
+++ b/pacmacs.el
@@ -143,39 +143,29 @@
(defun pacmacs--make-big-pill (row column)
(pacmacs--make-pill row column "Big-Pill" 'big-pill))
-(defun pacmacs--make-ghost (row column)
+
+(defun pacmacs--make-character (row column anim-prefix speed type)
(list :row row
:column column
:init-row row
:init-column column
:prev-row row
:prev-column column
- :direction 'right
- :current-animation (pacmacs-load-anim "Red-Ghost-Right")
- :direction-animations (list 'left (pacmacs-load-anim "Red-Ghost-Left")
- 'right (pacmacs-load-anim
"Red-Ghost-Right")
- 'up (pacmacs-load-anim "Red-Ghost-Up")
- 'down (pacmacs-load-anim
"Red-Ghost-Down"))
- :speed 1
+ :directory 'right
+ :current-animation (pacmacs-load-anim (concat anim-prefix "-Right"))
+ :direction-animations (-interleave '(left right up down)
+ (-map (-compose #'pacmacs-load-anim
+ (-partial #'concat
anim-prefix "-"))
+ (list "Left" "Right" "Up"
"Down")))
+ :speed speed
:speed-counter 0
- :type 'ghost))
+ :type type))
+
+(defun pacmacs--make-ghost (row column)
+ (pacmacs--make-character row column "Red-Ghost" 1 'ghost))
(defun pacmacs--make-player (row column)
- (list :row row
- :column column
- :init-row row
- :init-column column
- :prev-row row
- :prev-column column
- :direction 'right
- :current-animation (pacmacs-load-anim "Pacman-Chomping-Right")
- :direction-animations (list 'left (pacmacs-load-anim
"Pacman-Chomping-Left")
- 'right (pacmacs-load-anim
"Pacman-Chomping-Right")
- 'up (pacmacs-load-anim
"Pacman-Chomping-Up")
- 'down (pacmacs-load-anim
"Pacman-Chomping-Down"))
- :speed 0
- :speed-counter 0
- :type 'player))
+ (pacmacs--make-character row column "Pacman-Chomping" 0 'player))
(defun pacmacs--reset-object-position (game-object)
(plist-bind ((init-row :init-row)
- [nongnu] elpa/pacmacs 94c3a3cc1e 191/472: Merge branch 'master' into board-refactoring-105, (continued)
- [nongnu] elpa/pacmacs 94c3a3cc1e 191/472: Merge branch 'master' into board-refactoring-105, ELPA Syncer, 2022/01/06
- [nongnu] elpa/pacmacs b03ee65528 195/472: Merge branch 'board-refactoring-105'. Close #105, ELPA Syncer, 2022/01/06
- [nongnu] elpa/pacmacs f84acb56ad 201/472: Double dash load-map function (#126), ELPA Syncer, 2022/01/06
- [nongnu] elpa/pacmacs e13b23bc34 206/472: Remove object-at-p predicate, ELPA Syncer, 2022/01/06
- [nongnu] elpa/pacmacs 0c0f6c141c 210/472: Merge branch 'master' into integration-test-recorder-115, ELPA Syncer, 2022/01/06
- [nongnu] elpa/pacmacs e64420ace4 209/472: Fix meta for Red-Ghost-Win animation, ELPA Syncer, 2022/01/06
- [nongnu] elpa/pacmacs bfb089d1de 213/472: Exctract init code to a function (#115), ELPA Syncer, 2022/01/06
- [nongnu] elpa/pacmacs 09c0a15f40 217/472: Get pacmacs--object-at-p back (#122), ELPA Syncer, 2022/01/06
- [nongnu] elpa/pacmacs daca08b8b1 219/472: Add another it case (#122), ELPA Syncer, 2022/01/06
- [nongnu] elpa/pacmacs ed46a4b500 221/472: Add big pills sprites. Close #82, ELPA Syncer, 2022/01/06
- [nongnu] elpa/pacmacs ca32745bcb 224/472: Refactor char making duplicate code (#81),
ELPA Syncer <=
- [nongnu] elpa/pacmacs 5f7b4fcb12 235/472: Rename pacmacs--put-dot function (#131), ELPA Syncer, 2022/01/06
- [nongnu] elpa/pacmacs ba28d344be 068/472: Remove copypaste (#54), ELPA Syncer, 2022/01/06
- [nongnu] elpa/pacmacs 49e0ff0fe8 020/472: Cask: take package info from pacman.el file, ELPA Syncer, 2022/01/06
- [nongnu] elpa/pacmacs 7a8db8e06c 228/472: Merge branch 'xbm-flip-bit-hack-133'. Close #133, ELPA Syncer, 2022/01/06
- [nongnu] elpa/pacmacs f65f288b18 239/472: Cache wall tiles (#131), ELPA Syncer, 2022/01/06
- [nongnu] elpa/pacmacs edf7600fca 237/472: Add functions for drawing bars (#131), ELPA Syncer, 2022/01/06
- [nongnu] elpa/pacmacs 2a9ec76c28 263/472: Automate Big Pills sprites generating (#26), ELPA Syncer, 2022/01/06
- [nongnu] elpa/pacmacs a1bf99c5f7 176/472: Add an animation, close #118., ELPA Syncer, 2022/01/06
- [nongnu] elpa/pacmacs 29b87c4538 181/472: Refactor out unpaused play state predicate, ELPA Syncer, 2022/01/06
- [nongnu] elpa/pacmacs 93f964e11e 186/472: Merge branch 'compile-on-ci-123'. Close #123, ELPA Syncer, 2022/01/06