[nongnu] elpa/pacmacs 7e04991d4e 030/472: Add UT for pacman-compare-aseprite-frames function (#22)

[ELPA Syncer]

branch: elpa/pacmacs
commit 7e04991d4eca37193482dbecc5c1b6483f4b2bcc
Author: rexim <reximkut@gmail.com>
Commit: rexim <reximkut@gmail.com>

    Add UT for pacman-compare-aseprite-frames function (#22)
---
 pacman-anim.el           | 13 ++++++-------
 test/pacman-anim-test.el | 21 +++++++++++++++++++++
 2 files changed, 27 insertions(+), 7 deletions(-)

diff --git a/pacman-anim.el b/pacman-anim.el
index c3574c0639..cee67bf889 100644
--- a/pacman-anim.el
+++ b/pacman-anim.el
@@ -9,19 +9,18 @@
          (aseprite-frames (cdr (assoc 'frames aseprite-json))))
     (pacman-make-anim
      (mapcar 'pacman-convert-aseprite-frame
-             (pacman-aseprite-sort-frame-hack aseprite-frames)))))
+             (sort aseprite-frames
+                   'pacman-compare-aseprite-frames)))))
 
 (defun pacman-aseprite-frame-get-order (aseprite-frame)
   (let ((frame-name (symbol-name (car aseprite-frame))))
     (string-match "\\([0-9]+\\)\\.ase$" frame-name)
     (string-to-number (match-string 1 frame-name))))
 
-(defun pacman-aseprite-sort-frame-hack (aseprite-frames)
-  (sort aseprite-frames
-        #'(lambda (f1 f2)
-            (let ((o1 (pacman-aseprite-frame-get-order f1))
-                  (o2 (pacman-aseprite-frame-get-order f2)))
-              (< o1 o2)))))
+(defun pacman-compare-aseprite-frames (aseprite-frame1 aseprite-frame2)
+  (let ((order1 (pacman-aseprite-frame-get-order aseprite-frame1))
+        (order2 (pacman-aseprite-frame-get-order aseprite-frame2)))
+    (< order1 order2)))
 
 (defun pacman-convert-aseprite-frame (aseprite-frame)
   (let* ((frame (cdr (assoc 'frame (cdr aseprite-frame))))
diff --git a/test/pacman-anim-test.el b/test/pacman-anim-test.el
index d51fb58490..74e32eade1 100644
--- a/test/pacman-anim-test.el
+++ b/test/pacman-anim-test.el
@@ -1,3 +1,6 @@
+(require 'cl)                           ;el-mock doesn't work without
+                                        ;this
+
 (ert-deftest pacman-anim-get-frame-test ()
   (let ((anim (list :frames (number-sequence 1 5)
                     :current-frame 2)))
@@ -41,3 +44,21 @@
                            (h . 3)
                            (w . 4)))))
     (should (equal 42 (pacman-aseprite-frame-get-order aseprite-frame)))))
+
+(ert-deftest pacman-compare-aseprite-frames-test ()
+  (let ((aseprite-frame1 '(khooy42.ase
+                           (foo . bar)
+                           (frame
+                            (x . 1)
+                            (y . 2)
+                            (h . 3)
+                            (w . 4))))
+        (aseprite-frame2 '(khooy43.ase
+                           (foo . bar)
+                           (frame
+                            (x . 1)
+                            (y . 2)
+                            (h . 3)
+                            (w . 4)))))
+    (should (pacman-compare-aseprite-frames aseprite-frame1 aseprite-frame2))
+    (should (not (pacman-compare-aseprite-frames aseprite-frame2 
aseprite-frame1)))))