[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[elpa] scratch/org-contacts-rebased 7f9ad6a 059/118: contrib/lisp/org-co
From: |
Stefan Monnier |
Subject: |
[elpa] scratch/org-contacts-rebased 7f9ad6a 059/118: contrib/lisp/org-contacts.el: Permit to unload properly `org-contacts' |
Date: |
Fri, 12 Nov 2021 15:37:04 -0500 (EST) |
branch: scratch/org-contacts-rebased
commit 7f9ad6af769fbac92dfc347f7addeacb4e8c29ce
Author: Grégoire Jadi <gregoire.jadi@gmail.com>
Commit: Grégoire Jadi <gregoire.jadi@gmail.com>
contrib/lisp/org-contacts.el: Permit to unload properly `org-contacts'
* contrib/lisp/org-contacts.el (org-contacts-setup-completion-at-point):
Setup `completion-at-point-functions' in a dedicated function so it's
easier to add and to remove it from `message-mode-hook'.
(org-contacts-unload-hook): This function removes all hooks added while
loading `org-contacts' in order to respect Emacs coding conventions.
---
org-contacts.el | 14 ++++++++++----
1 file changed, 10 insertions(+), 4 deletions(-)
diff --git a/org-contacts.el b/org-contacts.el
index c84f1f2..d81d43b 100644
--- a/org-contacts.el
+++ b/org-contacts.el
@@ -702,12 +702,18 @@ This adds `org-contacts-gnus-check-mail-address' and
(add-hook 'gnus-article-prepare-hook 'org-contacts-gnus-check-mail-address)
(add-hook 'gnus-article-prepare-hook 'org-contacts-gnus-store-last-mail))
+(defun org-contacts-setup-completion-at-point ()
+ "Add `org-contacts-message-complete-function' as a new function
+to complete the thing at point."
+ (add-to-list 'completion-at-point-functions
+ 'org-contacts-message-complete-function))
+
+(defun org-contacts-unload-hook ()
+ (remove-hook 'message-mode-hook 'org-contacts-setup-completion-at-point))
+
(when (and org-contacts-enable-completion
(boundp 'completion-at-point-functions))
- (add-hook 'message-mode-hook
- (lambda ()
- (add-to-list 'completion-at-point-functions
- 'org-contacts-message-complete-function))))
+ (add-hook 'message-mode-hook 'org-contacts-setup-completion-at-point))
(defun org-contacts-wl-get-from-header-content ()
"Retrieve the content of the `From' header of an email.
- [elpa] scratch/org-contacts-rebased d7412d5 054/118: contrib/lisp/org-contacts: Fix two typos in comments, (continued)
- [elpa] scratch/org-contacts-rebased d7412d5 054/118: contrib/lisp/org-contacts: Fix two typos in comments, Stefan Monnier, 2021/11/12
- [elpa] scratch/org-contacts-rebased 2f0d7e9 002/118: org-contacts: make Gnus usage optional, Stefan Monnier, 2021/11/12
- [elpa] scratch/org-contacts-rebased ad7f57a 023/118: Fix error messages: don't use a dot at the end, Stefan Monnier, 2021/11/12
- [elpa] scratch/org-contacts-rebased 5526110 018/118: Merge branch 'origin-maint', Stefan Monnier, 2021/11/12
- [elpa] scratch/org-contacts-rebased 68918fc 034/118: org-contacts: Fix Agenda format., Stefan Monnier, 2021/11/12
- [elpa] scratch/org-contacts-rebased 85b506b 031/118: contrib/lisp/org-contacts.el: Delete trailing whitespaces, Stefan Monnier, 2021/11/12
- [elpa] scratch/org-contacts-rebased 30a76d5 038/118: org-contacts.el: Rename a function to follow emacs-lisp coding conventions, Stefan Monnier, 2021/11/12
- [elpa] scratch/org-contacts-rebased 57a9545 041/118: contrib/lisp/org-contacts.el: Fix compiler warnings., Stefan Monnier, 2021/11/12
- [elpa] scratch/org-contacts-rebased f4f5ff3 050/118: org-contacts.el (org-contacts-export-as-vcard): Don't use non-existent function `org-install-letbind', Stefan Monnier, 2021/11/12
- [elpa] scratch/org-contacts-rebased f07f259 049/118: org-contacts.el, add tel property, Stefan Monnier, 2021/11/12
- [elpa] scratch/org-contacts-rebased 7f9ad6a 059/118: contrib/lisp/org-contacts.el: Permit to unload properly `org-contacts',
Stefan Monnier <=
- [elpa] scratch/org-contacts-rebased c71bbd2 060/118: contrib/lisp/org-contacts.el (org-contacts-vcard-format): Silence byte-compiler, Stefan Monnier, 2021/11/12
- [elpa] scratch/org-contacts-rebased f259246 063/118: contrib/lisp/org-contacts.el: Add a complex org-contacts template to the file header, Stefan Monnier, 2021/11/12
- [elpa] scratch/org-contacts-rebased dbe6325 065/118: org-contacts: Ensure contacts cache is updated if it contains markers with no buffer, Stefan Monnier, 2021/11/12
- [elpa] scratch/org-contacts-rebased f62bfeb 066/118: org-contacts: use `org-' prefixed variants of cl functions, Stefan Monnier, 2021/11/12
- [elpa] scratch/org-contacts-rebased 13d35c9 072/118: Update copyright years again., Stefan Monnier, 2021/11/12
- [elpa] scratch/org-contacts-rebased b970428 091/118: Rationalize `org-link-(un)escape', Stefan Monnier, 2021/11/12
- [elpa] scratch/org-contacts-rebased 5a2519c 048/118: org-contacts.el, add note property, Stefan Monnier, 2021/11/12
- [elpa] scratch/org-contacts-rebased 9dec69a 056/118: contrib/lisp/org-contacts: Introduce the constant `org-contacts-property-values-separators', Stefan Monnier, 2021/11/12
- [elpa] scratch/org-contacts-rebased 5e67fd8 068/118: Update copyright years., Stefan Monnier, 2021/11/12
- [elpa] scratch/org-contacts-rebased 666da7a 061/118: contrib/lisp/org-contacts.el: Add a feature, which can ignore emails or phones with property, Stefan Monnier, 2021/11/12