emacs-elpa-diffs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[elpa] externals/marginalia 0c2735e 214/241: Selectrum advice is unneces


From: Stefan Monnier
Subject: [elpa] externals/marginalia 0c2735e 214/241: Selectrum advice is unnecessary - post-command-hook performs the update
Date: Fri, 28 May 2021 20:49:29 -0400 (EDT)

branch: externals/marginalia
commit 0c2735eea5e0803921903dc5f7294dcdeece47d2
Author: Daniel Mendler <mail@daniel-mendler.de>
Commit: Daniel Mendler <mail@daniel-mendler.de>

    Selectrum advice is unnecessary - post-command-hook performs the update
    
    `marginalia-cycle` works out of the box with Vertico and Selectrum.
    I don't know why I believed that the explicit update is required.
---
 README.org      | 4 ----
 marginalia.texi | 4 ----
 2 files changed, 8 deletions(-)

diff --git a/README.org b/README.org
index 07d100d..03f521b 100644
--- a/README.org
+++ b/README.org
@@ -63,10 +63,6 @@ commands.
   ;; enabled right away. Note that this forces loading the package.
   (marginalia-mode)
 
-  ;; When using Selectrum, ensure that Selectrum is refreshed when cycling 
annotations.
-  (advice-add #'marginalia-cycle :after
-              (lambda () (when (bound-and-true-p selectrum-mode) 
(selectrum-exhibit 'keep-selected))))
-
   ;; Prefer richer, more heavy, annotations over the lighter default variant.
   ;; E.g. M-x will show the documentation string additional to the keybinding.
   ;; By default only the keybinding is shown as annotation.
diff --git a/marginalia.texi b/marginalia.texi
index e6f9360..f445c81 100644
--- a/marginalia.texi
+++ b/marginalia.texi
@@ -81,10 +81,6 @@ commands.
   ;; enabled right away. Note that this forces loading the package.
   (marginalia-mode)
 
-  ;; When using Selectrum, ensure that Selectrum is refreshed when cycling 
annotations.
-  (advice-add #'marginalia-cycle :after
-              (lambda () (when (bound-and-true-p selectrum-mode) 
(selectrum-exhibit 'keep-selected))))
-
   ;; Prefer richer, more heavy, annotations over the lighter default variant.
   ;; E.g. M-x will show the documentation string additional to the keybinding.
   ;; By default only the keybinding is shown as annotation.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]