emacs-elpa-diffs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[elpa] externals/vdiff c2de043 1/2: Avoid deprecated use of positional a


From: Stefan Monnier
Subject: [elpa] externals/vdiff c2de043 1/2: Avoid deprecated use of positional arguments for define-minor-mode
Date: Wed, 12 May 2021 18:47:54 -0400 (EDT)

branch: externals/vdiff
commit c2de0438de18c6c3eb4389fa0e983ee065ca55f3
Author: Brian Leung <leungbk@mailfence.com>
Commit: Brian Leung <leungbk@mailfence.com>

    Avoid deprecated use of positional arguments for define-minor-mode
    
    The latest Emacs 28 warns against this when byte-compiling.
---
 vdiff.el | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/vdiff.el b/vdiff.el
index c90c1eb..98f9320 100644
--- a/vdiff.el
+++ b/vdiff.el
@@ -2320,7 +2320,7 @@ buffers. This sets up key bindings in `vdiff-mode-map' 
and adds
 hooks to refresh diff on changes. This will be enabled
 automatically after calling commands like `vdiff-files' or
 `vdiff-buffers'."
-  nil " vdiff" 'vdiff-mode-map
+  :lighter " vdiff"
   (if vdiff-mode
       (vdiff--buffer-init)
     (vdiff--buffer-cleanup)))
@@ -2331,7 +2331,7 @@ buffers. This sets up key bindings in 
`vdiff-3way-mode-map' and
 adds hooks to refresh diff on changes. This will be enabled
 automatically after calling commands like `vdiff-files3' or
 `vdiff-buffers3'."
-  nil " vdiff3" 'vdiff-3way-mode-map
+  :lighter " vdiff3"
   (if vdiff-3way-mode
       (vdiff--buffer-init)
     (vdiff--buffer-cleanup)))
@@ -2339,7 +2339,8 @@ automatically after calling commands like `vdiff-files3' 
or
 (define-minor-mode vdiff-scroll-lock-mode
   "Lock scrolling between vdiff buffers. This minor mode will be
 enabled automatically if `vdiff-lock-scrolling' is non-nil."
-  nil nil nil
+  :lighter nil
+  :keymap nil
   (cond (vdiff-scroll-lock-mode
          (unless (or vdiff-mode vdiff-3way-mode)
            (user-error "Must enable vdiff-mode first"))



reply via email to

[Prev in Thread] Current Thread [Next in Thread]