[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[elpa] externals/emms ba16ff6 13/80: * emms-tag-editor.el: lexical compa
From: |
Stefan Monnier |
Subject: |
[elpa] externals/emms ba16ff6 13/80: * emms-tag-editor.el: lexical compatibility work |
Date: |
Wed, 17 Mar 2021 18:42:21 -0400 (EDT) |
branch: externals/emms
commit ba16ff6dedf2de5dda219cf38b1d6d092b542de6
Author: Yoni Rabkin <yoni@rabkins.net>
Commit: Yoni Rabkin <yoni@rabkins.net>
* emms-tag-editor.el: lexical compatibility work
Remove free lexical variables and the add-to-list, which really should
only be used for user configuration work.
---
emms-tag-editor.el | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/emms-tag-editor.el b/emms-tag-editor.el
index 0098024..52a8046 100644
--- a/emms-tag-editor.el
+++ b/emms-tag-editor.el
@@ -154,7 +154,7 @@ See also `emms-tag-editor-tag-file' and
`emms-tag-editor-tag-ogg'.")
(require 'emms-info-metaflac)
(with-temp-buffer
(let ((tags '("artist" "composer" "performer" "title" "album"
"tracknumber" "discnumber" "date" "genre" "note"))
- need val)
+ val)
(mapc (lambda (tag)
(let ((info-tag (intern (concat "info-" tag))))
(when (> (length (setq val (emms-track-get track info-tag))) 0)
@@ -544,7 +544,7 @@ Available tags are:
match "[^-]+"))
(setq compiled (concat compiled "\\(" match "\\)")
index (1+ index))
- (add-to-list 'registers (cons register index)))
+ (push (cons register index) registers))
(t (setq compiled (concat compiled (char-to-string c))))))
(if (/= paren 0) (error "Paren not match!"))
(cons compiled registers)))
@@ -830,7 +830,6 @@ A pipe is defined like below:
"Run command of pipe nameed PIPE-NAME to TRACK."
(if (eq (emms-track-get track 'type) 'file)
(let* ((coding-system-for-read 'utf-8)
- (track-name (emms-track-name track))
(command (emms-tag-editor-pipe-get pipe-name :command))
(arguments (emms-tag-editor-pipe-get pipe-name :arguments)))
(when (functionp arguments)
- [elpa] externals/emms 4a4a358 23/80: Remove emms-info-native return value, (continued)
- [elpa] externals/emms 4a4a358 23/80: Remove emms-info-native return value, Stefan Monnier, 2021/03/17
- [elpa] externals/emms 0fe6100 28/80: Improve id3v2 error handling, Stefan Monnier, 2021/03/17
- [elpa] externals/emms cd437ca 40/80: Fix byte compilation, Stefan Monnier, 2021/03/17
- [elpa] externals/emms a57cc7e 43/80: * emms-bookmarks.el: lexical scoping declaration, Stefan Monnier, 2021/03/17
- [elpa] externals/emms fcdb111 25/80: Add mappings for more id3v2 text frames, Stefan Monnier, 2021/03/17
- [elpa] externals/emms c8f198d 31/80: Put some id3v2.4 frame data to info-date instead of info-year, Stefan Monnier, 2021/03/17
- [elpa] externals/emms b7684ba 39/80: Match id3v1 genres in id3v2.4 frame, Stefan Monnier, 2021/03/17
- [elpa] externals/emms d12014d 50/80: * emms-i18n.el: lexical declaration, Stefan Monnier, 2021/03/17
- [elpa] externals/emms abf6b01 49/80: * emms-history.el: lexical declaration, Stefan Monnier, 2021/03/17
- [elpa] externals/emms 0fcea44 52/80: * emms-info.el: add lexical and remove unused lexical variable, Stefan Monnier, 2021/03/17
- [elpa] externals/emms ba16ff6 13/80: * emms-tag-editor.el: lexical compatibility work,
Stefan Monnier <=
- [elpa] externals/emms bf22384 16/80: Clean up Vorbis code, Stefan Monnier, 2021/03/17
- [elpa] externals/emms a879267 37/80: Decode id3v2 user-defined text frames, Stefan Monnier, 2021/03/17
- [elpa] externals/emms 5531af7 38/80: Add support for id3v1 genres, Stefan Monnier, 2021/03/17
- [elpa] externals/emms 6a1c281 66/80: * emms-player-mplayer.el: lexical declaration, Stefan Monnier, 2021/03/17
- [elpa] externals/emms 7ca6cd3 70/80: * emms-playlist-mode.el:, Stefan Monnier, 2021/03/17
- [elpa] externals/emms 89ccb7d 75/80: Rewrite manual Chapter 13 Track Information, Stefan Monnier, 2021/03/17
- [elpa] externals/emms 7bb5f7f 29/80: Improve id3v2 validity checks, Stefan Monnier, 2021/03/17
- [elpa] externals/emms bfae6b2 34/80: Replace curved quotes with ASCII quotes, Stefan Monnier, 2021/03/17
- [elpa] externals/emms 51d1877 42/80: * emms.info: update dates, Stefan Monnier, 2021/03/17
- [elpa] externals/emms b04ac71 45/80: * emms-cache.el: explicit ignore, Stefan Monnier, 2021/03/17