[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[elpa] externals/ivy-hydra d3c6cc1 205/395: Adapt tests to when wgrep is
From: |
Basil L. Contovounesios |
Subject: |
[elpa] externals/ivy-hydra d3c6cc1 205/395: Adapt tests to when wgrep is not installed |
Date: |
Thu, 25 Feb 2021 08:32:03 -0500 (EST) |
branch: externals/ivy-hydra
commit d3c6cc1b00b6ffa1ffb1b604c03fd307a4ba5f85
Author: Basil L. Contovounesios <contovob@tcd.ie>
Commit: Oleh Krehel <ohwoeowho@gmail.com>
Adapt tests to when wgrep is not installed
ivy-test.el (ivy-swiper-wgrep): Make test more reliable by skipping
if conditions aren't met instead of trying to predict whether things
will fail. Skip test if wgrep is not installed and bump its Emacs
version requirement to Emacs 25 or later, which has been the case
since 2018:
https://github.com/mhayashi1120/Emacs-wgrep/commit/6f04cd7aa2ad67983082f778f0e34fb28970866a
Fixes #2522
---
ivy-test.el | 8 +++-----
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/ivy-test.el b/ivy-test.el
index e1b2174..1ab10bd 100644
--- a/ivy-test.el
+++ b/ivy-test.el
@@ -1365,11 +1365,9 @@ a buffer visiting a file."
"Foo\nfoo|\nFOO\n")))
(ert-deftest ivy-swiper-wgrep ()
- :expected-result (if (and (= emacs-major-version 24)
- (<= emacs-minor-version 3))
- ;; `wgrep' requires at least 24.5
- :failed
- :passed)
+ ;; `wgrep' requires Emacs 25 or later.
+ (skip-unless (and (>= emacs-major-version 25)
+ (require 'wgrep nil t)))
(dolist (search-cmd '(swiper swiper-isearch))
(should
(string=
- [elpa] externals/ivy-hydra 5e393b0 047/395: .travis.yml (env): Bump to emacs-26.3-travis, (continued)
- [elpa] externals/ivy-hydra 5e393b0 047/395: .travis.yml (env): Bump to emacs-26.3-travis, Basil L. Contovounesios, 2021/02/25
- [elpa] externals/ivy-hydra 2d4d6d6 076/395: Use text, not "current", in -dispatching-done when no matches, Basil L. Contovounesios, 2021/02/25
- [elpa] externals/ivy-hydra 8c23823 073/395: ivy-test.el (ivy-swiper-wgrep): Re-enable on 24.5, Basil L. Contovounesios, 2021/02/25
- [elpa] externals/ivy-hydra 9e7f21a 078/395: ivy.el (ivy-completing-read): Fix require-match arg being symbol, Basil L. Contovounesios, 2021/02/25
- [elpa] externals/ivy-hydra 3c6e5da 091/395: Remove counsel--grep-mode-occur, Basil L. Contovounesios, 2021/02/25
- [elpa] externals/ivy-hydra e22c8df 103/395: counsel.el (counsel-git-cands): Avoid an extra call to counsel-git-root, Basil L. Contovounesios, 2021/02/25
- [elpa] externals/ivy-hydra 044f82c 106/395: ivy.el (ivy-set-text): Add, Basil L. Contovounesios, 2021/02/25
- [elpa] externals/ivy-hydra 0a08436 169/395: ivy.el (ivy--set-candidates): Delete duplicates only for extra sources, Basil L. Contovounesios, 2021/02/25
- [elpa] externals/ivy-hydra 22422dd 219/395: counsel.el (counsel-fonts): Add a custom transformer with font sample, Basil L. Contovounesios, 2021/02/25
- [elpa] externals/ivy-hydra 7b3b672 230/395: counsel.el (counsel-company): Fix difference between company-common and company-prefix, Basil L. Contovounesios, 2021/02/25
- [elpa] externals/ivy-hydra d3c6cc1 205/395: Adapt tests to when wgrep is not installed,
Basil L. Contovounesios <=
- [elpa] externals/ivy-hydra 5ac1c97 190/395: ivy.el (ivy-dispatching-call): Fix ivy-text being "" for ivy-read-action-ivy, Basil L. Contovounesios, 2021/02/25
- [elpa] externals/ivy-hydra 7abf656 192/395: Allow counsel-cd to run even if recursive minibuffers are not enabled, Basil L. Contovounesios, 2021/02/25
- [elpa] externals/ivy-hydra dd8f519 206/395: Fix ivy-completion-in-region return value, Basil L. Contovounesios, 2021/02/25
- [elpa] externals/ivy-hydra 50b02a0 222/395: Remove unused lexical variable in recent test, Basil L. Contovounesios, 2021/02/25
- [elpa] externals/ivy-hydra a5c6ef9 231/395: counsel-kmacro: Create separator with defcustom instead of defvar., Basil L. Contovounesios, 2021/02/25
- [elpa] externals/ivy-hydra 4f6bd9e 210/395: .dir-locals.el (outline-regexp): "^(" is not an outline start, Basil L. Contovounesios, 2021/02/25
- [elpa] externals/ivy-hydra 334d08c 227/395: ivy.el (ivy--update-history): Use ivy-text if it's not "", Basil L. Contovounesios, 2021/02/25
- [elpa] externals/ivy-hydra 24e68ea 225/395: counsel.el (counsel-git-log-cmd): Disable coloring., Basil L. Contovounesios, 2021/02/25
- [elpa] externals/ivy-hydra cfb395e 239/395: counsel.el (counsel--sync-sentinel-on-exit): Simplify, Basil L. Contovounesios, 2021/02/25
- [elpa] externals/ivy-hydra f4a7d87 241/395: Fix recent addition of caddr in counsel.el, Basil L. Contovounesios, 2021/02/25