emacs-elpa-diffs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[elpa] externals/arbitools d9e940b 06/29: * packages/arbitools.el: fix c


From: Stefan Monnier
Subject: [elpa] externals/arbitools d9e940b 06/29: * packages/arbitools.el: fix coding issues
Date: Sun, 29 Nov 2020 19:00:33 -0500 (EST)

branch: externals/arbitools
commit d9e940b07b8b4876dba7e0127ee1f64b8cd4fe04
Author: David Gonzalez Gandara <dggandara@member.fsf.org>
Commit: David Gonzalez Gandara <dggandara@member.fsf.org>

    * packages/arbitools.el: fix coding issues
---
 arbitools.el | 10 +++-------
 1 file changed, 3 insertions(+), 7 deletions(-)

diff --git a/arbitools.el b/arbitools.el
index 7f2a4de..1377f6d 100644
--- a/arbitools.el
+++ b/arbitools.el
@@ -57,9 +57,7 @@
 
 (defun arbitools-add (addfile)
   "Add players to an existing file."
-  ;; FIXME: is `addfile' a file?  If o, then use "f" rather than "s", else
-  ;; better give it another name!
-  (interactive "saddfile: ")
+  (interactive "faddfile: ")
   ;; FIXME: What if `addlist' is "foo; bar"?
   ;; FIXME: Do we really need a shell here?
   ;; Why not use just call-process, so we don't need to worry about quoting?
@@ -76,9 +74,7 @@
                          (shell-quote-argument buffer-file-name))))
 
 (defvar arbitools-highlights
- '(("^001" . font-lock-function-name-face) ;name of the tournament
-   ;; ("\\( b \\)\\|\\( w \\)\\|\\( - \\)" . font-lock-keyword-face) ;colour
-    ;; ("\\( 1 \\)\\|\\( 0 \\)\\|\\( = \\)". font-lock-type-face) ;results
+ '(("^001" . font-lock-function-name-face) ; name of the tournament
     ("^012.*" . font-lock-comment-face)
     
("\\(^022\\|^032\\|^042\\|^052\\|^062\\|^072\\|^082\\|^092\\|^102\\|^112\\|^122\\).*"
 . font-lock-constant-face)
     ("^132.*" . font-lock-warning-face) ;dates
@@ -86,7 +82,7 @@
     ("\\(^013.\\{1\\}\\)\\(.\\{31\\}\\)" 2 font-lock-comment-face) ;; teams
     ;; (" [0-9]\\{6,\\} " . font-lock-variable-name-face) ;FIDE ID
     ("\\(^001.\\{11\\}\\)\\(.\\{32\\}\\)" 2 font-lock-string-face)  ;; Name of 
the player (by position)
-    ("\\(^001.\\{55\\}\\)\\(.\\{10\\}\\)" 2 font-lock-function-name-face) 
;FIDE ID
+    ("\\(^001.\\{55\\}\\)\\(.\\{10\\}\\)" 2 font-lock-function-name-face) ;; 
FIDE ID
     ("\\(^001.\\{88\\}\\)\\(.\\{4\\}\\)" 2 font-lock-comment-face) ;; round 1 
opponent
     ;; ("\\(^132.\\{88\\}\\)\\(.\\{8\\}\\)" 2 font-lock-string-face) ;; round 
1 date line
     ("\\(^001.\\{93\\}\\)\\(.\\{1\\}\\)" 2 font-lock-string-face) ;; round 1 
colour



reply via email to

[Prev in Thread] Current Thread [Next in Thread]