emacs-elpa-diffs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[elpa] externals/debbugs 1fdcac3 029/311: * debbugs-gnu.el (debbugs-widg


From: Stefan Monnier
Subject: [elpa] externals/debbugs 1fdcac3 029/311: * debbugs-gnu.el (debbugs-widget-map): Add [mouse-1] and [mouse-2].
Date: Sun, 29 Nov 2020 18:41:34 -0500 (EST)

branch: externals/debbugs
commit 1fdcac347a24aec78fef47512b2ae1623761951b
Author: Michael Albinus <michael.albinus@gmx.de>
Commit: Michael Albinus <michael.albinus@gmx.de>

    * debbugs-gnu.el (debbugs-widget-map): Add [mouse-1] and [mouse-2].
    (debbugs-emacs): Add :help-echo and :suppress-done for report
    pages' widgets.
    (debbugs-show-reports): Remove suppress-done from arguments. It
    must be read from the widget anyway. Tune inserting of bottom line
    widgets.
---
 ChangeLog      |  9 +++++++++
 debbugs-gnu.el | 34 ++++++++++++++++------------------
 2 files changed, 25 insertions(+), 18 deletions(-)

diff --git a/ChangeLog b/ChangeLog
index d4087e0..545bc4f 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,12 @@
+2011-07-03  Michael Albinus  <michael.albinus@gmx.de>
+
+       * debbugs-gnu.el (debbugs-widget-map): Add [mouse-1] and [mouse-2].
+       (debbugs-emacs): Add :help-echo and :suppress-done for report
+       pages' widgets.
+       (debbugs-show-reports): Remove suppress-done from arguments. It
+       must be read from the widget anyway. Tune inserting of bottom line
+       widgets.
+
 2011-07-03  Lars Magne Ingebrigtsen  <larsi@gnus.org>
 
        * debbugs-gnu.el (debbugs-emacs): Don't use widgets to provide
diff --git a/debbugs-gnu.el b/debbugs-gnu.el
index 29ddb1b..0635bb3 100644
--- a/debbugs-gnu.el
+++ b/debbugs-gnu.el
@@ -50,6 +50,8 @@
 (defvar debbugs-widget-map
   (let ((map (make-sparse-keymap)))
     (define-key map "\r" 'widget-button-press)
+    (define-key map [mouse-1] 'widget-button-press)
+    (define-key map [mouse-2] 'widget-button-press)
     map))
 
 (defun debbugs-emacs (severities &optional package suppress-done archivedp)
@@ -98,36 +100,39 @@
                             :follow-link 'mouse-face
                             :notify (lambda (widget &rest ignore)
                                       (debbugs-show-reports
-                                       (widget-get widget :suppress-done)
                                        widget
                                        (widget-get widget :widgets)))
                             :keymap debbugs-widget-map
                             :suppress-done suppress-done
                             :buffer-name (format "*Emacs Bugs*<%d>" i)
-                            :bug-ids (butlast ids (- (length ids) default))
-                            (format " %d" i))))
+                            :bug-ids curr-ids
+                            :help-echo (format
+                                        "%d-%d"
+                                        (car ids) (car (last curr-ids)))
+                            :format " %[%v%]"
+                            (number-to-string i))))
                  ids (last ids (- (length ids) default))))
-         (debbugs-show-reports suppress-done (car widgets) widgets))
+         (debbugs-show-reports (car widgets) widgets))
 
-      (debbugs-show-reports suppress-done
-                           (widget-convert
+      (debbugs-show-reports (widget-convert
                             'const
+                            :suppress-done suppress-done
                             :buffer-name "*Emacs Bugs*"
                             :bug-ids ids)
                            nil))))
 
-(defun debbugs-show-reports (suppress-done widget widgets)
+(defun debbugs-show-reports (widget widgets)
   "Show bug reports as given in WIDGET property :bug-ids."
   (pop-to-buffer (get-buffer-create (widget-get widget :buffer-name)))
   (debbugs-mode)
-  (let ((inhibit-read-only t))
+  (let ((inhibit-read-only t)
+       (suppress-done (widget-get widget :suppress-done)))
     (erase-buffer)
 
     (when widgets
       (widget-insert "Page:")
       (mapc
        (lambda (obj)
-        (widget-insert " ")
         (widget-put obj :widgets widgets)
         (if (eq obj widget)
             (widget-put obj :button-face 'widget-button-pressed)
@@ -201,17 +206,10 @@
 
     (when widgets
       (widget-insert "\nPage:")
-      (mapc
-       (lambda (obj)
-        (widget-insert " ")
-        (widget-put obj :widgets widgets)
-        (if (eq obj widget)
-            (widget-put obj :button-face 'widget-button-pressed)
-          (widget-put obj :button-face 'widget-button-face))
-        (widget-apply obj :create))
-       widgets)
+      (mapc (lambda (obj) (widget-apply obj :create)) widgets)
       (widget-setup))
 
+    (set-buffer-modified-p nil)
     (goto-char (point-min))))
 
 (defvar debbugs-mode-map



reply via email to

[Prev in Thread] Current Thread [Next in Thread]