[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[elpa] externals/gnugo 91f2d79 318/357: [gnugo int] Avoid latent order-o
From: |
Stefan Monnier |
Subject: |
[elpa] externals/gnugo 91f2d79 318/357: [gnugo int] Avoid latent order-of-evaluation error. |
Date: |
Sun, 29 Nov 2020 14:51:48 -0500 (EST) |
branch: externals/gnugo
commit 91f2d798013ea0c410a019ebe8afc80309d8c8e4
Author: Thien-Thi Nguyen <ttn@gnu.org>
Commit: Thien-Thi Nguyen <ttn@gnu.org>
[gnugo int] Avoid latent order-of-evaluation error.
* packages/gnugo/gnugo.el (gnugo--decorate): Replace sibling ‘pop’
calls as args to ‘cons’ w/ explicit sequencing and local vars.
---
gnugo.el | 13 ++++++++++---
1 file changed, 10 insertions(+), 3 deletions(-)
diff --git a/gnugo.el b/gnugo.el
index c644850..b466e24 100644
--- a/gnugo.el
+++ b/gnugo.el
@@ -897,9 +897,16 @@ For all other values of RSEL, do nothing and return nil."
with fruit
while plist
do (setf
- fruit (list (cons ; DWR: LtR OoE assumed.
- (pop plist)
- (pop plist)))
+ fruit (list
+ ;; Albeit elegant, this assumes LtR OoE, unfortunately.
+ ;;- (cons
+ ;; (pop plist)
+ ;; (pop plist))
+ ;; Instead, we use ‘let*’ for explicit sequencing.
+ ;; Let the Scheme-based Emacs hacking proceed apace!
+ (let* ((k (pop plist))
+ (v (pop plist)))
+ (cons k v)))
(cdr tp) fruit
tp fruit)))
- [elpa] externals/gnugo bc4abdc 238/357: [gnugo int] Centralize some "No stone at POS" errors., (continued)
- [elpa] externals/gnugo bc4abdc 238/357: [gnugo int] Centralize some "No stone at POS" errors., Stefan Monnier, 2020/11/29
- [elpa] externals/gnugo 78edde4 247/357: [gnugo maint] Update HACKING; nfc., Stefan Monnier, 2020/11/29
- [elpa] externals/gnugo 52251ac 270/357: [gnugo int] Move karma state normalization down-chain., Stefan Monnier, 2020/11/29
- [elpa] externals/gnugo 5a201a8 286/357: [gnugo] Fix bug: For GTP "help COMMAND", leave point in right place., Stefan Monnier, 2020/11/29
- [elpa] externals/gnugo 3540673 272/357: [gnugo] Make SGF I/O commands change ‘default-directory’., Stefan Monnier, 2020/11/29
- [elpa] externals/gnugo ac1adcd 276/357: [gnugo] Make ‘gnugo-xpms’ a normal var; drop it as feature., Stefan Monnier, 2020/11/29
- [elpa] externals/gnugo 079b73c 279/357: [gnugo int] Commentary munging; nfc., Stefan Monnier, 2020/11/29
- [elpa] externals/gnugo de92f27 296/357: [gnugo imgen] Add autoload cookie., Stefan Monnier, 2020/11/29
- [elpa] externals/gnugo 7db9d5e 295/357: [gnugo] Declare package keywords., Stefan Monnier, 2020/11/29
- [elpa] externals/gnugo ab69d4b 294/357: [gnugo frolic] Promote frolic mode/funcs to feature., Stefan Monnier, 2020/11/29
- [elpa] externals/gnugo 91f2d79 318/357: [gnugo int] Avoid latent order-of-evaluation error.,
Stefan Monnier <=
- [elpa] externals/gnugo b086082 321/357: Add some THANKS files; nfc., Stefan Monnier, 2020/11/29
- [elpa] externals/gnugo 4c07c67 320/357: [gnugo int] Revert bogus OoE avoidance fix, w/ better comment., Stefan Monnier, 2020/11/29
- [elpa] externals/gnugo 5383e47 326/357: [gnugo int] Shirk syntax, abbrev tables in Gnugo Board mode., Stefan Monnier, 2020/11/29
- [elpa] externals/gnugo e5cba8f 344/357: [gnugo] Formalize game-over "group"; use symbolic color., Stefan Monnier, 2020/11/29
- [elpa] externals/gnugo a38cd9e 348/357: [gnugo int] Comment munging; nfc., Stefan Monnier, 2020/11/29