emacs-elpa-diffs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[elpa] externals/gnugo 7b29f73 219/357: [gnugo int] Decruft: Don't stash


From: Stefan Monnier
Subject: [elpa] externals/gnugo 7b29f73 219/357: [gnugo int] Decruft: Don't stash :proc-args.
Date: Sun, 29 Nov 2020 14:51:25 -0500 (EST)

branch: externals/gnugo
commit 7b29f73a9e2c900d210ec7bb587b6382d5824b67
Author: Thien-Thi Nguyen <ttn@gnu.org>
Commit: Thien-Thi Nguyen <ttn@gnu.org>

    [gnugo int] Decruft: Don't stash :proc-args.
    
    * packages/gnugo/gnugo.el (gnugo): ...here.
---
 gnugo.el | 22 ++++++++++------------
 1 file changed, 10 insertions(+), 12 deletions(-)

diff --git a/gnugo.el b/gnugo.el
index b1de724..c74244c 100644
--- a/gnugo.el
+++ b/gnugo.el
@@ -2435,11 +2435,15 @@ starting a new one.  See `gnugo-board-mode' 
documentation for more info."
       ;; set up a new board
       (switch-to-buffer (generate-new-buffer "(Uninitialized GNUGO Board)"))
       (gnugo-board-mode)
-      (let ((args (read-string "GNU Go options: "
-                               (car gnugo-option-history)
-                               'gnugo-option-history))
-            proc
-            board-size user-color handicap komi minus-l infile)
+      (let* ((args (read-string "GNU Go options: "
+                                (car gnugo-option-history)
+                                'gnugo-option-history))
+             (proc (apply 'start-process "gnugo"
+                          (current-buffer)
+                          gnugo-program
+                          "--mode" "gtp" "--quiet"
+                          (split-string args)))
+             board-size user-color handicap komi minus-l infile)
         (loop for (var default opt rx)
               in '((board-size      19 "--boardsize")
                    (user-color "black" "--color" "\\(black\\|white\\)")
@@ -2455,13 +2459,7 @@ starting a new one.  See `gnugo-board-mode' 
documentation for more info."
                               (if rx s (string-to-number s))))
                           default)))
         (gnugo-put :user-color user-color)
-        (let ((proc-args (split-string args)))
-          (gnugo-put :proc-args proc-args)
-          (gnugo-put :proc (setq proc (apply 'start-process "gnugo"
-                                             (current-buffer)
-                                             gnugo-program
-                                             "--mode" "gtp" "--quiet"
-                                             proc-args))))
+        (gnugo-put :proc proc)
         (set-process-sentinel proc 'gnugo-sentinel)
         ;; Emacs is too protective sometimes, blech.
         (set-process-query-on-exit-flag proc nil)



reply via email to

[Prev in Thread] Current Thread [Next in Thread]