[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[elpa] externals/gnugo c5ef13d 334/357: [gnugo] Make ‘gnugo-goto-pos’ r
From: |
Stefan Monnier |
Subject: |
[elpa] externals/gnugo c5ef13d 334/357: [gnugo] Make ‘gnugo-goto-pos’ return buffer position. |
Date: |
Sun, 29 Nov 2020 14:51:51 -0500 (EST) |
branch: externals/gnugo
commit c5ef13d3c8e8c2b9690838ac46d17694dfa0cdbf
Author: Thien-Thi Nguyen <ttn@gnu.org>
Commit: Thien-Thi Nguyen <ttn@gnu.org>
[gnugo] Make ‘gnugo-goto-pos’ return buffer position.
* packages/gnugo/gnugo.el (gnugo-goto-pos):
Return final buffer position, i.e., point.
(gnugo-refresh): Coalesce ‘gnugo-goto-pos’ call followed by
‘point’ call into a ‘gnugo-goto-pos’ call at the original
‘point’ caller position.
(gnugo-animate-group): Likewise.
---
gnugo.el | 19 +++++++++----------
1 file changed, 9 insertions(+), 10 deletions(-)
diff --git a/gnugo.el b/gnugo.el
index ed5e07d..f5f1f86 100644
--- a/gnugo.el
+++ b/gnugo.el
@@ -490,7 +490,8 @@ when you are sure the command cannot fail."
(cdr (last root))))))
(defun gnugo-goto-pos (pos)
- "Move point to board position POS, a letter-number string."
+ "Move point to board position POS, a letter-number string.
+Return final buffer position (i.e., point)."
(goto-char (point-min))
(forward-line (- (1+ (gnugo-get :SZ))
(string-to-number (substring pos 1))))
@@ -500,7 +501,8 @@ when you are sure the command cannot fail."
(if (> ?I letter)
letter
(1- letter)))
- ?A)))))
+ ?A))))
+ (point))
(defun gnugo-f (id)
(intern (if (symbolp id)
@@ -1072,8 +1074,7 @@ its move."
(cl-destructuring-bind (l-ov . r-ov) (gnugo-get :paren-ov)
(if (member move '("PASS" "resign"))
(mapc 'delete-overlay (list l-ov r-ov))
- (gnugo-goto-pos move)
- (let* ((p (point))
+ (let* ((p (gnugo-goto-pos move))
(hspec (gnugo-get :highlight-last-move-spec))
(display-value (nth 0 hspec))
(l-offset (nth 1 hspec))
@@ -1105,8 +1106,7 @@ its move."
(unless (eq game-over (get-text-property 1 'game-over))
(dolist (group (append live dead))
(dolist (pos (cdr group))
- (gnugo-goto-pos pos)
- (setq p (point))
+ (setq p (gnugo-goto-pos pos))
(put-text-property p (1+ p) 'group group)))
(put-text-property 1 2 'game-over game-over))
(dolist (group live)
@@ -1118,8 +1118,8 @@ its move."
(let (ov pall c (color (caar group)))
(setq c (if (gnugo--blackp color) "x" "o"))
(dolist (pos (cdr group))
- (gnugo-goto-pos pos)
- (setq p (point) ov (make-overlay p (1+ p)))
+ (setq p (gnugo-goto-pos pos)
+ ov (make-overlay p (1+ p)))
(overlay-put
ov 'display
(if (gnugo-get :display-using-images)
@@ -1431,8 +1431,7 @@ To start a game try M-x gnugo."
(cell (list spec))
(ovs (save-excursion
(mapcar (lambda (pos)
- (gnugo-goto-pos pos)
- (let* ((p (point))
+ (let* ((p (gnugo-goto-pos pos))
(ov (make-overlay p (1+ p))))
(overlay-put ov 'category (gnugo-f 'anim))
(overlay-put ov 'priority most-positive-fixnum)
- [elpa] externals/gnugo 46eec46 285/357: [gnugo int] Simplify COND expression., (continued)
- [elpa] externals/gnugo 46eec46 285/357: [gnugo int] Simplify COND expression., Stefan Monnier, 2020/11/29
- [elpa] externals/gnugo eaae57d 324/357: [gnugo int] Add Juanma Barranquero to THANKS; nfc., Stefan Monnier, 2020/11/29
- [elpa] externals/gnugo bb986d7 323/357: [gnugo] Release: 3.0.2, Stefan Monnier, 2020/11/29
- [elpa] externals/gnugo 64bd753 327/357: [gnugo int] Simplify SGF-write subroutine., Stefan Monnier, 2020/11/29
- [elpa] externals/gnugo c6eb3d1 325/357: [gnugo maint] Add people from ttn-pers-elisp THANKS file; nfc., Stefan Monnier, 2020/11/29
- [elpa] externals/gnugo 981d75e 341/357: [gnugo] Fix bug: Don't clobber dead-group indication on refresh., Stefan Monnier, 2020/11/29
- [elpa] externals/gnugo e4344ac 350/357: [gnugo] Release: 3.1.0, Stefan Monnier, 2020/11/29
- [elpa] externals/gnugo af82527 356/357: [gnugo] Release: 3.1.1, Stefan Monnier, 2020/11/29
- [elpa] externals/gnugo 53da06f 329/357: [gnugo] Make ‘gnugo-comment’ fall back to root node., Stefan Monnier, 2020/11/29
- [elpa] externals/gnugo 781a385 332/357: [gnugo] Drop trailing fullstop for "... done" messages., Stefan Monnier, 2020/11/29
- [elpa] externals/gnugo c5ef13d 334/357: [gnugo] Make ‘gnugo-goto-pos’ return buffer position.,
Stefan Monnier <=
- [elpa] externals/gnugo 6170d2a 333/357: [gnugo] Make ‘C-c C-p’ output more spacious., Stefan Monnier, 2020/11/29
- [elpa] externals/gnugo 0320a5c 335/357: [gnugo int] Decruft: Don't bother w/ ‘group’ text property., Stefan Monnier, 2020/11/29
- [elpa] externals/gnugo 8123275 338/357: [gnugo] Drop trailing fullstop in animation message., Stefan Monnier, 2020/11/29
- [elpa] externals/gnugo 08f11af 339/357: [gnugo int] Incorporate ‘gnugo-toggle-image-display’ into unique caller., Stefan Monnier, 2020/11/29
- [elpa] externals/gnugo 1e01c65 340/357: [gnugo] When sorry, say "Sorry" first., Stefan Monnier, 2020/11/29
- [elpa] externals/gnugo 3541ccf 343/357: [gnugo int] Lift redundant pall of death computation., Stefan Monnier, 2020/11/29
- [elpa] externals/gnugo 38b2529 124/357: [gnugo int] Add abstraction: gnugo--mkht, Stefan Monnier, 2020/11/29
- [elpa] externals/gnugo 0f9f540 125/357: [gnugo int] Maintain tree MNUM., Stefan Monnier, 2020/11/29
- [elpa] externals/gnugo 7211950 346/357: [gnugo] Indicate seki groups on the board., Stefan Monnier, 2020/11/29
- [elpa] externals/gnugo 35c4645 347/357: [gnugo] Make ‘C-u F’ store additional SGF properties., Stefan Monnier, 2020/11/29