emacs-elpa-diffs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[elpa] externals/gnugo 558d778 072/357: [gnugo] Fix bug: Handle propert


From: Stefan Monnier
Subject: [elpa] externals/gnugo 558d778 072/357: [gnugo] Fix bug: Handle property value type ‘none’ normally.
Date: Sun, 29 Nov 2020 14:50:51 -0500 (EST)

branch: externals/gnugo
commit 558d778468a0c4b12d653a2c5b008e9f9a3ef75b
Author: Thien-Thi Nguyen <ttn@gnu.org>
Commit: Thien-Thi Nguyen <ttn@gnu.org>

    [gnugo] Fix bug: Handle property value type ‘none’ normally.
    
    * packages/gnugo/gnugo.el (gnugo/sgf-read-file one):
    No longer special case property value type ‘none’;
    instead, read the supplied value and discard it,
    saving instead a hardcoded empty string, i.e., "".
---
 NEWS     |  2 ++
 gnugo.el | 17 +++++++++--------
 2 files changed, 11 insertions(+), 8 deletions(-)

diff --git a/NEWS b/NEWS
index 5f33ce3..fbfec3b 100644
--- a/NEWS
+++ b/NEWS
@@ -9,6 +9,8 @@ Hint: (highlight-phrase 
"[0-9][.][0-9][.][0-9]+\\|[0-9]+[.][.][0-9]+"
 
 
 - next | NOT YET RELEASED
+  - bugfixes
+    - don't special-case property value type ‘none’
   - new keybinding for ‘gnugo-undo-one-move’: M-u
   - ‘gnugo-undo-one-move’ can optionally switch colors
   - performance improvements
diff --git a/gnugo.el b/gnugo.el
index ded615e..7b8b829 100644
--- a/gnugo.el
+++ b/gnugo.el
@@ -2087,14 +2087,15 @@ starting a new one.  See `gnugo-board-mode' 
documentation for more info."
                              (insert " "))
                             (t (forward-char 1))))
                     (buffer-substring-no-properties beg (point))))
-         (one (type end) (unless (eq 'none type)
-                           (forward-char 1)
-                           (let ((s (x end)))
-                             (case type
-                               ((stone point move simpletext color) s)
-                               ((number real double) (string-to-number s))
-                               ((text) s)
-                               (t (error "Unhandled type: %S" type))))))
+         (one (type end) (let ((s (progn
+                                    (forward-char 1)
+                                    (x end))))
+                           (case type
+                             ((stone point move simpletext color) s)
+                             ((number real double) (string-to-number s))
+                             ((text) s)
+                             ((none) "")
+                             (t (error "Unhandled type: %S" type)))))
          (val (spec) (cond ((symbolp spec)
                             (one spec :end))
                            ((vectorp spec)



reply via email to

[Prev in Thread] Current Thread [Next in Thread]