[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[elpa] externals/gnorb 2ca09f4 421/449: gnorb: Fix link following, bump

From: Stefan Monnier
Subject: [elpa] externals/gnorb 2ca09f4 421/449: gnorb: Fix link following, bump to 1.5.6
Date: Fri, 27 Nov 2020 23:16:24 -0500 (EST)

branch: externals/gnorb
commit 2ca09f4202ea43c9be37583b9b068f9da142993c
Author: Eric Abrahamsen <eric@ericabrahamsen.net>
Commit: Stefan Monnier <monnier@iro.umontreal.ca>

    gnorb: Fix link following, bump to 1.5.6
    * packages/gnorb/gnorb-utils.el (gnorb-open-gnus-link): Remove
      leftover article number caching: you're explicitly not supposed to
      do this with the registry (article numbers are subject to change)
      and it was causing problems.
    * packages/gnorb/gnorb.el: Bump and flush.
 gnorb-utils.el | 10 +++-------
 gnorb.el       |  2 +-
 2 files changed, 4 insertions(+), 8 deletions(-)

diff --git a/gnorb-utils.el b/gnorb-utils.el
index c38932b..3b6c7ab 100644
--- a/gnorb-utils.el
+++ b/gnorb-utils.el
@@ -156,7 +156,6 @@ and Gnus and BBDB maps."
 (defun gnorb-follow-gnus-link (group id)
   "Be a little clever about following gnus links.
 The goal here is reuse frames and windows as much as possible, so
 we're not opening multiple windows on the *Group* buffer, for
 instance, and messing up people's layouts. There also seems to be
@@ -211,16 +210,13 @@ window."
   ;; called from elsewhere...
   (let* ((id (gnorb-bracket-message-id id))
         (arts (gnus-group-unread group))
-        artno success)
-    (or (setq artno (car (gnus-registry-get-id-key id 'artno)))
-       (progn
-         (setq artno (cdr (gnus-request-head id group)))
-         (gnus-registry-set-id-key id 'artno (list artno))))
+        (artno (cdr (gnus-request-head id group)))
+        success)
     (gnus-activate-group group)
     (setq success (gnus-group-read-group arts t group))
     (if success
        (gnus-summary-goto-article artno nil t)
-      (signal 'error "Group could not be opened."))))
+      (signal 'error (format "Group %s could not be opened." group)))))
 ;; I'd like to suggest this as a general addition to Emacs.  *Very*
 ;; tired of abusing `completing-read' for this purpose.
diff --git a/gnorb.el b/gnorb.el
index ffd778d..5c47a49 100644
--- a/gnorb.el
+++ b/gnorb.el
@@ -2,7 +2,7 @@
 ;; Copyright (C) 2018  Free Software Foundation, Inc.
-;; Version: 1.5.5
+;; Version: 1.5.6
 ;; Package-Requires: ((cl-lib "0.5"))
 ;; Maintainer: Eric Abrahamsen <eric@ericabrahamsen.net>

reply via email to

[Prev in Thread] Current Thread [Next in Thread]