[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[elpa] externals/gnorb 8509773 376/449: Don't let the Gnus summary forma
From: |
Stefan Monnier |
Subject: |
[elpa] externals/gnorb 8509773 376/449: Don't let the Gnus summary format group create registry entries |
Date: |
Fri, 27 Nov 2020 23:16:15 -0500 (EST) |
branch: externals/gnorb
commit 850977345d02c1f331507a3152c4d121044e3418
Author: Eric Abrahamsen <eric@ericabrahamsen.net>
Commit: Stefan Monnier <monnier@iro.umontreal.ca>
Don't let the Gnus summary format group create registry entries
* packages/gnorb/gnorb-gnus.el (gnorb-gnus-insert-format-letter-maybe):
This function was unilaterally creating entries because of its use
of `gnus-regsitry-get-id-key'. Because it does not respect ignored
registry groups, we should use lower-level functions that don't
create an entry where there wasn't one.
---
gnorb-gnus.el | 23 ++++++++++++++---------
1 file changed, 14 insertions(+), 9 deletions(-)
diff --git a/gnorb-gnus.el b/gnorb-gnus.el
index e682391..5a75bc0 100644
--- a/gnorb-gnus.el
+++ b/gnorb-gnus.el
@@ -749,15 +749,20 @@ option `gnorb-gnus-hint-relevant-article' is non-nil."
(add-hook 'gnus-select-article-hook 'gnorb-gnus-hint-relevant-message)
(defun gnorb-gnus-insert-format-letter-maybe (header)
- (if (not (memq (car (gnus-find-method-for-group
- gnus-newsgroup-name))
- '(nnvirtual nnir)))
- (cond ((gnus-registry-get-id-key
- (mail-header-message-id header) 'gnorb-ids)
- gnorb-gnus-summary-tracked-mark)
- ((gnorb-find-tracked-headings header)
- gnorb-gnus-summary-mark)
- (t " "))
+ (if (not (or (gnus-ephemeral-group-p gnus-newsgroup-name)
+ (gnus-virtual-group-p gnus-newsgroup-name)))
+ (let* ((id (mail-header-message-id header))
+ ;; Use lower-level accessor to avoid creating an entry
+ ;; where there wasn't one. This function doesn't respect
+ ;; ignored registry groups.
+ (entry (nth 1 (assoc id (registry-lookup
+ gnus-registry-db
+ (list id))))))
+ (cond ((cdr-safe (assq 'gnorb-ids entry))
+ gnorb-gnus-summary-tracked-mark)
+ ((gnorb-find-tracked-headings header)
+ gnorb-gnus-summary-mark)
+ (t " ")))
" "))
(fset (intern (concat "gnus-user-format-function-"
- [elpa] externals/gnorb c1014ac 359/449: Merge pull request #31 from berhoel/master, (continued)
- [elpa] externals/gnorb c1014ac 359/449: Merge pull request #31 from berhoel/master, Stefan Monnier, 2020/11/27
- [elpa] externals/gnorb 64e72d6 360/449: Use :package-version, not :version, on defcustom, Stefan Monnier, 2020/11/27
- [elpa] externals/gnorb 3090162 361/449: Bump version to 1.1.4, Stefan Monnier, 2020/11/27
- [elpa] externals/gnorb c0b3090 362/449: Fix email subtree command, Stefan Monnier, 2020/11/27
- [elpa] externals/gnorb 6cdf064 365/449: Remove useless use of progn, update usage status function, Stefan Monnier, 2020/11/27
- [elpa] externals/gnorb 6a3ea57 368/449: Update documentation, Stefan Monnier, 2020/11/27
- [elpa] externals/gnorb d61d9b8 370/449: Remove unnecessary with-no-warnings, Stefan Monnier, 2020/11/27
- [elpa] externals/gnorb a370e64 372/449: Rename msg-id-to-group to msg-id-request-head, refactor, Stefan Monnier, 2020/11/27
- [elpa] externals/gnorb 943606f 373/449: Bump Gnorb version to 1.2, Stefan Monnier, 2020/11/27
- [elpa] externals/gnorb e7fa2d2 378/449: New copy-message-text behavior, Stefan Monnier, 2020/11/27
- [elpa] externals/gnorb 8509773 376/449: Don't let the Gnus summary format group create registry entries,
Stefan Monnier <=
- [elpa] externals/gnorb 4b215ae 379/449: gnorb-utils needs macros from nnheader, Stefan Monnier, 2020/11/27
- [elpa] externals/gnorb 4a732d9 384/449: Tweak text search in gnorb-org-view, Stefan Monnier, 2020/11/27
- [elpa] externals/gnorb d304558 383/449: Fix replying to most recent tracked message; bump to 1.3.2, Stefan Monnier, 2020/11/27
- [elpa] externals/gnorb b630235 390/449: Gnorb: Tweaks to gnorb-org-extract-mail-tracking, Stefan Monnier, 2020/11/27
- [elpa] externals/gnorb 9e95e90 387/449: Gnorb: New option gnorb-gnus-tick-all-tracked-messages, Stefan Monnier, 2020/11/27
- [elpa] externals/gnorb 09d5487 386/449: New option gnorb-org-log-add-link, Stefan Monnier, 2020/11/27
- [elpa] externals/gnorb ed11f5d 399/449: Gnorb: Fix and bump to 1.4.2, Stefan Monnier, 2020/11/27
- [elpa] externals/gnorb a3f4fbd 400/449: Gnorb: The proper link type is "mailto", not "mail", Stefan Monnier, 2020/11/27
- [elpa] externals/gnorb ba976d5 401/449: Prefer defalias to fset, Stefan Monnier, 2020/11/27
- [elpa] externals/gnorb e8d0043 405/449: Missing a require for seq package, Stefan Monnier, 2020/11/27