[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[elpa] externals/gnorb 7ea06f9 339/449: Delete gnorb-prompt-for-bbdb-rec
From: |
Stefan Monnier |
Subject: |
[elpa] externals/gnorb 7ea06f9 339/449: Delete gnorb-prompt-for-bbdb-record |
Date: |
Fri, 27 Nov 2020 23:16:07 -0500 (EST) |
branch: externals/gnorb
commit 7ea06f9a49c30ff33c7fa621e34aee1baadb63c3
Author: Eric Abrahamsen <eric@ericabrahamsen.net>
Commit: Eric Abrahamsen <eric@ericabrahamsen.net>
Delete gnorb-prompt-for-bbdb-record
* gnorb-utils.el: This function is unnecessary, BBDB already provides
`bbdb-completing-read-record'! Don't re-invent wheel.
* gnorb-org.el (gnorb-org-contact-link): Use existing function.
* gnorb-bbdb.el (gnorb-bbdb-cite-contact): Use existing function.
---
gnorb-bbdb.el | 2 +-
gnorb-org.el | 2 +-
gnorb-utils.el | 15 ---------------
3 files changed, 2 insertions(+), 17 deletions(-)
diff --git a/gnorb-bbdb.el b/gnorb-bbdb.el
index 306ea01..c7e18d6 100644
--- a/gnorb-bbdb.el
+++ b/gnorb-bbdb.el
@@ -442,7 +442,7 @@ a prefix arg and \"*\", the prefix arg must come first."
;;;###autoload
(defun gnorb-bbdb-cite-contact (rec)
- (interactive (list (gnorb-prompt-for-bbdb-record)))
+ (interactive (list (bbdb-completing-read-record "Record: ")))
(let ((mail-string (bbdb-dwim-mail rec)))
(if (called-interactively-p 'any)
(insert mail-string)
diff --git a/gnorb-org.el b/gnorb-org.el
index 615e48b..fe7bcae 100644
--- a/gnorb-org.el
+++ b/gnorb-org.el
@@ -123,7 +123,7 @@ There's really no reason to use this instead of regular old
`org-insert-link' with BBDB completion. But there might be in the
future!"
;; this needs to handle an active region.
- (interactive (list (gnorb-prompt-for-bbdb-record)))
+ (interactive (list (bbdb-completing-read-record "Record: ")))
(let* ((name (bbdb-record-name rec))
(link (concat "bbdb:" (org-link-escape name))))
(org-store-link-props :type "bbdb" :name name
diff --git a/gnorb-utils.el b/gnorb-utils.el
index 4d473f1..723f27b 100644
--- a/gnorb-utils.el
+++ b/gnorb-utils.el
@@ -39,21 +39,6 @@
`gnorb-org-trigger-actions'"
"September 8, 2014" 'set)
-(defun gnorb-prompt-for-bbdb-record ()
- "Prompt the user for a BBDB record."
- (let ((recs (bbdb-records))
- name)
- (while (> (length recs) 1)
- (setq name
- (completing-read
- (format "Filter records by regexp (%d remaining): "
- (length recs))
- (mapcar 'bbdb-record-name recs)))
- (setq recs (bbdb-search recs name name name nil nil)))
- (if recs
- (car recs)
- (error "No matching records"))))
-
(defvar gnorb-tmp-dir (make-temp-file "emacs-gnorb" t)
"Temporary directory where attachments etc are saved.")
- [elpa] externals/gnorb 16931d7 352/449: New utility function gnorb-select-from-list, (continued)
- [elpa] externals/gnorb 16931d7 352/449: New utility function gnorb-select-from-list, Stefan Monnier, 2020/11/27
- [elpa] externals/gnorb c8521d4 156/449: gnorb-org-mail-todos should be nil by default, Stefan Monnier, 2020/11/27
- [elpa] externals/gnorb aedf0f2 169/449: Show status of relevant todo when hinting messages, Stefan Monnier, 2020/11/27
- [elpa] externals/gnorb 67edd80 239/449: Use mail-header-references, Stefan Monnier, 2020/11/27
- [elpa] externals/gnorb dfa0043 300/449: Safer usage of cl-subseq, Stefan Monnier, 2020/11/27
- [elpa] externals/gnorb 2d30b0c 310/449: Reset window conf after nnir-run-gnorb, Stefan Monnier, 2020/11/27
- [elpa] externals/gnorb a59dac2 317/449: Use hook for determining Gnorb summary minor mode, Stefan Monnier, 2020/11/27
- [elpa] externals/gnorb 7fcde77 328/449: Handle renaming of Org variable, Stefan Monnier, 2020/11/27
- [elpa] externals/gnorb d754d2f 336/449: Fixing `gnorb-bbdb-postings-styles', Stefan Monnier, 2020/11/27
- [elpa] externals/gnorb 984d5e6 338/449: gnorb-org.el: Don't use nreverse, Stefan Monnier, 2020/11/27
- [elpa] externals/gnorb 7ea06f9 339/449: Delete gnorb-prompt-for-bbdb-record,
Stefan Monnier <=
- [elpa] externals/gnorb e2afc4b 355/449: Switch on lexical binding across the board, Stefan Monnier, 2020/11/27
- [elpa] externals/gnorb 7d14112 358/449: Trying to fix issue #30., Stefan Monnier, 2020/11/27
- [elpa] externals/gnorb c1014ac 359/449: Merge pull request #31 from berhoel/master, Stefan Monnier, 2020/11/27
- [elpa] externals/gnorb 64e72d6 360/449: Use :package-version, not :version, on defcustom, Stefan Monnier, 2020/11/27
- [elpa] externals/gnorb 3090162 361/449: Bump version to 1.1.4, Stefan Monnier, 2020/11/27
- [elpa] externals/gnorb c0b3090 362/449: Fix email subtree command, Stefan Monnier, 2020/11/27
- [elpa] externals/gnorb 6cdf064 365/449: Remove useless use of progn, update usage status function, Stefan Monnier, 2020/11/27
- [elpa] externals/gnorb 6a3ea57 368/449: Update documentation, Stefan Monnier, 2020/11/27
- [elpa] externals/gnorb d61d9b8 370/449: Remove unnecessary with-no-warnings, Stefan Monnier, 2020/11/27
- [elpa] externals/gnorb a370e64 372/449: Rename msg-id-to-group to msg-id-request-head, refactor, Stefan Monnier, 2020/11/27