[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[elpa] externals/gnorb 15b35dc 269/449: Don't store a link to message we

From: Stefan Monnier
Subject: [elpa] externals/gnorb 15b35dc 269/449: Don't store a link to message we're replying to
Date: Fri, 27 Nov 2020 23:15:53 -0500 (EST)

branch: externals/gnorb
commit 15b35dc8b8b045af0fab248f23445472c0017095
Author: Eric Abrahamsen <eric@ericabrahamsen.net>
Commit: Eric Abrahamsen <eric@ericabrahamsen.net>

    Don't store a link to message we're replying to
    * gnorb-gnus.el (gnorb-gnus-outgoing-do-todo): When calling this
      function on an outgoing/sent message, don't go back and store a link
      to the original message we replied to.
    This was a holdover from the earlier system of links and properties. It
    slows everything down, and blinks the window annoyingly. What should
    happen instead is that a registry association is made for the message
    we're replying to. That can be done later.
 gnorb-gnus.el | 18 ++----------------
 1 file changed, 2 insertions(+), 16 deletions(-)

diff --git a/gnorb-gnus.el b/gnorb-gnus.el
index d19539a..db8c62b 100644
--- a/gnorb-gnus.el
+++ b/gnorb-gnus.el
@@ -336,8 +336,8 @@ work."
   (interactive "P")
   (let ((org-refile-targets gnorb-gnus-trigger-refile-targets)
        (compose-marker (make-marker))
-       header-ids ref-ids rel-headings gnorb-window-conf
-       reply-id reply-group in-reply-to)
+       header-ids ref-ids rel-headings
+       gnorb-window-conf in-reply-to)
     (when (equal arg '(4))
       (setq rel-headings
            (org-refile-get-location "Trigger action on" nil t))
@@ -374,8 +374,6 @@ work."
       ;; We are still in the message composition buffer, so let's see
       ;; what we've got.
-      ;; What we want is a link to the original message we're replying
-      ;; to, if this is actually a reply.
       (if (equal arg '(16))
          ;; Double prefix arg means delete the association we already
          ;; made.
@@ -390,8 +388,6 @@ work."
              (message "Message associations have been reset")))
-       (when message-reply-headers
-         (setq reply-id (aref message-reply-headers 4)))
        ;; Save-excursion won't work, because point will move if we
        ;; insert headings.
        (move-marker compose-marker (point))
@@ -407,16 +403,6 @@ work."
          (setq in-reply-to (unless arg (mail-fetch-field "In-Reply-to" t)))
          (when in-reply-to
            (setq ref-ids (concat ref-ids " " in-reply-to)))
-         (setq reply-group (when (mail-fetch-field "X-Draft-From" t)
-                             (car-safe (read (mail-fetch-field "X-Draft-From" 
-         ;; when it's a reply, store a link to the reply just in case.
-         ;; This is pretty embarrassing -- we follow a link just to
-         ;; create a link. But I'm not going to recreate all of
-         ;; `org-store-link' by hand.
-         (when (and reply-group reply-id)
-           (save-window-excursion
-             (org-gnus-follow-link reply-group reply-id)
-             (call-interactively 'org-store-link)))
          (when ref-ids
            ;; if the References header points to any message ids that are
            ;; tracked by TODO headings...

reply via email to

[Prev in Thread] Current Thread [Next in Thread]