[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[elpa] externals/gnorb b82576c 268/449: Always clear attachments during
From: |
Stefan Monnier |
Subject: |
[elpa] externals/gnorb b82576c 268/449: Always clear attachments during triggering |
Date: |
Fri, 27 Nov 2020 23:15:53 -0500 (EST) |
branch: externals/gnorb
commit b82576c9f7c1646e2e61f53c8c9989fc86b0559b
Author: Eric Abrahamsen <eric@ericabrahamsen.net>
Commit: Eric Abrahamsen <eric@ericabrahamsen.net>
Always clear attachments during triggering
* gnorb-utils.el (gnorb-trigger-todo-action):
`gnorb-gnus-capture-attachments' needs to be set to nil even if there
are errors. Leaving that variable populated, even if the trigger
process fails/aborts, can be very confusing.
---
gnorb-utils.el | 22 ++++++++++++----------
1 file changed, 12 insertions(+), 10 deletions(-)
diff --git a/gnorb-utils.el b/gnorb-utils.el
index 01a5e16..dbe9e99 100644
--- a/gnorb-utils.el
+++ b/gnorb-utils.el
@@ -239,16 +239,18 @@ agenda. Then let the user choose an action from the value
of
(move-marker root-marker (point-at-bol)))))
(unless agenda-p
(org-reveal))
- ;; Query about attaching email attachments.
- (org-with-point-at root-marker
- (map-y-or-n-p
- (lambda (a)
- (format "Attach %s to heading? "
- (file-name-nondirectory a)))
- (lambda (a) (org-attach-attach a nil 'mv))
- gnorb-gnus-capture-attachments
- '("file" "files" "attach")))
- (setq gnorb-gnus-capture-attachments nil)
+ ;; Query about attaching email attachments. No matter what
+ ;; happens, clear `gnorb-gnus-capture-attachments'.
+ (unwind-protect
+ (org-with-point-at root-marker
+ (map-y-or-n-p
+ (lambda (a)
+ (format "Attach %s to heading? "
+ (file-name-nondirectory a)))
+ (lambda (a) (org-attach-attach a nil 'mv))
+ gnorb-gnus-capture-attachments
+ '("file" "files" "attach")))
+ (setq gnorb-gnus-capture-attachments nil))
(cl-labels
((make-entry
(id)
- [elpa] externals/gnorb 1e071a0 252/449: Further refinements to link following, (continued)
- [elpa] externals/gnorb 1e071a0 252/449: Further refinements to link following, Stefan Monnier, 2020/11/27
- [elpa] externals/gnorb bfd8566 253/449: Be more careful about brackets on message-ids, Stefan Monnier, 2020/11/27
- [elpa] externals/gnorb 1b56250 254/449: Change wording of disassociation message, Stefan Monnier, 2020/11/27
- [elpa] externals/gnorb d4a4ccf 256/449: Better handling of non-existent Org headings, Stefan Monnier, 2020/11/27
- [elpa] externals/gnorb ad1538d 260/449: Autoload cookie for gnorb-tracking-initialize, Stefan Monnier, 2020/11/27
- [elpa] externals/gnorb 8db194a 259/449: Add TAGS to .gitignore, Stefan Monnier, 2020/11/27
- [elpa] externals/gnorb 14471db 262/449: Silence compiler warnings for unbound vars, Stefan Monnier, 2020/11/27
- [elpa] externals/gnorb 6aef624 265/449: Restore the layout after the restore process, Stefan Monnier, 2020/11/27
- [elpa] externals/gnorb c44a87b 266/449: Deletion of associations when composing messages, Stefan Monnier, 2020/11/27
- [elpa] externals/gnorb 7a43d8b 267/449: Bug in message disassociation, Stefan Monnier, 2020/11/27
- [elpa] externals/gnorb b82576c 268/449: Always clear attachments during triggering,
Stefan Monnier <=
- [elpa] externals/gnorb 15b35dc 269/449: Don't store a link to message we're replying to, Stefan Monnier, 2020/11/27
- [elpa] externals/gnorb 67ce358 270/449: Version 1.0.1, plus docs and NEWS, Stefan Monnier, 2020/11/27
- [elpa] externals/gnorb 806775c 272/449: Wrap save-excursion around more of gnorb-org-view, Stefan Monnier, 2020/11/27
- [elpa] externals/gnorb 982aee9 271/449: Adjust requires and autoloads, Stefan Monnier, 2020/11/27
- [elpa] externals/gnorb a55b0c0 273/449: Make gnorb-ids precious earlier in registry setup, Stefan Monnier, 2020/11/27
- [elpa] externals/gnorb 3877b2d 275/449: Still didn't have incoming-do-todo logic right, Stefan Monnier, 2020/11/27
- [elpa] externals/gnorb 94f6897 279/449: Don't use with-eval-after-load, Stefan Monnier, 2020/11/27
- [elpa] externals/gnorb 3801ad7 280/449: Check both gnus version and emacs version., Stefan Monnier, 2020/11/27
- [elpa] externals/gnorb 8c333ee 281/449: Merge pull request #20 from totherme/master, Stefan Monnier, 2020/11/27
- [elpa] externals/gnorb 8e705ea3 380/449: Sneakily add basic EBDB support to Gnorb, bump to 1.3.0, Stefan Monnier, 2020/11/27