emacs-elpa-diffs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[elpa] externals/gnorb 9f5466d 103/449: Edits courtesy of byte-compiler


From: Stefan Monnier
Subject: [elpa] externals/gnorb 9f5466d 103/449: Edits courtesy of byte-compiler warnings
Date: Fri, 27 Nov 2020 23:15:18 -0500 (EST)

branch: externals/gnorb
commit 9f5466d99e8c9a0aef8e5aeea8b3bb79962785c3
Author: Eric Abrahamsen <eric@ericabrahamsen.net>
Commit: Eric Abrahamsen <eric@ericabrahamsen.net>

    Edits courtesy of byte-compiler warnings
    
    lisp/gnorb-bbbdb.el
    lisp/gnorb-org.el
    lisp/nngnorb.el
    
    Mostly `called-interactively-p' with no arg, a few leftover
    nnnil-status-strings, and `insert-buffer' replaced with
    `insert-buffer-substring'.
---
 lisp/gnorb-bbdb.el | 2 +-
 lisp/gnorb-org.el  | 8 ++++----
 lisp/nngnorb.el    | 6 +++---
 3 files changed, 8 insertions(+), 8 deletions(-)

diff --git a/lisp/gnorb-bbdb.el b/lisp/gnorb-bbdb.el
index 27a87d7..6add38b 100644
--- a/lisp/gnorb-bbdb.el
+++ b/lisp/gnorb-bbdb.el
@@ -301,7 +301,7 @@ a prefix arg and \"*\", the prefix arg must come first."
 (defun gnorb-bbdb-cite-contact (rec)
   (interactive (list (gnorb-prompt-for-bbdb-record)))
   (let ((mail-string (bbdb-dwim-mail rec)))
-   (if (called-interactively-p)
+   (if (called-interactively-p 'any)
        (insert mail-string)
      mail-string)))
 
diff --git a/lisp/gnorb-org.el b/lisp/gnorb-org.el
index 6dee6e3..30029cf 100644
--- a/lisp/gnorb-org.el
+++ b/lisp/gnorb-org.el
@@ -128,7 +128,7 @@ future!"
         (link (concat "bbdb:" (org-link-escape name))))
     (org-store-link-props :type "bbdb" :name name
                          :link link :description name)
-    (if (called-interactively-p)
+    (if (called-interactively-p 'any)
        (insert (format "[[%s][%s]]" link name))
       link)))
 
@@ -349,7 +349,7 @@ headings."
     (message-goto-body)
     (insert"\n")
     (if (bufferp text)
-       (insert-buffer text)
+       (insert-buffer-substring text)
       (insert text)))
   ;; insert org ids, if any
   (when ids
@@ -621,7 +621,7 @@ search."
     (cond ((and
            (and (eq major-mode 'org-agenda-mode)
                 (eq org-agenda-type 'tags))
-           (or (called-interactively-p)
+           (or (called-interactively-p 'any)
                gnorb-org-agenda-popup-bbdb))
           (let ((todo-only nil)
                 (str (or str org-agenda-query-string))
@@ -669,7 +669,7 @@ search."
       (when (get-buffer-window bbdb-buffer-name)
        (quit-window nil
                     (get-buffer-window bbdb-buffer-name)))
-      (when (called-interactively-p)
+      (when (called-interactively-p 'any)
        (message "No relevant BBDB records")))))
 
 (add-hook 'org-agenda-finalize-hook 'gnorb-org-popup-bbdb)
diff --git a/lisp/nngnorb.el b/lisp/nngnorb.el
index 5b3126c..9505877 100644
--- a/lisp/nngnorb.el
+++ b/lisp/nngnorb.el
@@ -147,10 +147,10 @@ be scanned for gnus messages, and those messages 
displayed."
   t)
 
 (defun nngnorb-status-message (&optional server)
-  nnnil-status-string)
+  nngnorb-status-string)
 
 (defun nngnorb-request-article (article &optional group server to-buffer)
-  (setq nnnil-status-string "No such group")
+  (setq nngnorb-status-string "No such group")
   nil)
 
 (defun nngnorb-request-group (group &optional server fast info)
@@ -158,7 +158,7 @@ be scanned for gnus messages, and those messages displayed."
     (with-current-buffer nntp-server-buffer
       (erase-buffer)
       (insert "411 no such news group\n")))
-  (setq nnnil-status-string "No such group")
+  (setq nngnorb-status-string "No such group")
   nil)
 
 (defun nngnorb-close-group (group &optional server)



reply via email to

[Prev in Thread] Current Thread [Next in Thread]