emacs-elpa-diffs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[elpa] externals/gnorb 7950d3a 091/449: Comment and indentation changes


From: Stefan Monnier
Subject: [elpa] externals/gnorb 7950d3a 091/449: Comment and indentation changes only
Date: Fri, 27 Nov 2020 23:15:15 -0500 (EST)

branch: externals/gnorb
commit 7950d3a4b7c5a924546b6b1a18dd6ac09c113a54
Author: Eric Abrahamsen <eric@ericabrahamsen.net>
Commit: Eric Abrahamsen <eric@ericabrahamsen.net>

    Comment and indentation changes only
---
 lisp/gnorb-gnus.el | 19 ++++++++++++-------
 lisp/gnorb-org.el  |  1 +
 2 files changed, 13 insertions(+), 7 deletions(-)

diff --git a/lisp/gnorb-gnus.el b/lisp/gnorb-gnus.el
index 4521b88..c60e6b2 100644
--- a/lisp/gnorb-gnus.el
+++ b/lisp/gnorb-gnus.el
@@ -349,15 +349,19 @@ if any of the IDs there match the value of the
   (interactive "P")
   (if (not (memq major-mode '(gnus-summary-mode gnus-article-mode)))
       (error "Only works in gnus summary or article mode")
+    ;; We should only store a link if it's not already at the head of
+    ;; `org-stored-links'. There's some duplicate storage, at
+    ;; present. Take a look at calling it non-interactively.
     (call-interactively 'org-store-link)
     (let* ((org-refile-targets gnorb-gnus-trigger-refile-targets)
-          (ref-msg-ids (with-current-buffer gnus-original-article-buffer
-                         (nnheader-narrow-to-headers)
-                         (let ((all-refs
-                                (concat (message-fetch-field "in-reply-to")
-                                        (message-fetch-field "references"))))
-                           (when all-refs
-                             (gnus-extract-message-id-from-in-reply-to 
all-refs)))))
+          (ref-msg-ids
+           (with-current-buffer gnus-original-article-buffer
+             (nnheader-narrow-to-headers)
+             (let ((all-refs
+                    (concat (message-fetch-field "in-reply-to")
+                            (message-fetch-field "references"))))
+               (when all-refs
+                 (gnus-extract-message-id-from-in-reply-to all-refs)))))
           (offer-heading
            (when (and (not id) ref-msg-ids)
              ;; for now we're basically ignoring the fact that
@@ -366,6 +370,7 @@ if any of the IDs there match the value of the
              (car (gnorb-org-find-visit-candidates
                    (list ref-msg-ids)))))
           targ)
+      ;; offer to attach attachments!
       (if id
          (gnorb-trigger-todo-action arg id)
        (if (and offer-heading
diff --git a/lisp/gnorb-org.el b/lisp/gnorb-org.el
index 934642a..890d185 100644
--- a/lisp/gnorb-org.el
+++ b/lisp/gnorb-org.el
@@ -36,6 +36,7 @@
 this library may, after completion, call org-(agenda-)todo on
 relevant headings with these keywords. Set to nil to call
 org-todo regardless of TODO type."
+  ;; allowable values should also include 'todo and 'not-done
   :group 'gnorb-org
   :type 'list)
 



reply via email to

[Prev in Thread] Current Thread [Next in Thread]