[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[elpa] externals/gnorb 048bbd9 040/449: Many pointless defstructs
From: |
Stefan Monnier |
Subject: |
[elpa] externals/gnorb 048bbd9 040/449: Many pointless defstructs |
Date: |
Fri, 27 Nov 2020 23:15:04 -0500 (EST) |
branch: externals/gnorb
commit 048bbd90442ae4ff915f584c4354fac1544fb6b8
Author: Eric Abrahamsen <eric@ericabrahamsen.net>
Commit: Eric Abrahamsen <eric@ericabrahamsen.net>
Many pointless defstructs
No reason they shouldn't be defuns, this is not even remotely
performance critical.
---
lisp/gnorb-org.el | 8 +++++---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/lisp/gnorb-org.el b/lisp/gnorb-org.el
index dcaa40e..9971121 100644
--- a/lisp/gnorb-org.el
+++ b/lisp/gnorb-org.el
@@ -62,7 +62,7 @@ point."
(when (member todo gnorb-org-mail-todos)
(call-interactively 'org-agenda-todo))))
-(defsubst gnorb-org-extract-mail-stuff ()
+(defun gnorb-org-extract-mail-stuff ()
(let (message mails)
(while (re-search-forward org-any-link-re (line-end-position) t)
(let ((addr (or (match-string-no-properties 2)
@@ -81,7 +81,7 @@ point."
(push mail mails))))))))
(list message mails)))
-(defsubst gnorb-org-setup-message (message mails)
+(defun gnorb-org-setup-message (message mails)
(if (not message)
(compose-mail (mapconcat 'identity mails ", ")
nil nil nil nil nil nil
@@ -97,7 +97,9 @@ point."
'gnorb-org-restore-after-send t)
(message-goto-body)))
-(defsubst gnorb-org-attachment-list ()
+(defun gnorb-org-attachment-list ()
+ "Get a list of files (absolute filenames) attached to the
+current heading."
(when (featurep 'org-attach)
(let* ((attach-dir (org-attach-dir t))
(files
- [elpa] externals/gnorb da7cf10 018/449: gnorb-utils.el: Require mailcap, and parse, (continued)
- [elpa] externals/gnorb da7cf10 018/449: gnorb-utils.el: Require mailcap, and parse, Stefan Monnier, 2020/11/27
- [elpa] externals/gnorb 5264b3c 021/449: README.org: Document gnorb-org-email-subtree, Stefan Monnier, 2020/11/27
- [elpa] externals/gnorb 82bb9db 023/449: README.org: Add keybindings to gnus mime commands., Stefan Monnier, 2020/11/27
- [elpa] externals/gnorb 534b2bf 024/449: gnorb-org.el: new option gnorb-org-mail-todos, Stefan Monnier, 2020/11/27
- [elpa] externals/gnorb 9c5d04a 027/449: README.org: More explanation about the mail stuff., Stefan Monnier, 2020/11/27
- [elpa] externals/gnorb e53d908 028/449: gnorb-gnus.el: bugfix in gnorb-gnus-collect-all-attachments, Stefan Monnier, 2020/11/27
- [elpa] externals/gnorb 4f16002 029/449: gnorb-org.el: Fix attaching attachments to outgoing messages., Stefan Monnier, 2020/11/27
- [elpa] externals/gnorb ed9825e 034/449: Use map-y-or-n-p for attachment actions, Stefan Monnier, 2020/11/27
- [elpa] externals/gnorb af8f375 038/449: Various README.org tweaks, Stefan Monnier, 2020/11/27
- [elpa] externals/gnorb 27a91f6 039/449: Open link from string correctly, Stefan Monnier, 2020/11/27
- [elpa] externals/gnorb 048bbd9 040/449: Many pointless defstructs,
Stefan Monnier <=
- [elpa] externals/gnorb e183272 055/449: Think about merging mail commands, Stefan Monnier, 2020/11/27
- [elpa] externals/gnorb a680c42 058/449: Moving the mail header stuff to a different file, Stefan Monnier, 2020/11/27
- [elpa] externals/gnorb 8519593 060/449: Rework Org BBDB popups, Stefan Monnier, 2020/11/27
- [elpa] externals/gnorb 97c0d41 045/449: Place point somewhere useful after setting up message, Stefan Monnier, 2020/11/27
- [elpa] externals/gnorb c9e4dfb 056/449: Limit to TODOs only in BBDB tag searches, Stefan Monnier, 2020/11/27
- [elpa] externals/gnorb 210851e 065/449: That's not broken anymore., Stefan Monnier, 2020/11/27
- [elpa] externals/gnorb 72a98bd 020/449: README.org: Document new capture attachment thingy., Stefan Monnier, 2020/11/27
- [elpa] externals/gnorb e2617e0 030/449: gnorb-org.el: That's not how return-actions look, Stefan Monnier, 2020/11/27
- [elpa] externals/gnorb c5e3459 033/449: README.org: Fixed keybinding for mime map, Stefan Monnier, 2020/11/27
- [elpa] externals/gnorb 0e75c71 035/449: Note future mail-search-from-agenda function, Stefan Monnier, 2020/11/27