[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[elpa] externals/gnorb 048bbd9 040/449: Many pointless defstructs

From: Stefan Monnier
Subject: [elpa] externals/gnorb 048bbd9 040/449: Many pointless defstructs
Date: Fri, 27 Nov 2020 23:15:04 -0500 (EST)

branch: externals/gnorb
commit 048bbd90442ae4ff915f584c4354fac1544fb6b8
Author: Eric Abrahamsen <eric@ericabrahamsen.net>
Commit: Eric Abrahamsen <eric@ericabrahamsen.net>

    Many pointless defstructs
    No reason they shouldn't be defuns, this is not even remotely
    performance critical.
 lisp/gnorb-org.el | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/lisp/gnorb-org.el b/lisp/gnorb-org.el
index dcaa40e..9971121 100644
--- a/lisp/gnorb-org.el
+++ b/lisp/gnorb-org.el
@@ -62,7 +62,7 @@ point."
     (when (member todo gnorb-org-mail-todos)
      (call-interactively 'org-agenda-todo))))
-(defsubst gnorb-org-extract-mail-stuff ()
+(defun gnorb-org-extract-mail-stuff ()
   (let (message mails)
     (while (re-search-forward org-any-link-re (line-end-position) t)
       (let ((addr (or (match-string-no-properties 2)
@@ -81,7 +81,7 @@ point."
                (push mail mails))))))))
     (list message mails)))
-(defsubst gnorb-org-setup-message (message mails)
+(defun gnorb-org-setup-message (message mails)
   (if (not message)
       (compose-mail (mapconcat 'identity mails ", ")
                    nil nil nil nil nil nil
@@ -97,7 +97,9 @@ point."
                 'gnorb-org-restore-after-send t)
-(defsubst gnorb-org-attachment-list ()
+(defun gnorb-org-attachment-list ()
+  "Get a list of files (absolute filenames) attached to the
+current heading."
   (when (featurep 'org-attach)
     (let* ((attach-dir (org-attach-dir t))

reply via email to

[Prev in Thread] Current Thread [Next in Thread]