[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[elpa] externals/ivy-posframe 27e3cec 176/195: Try to fix Minibuffer is
From: |
Feng Shu |
Subject: |
[elpa] externals/ivy-posframe 27e3cec 176/195: Try to fix Minibuffer is hiding always #66 |
Date: |
Sat, 3 Oct 2020 07:12:08 -0400 (EDT) |
branch: externals/ivy-posframe
commit 27e3cec8fcc47522c62b585cef87f068bb1c38a3
Author: Feng Shu <tumashu@163.com>
Commit: Feng Shu <tumashu@163.com>
Try to fix Minibuffer is hiding always #66
---
ivy-posframe.el | 18 ++++++++----------
1 file changed, 8 insertions(+), 10 deletions(-)
diff --git a/ivy-posframe.el b/ivy-posframe.el
index 2c2feb6..76b8b00 100644
--- a/ivy-posframe.el
+++ b/ivy-posframe.el
@@ -251,6 +251,7 @@ This variable is useful for `ivy-posframe-read-action' .")
;; Fix warn
(defvar emacs-basic-display)
+(defvar ivy--display-function)
(defun ivy-posframe--display (str &optional poshandler)
"Show STR in ivy's posframe with POSHANDLER."
@@ -310,15 +311,7 @@ This variable is useful for `ivy-posframe-read-action' .")
(defun ivy-posframe-cleanup ()
"Cleanup ivy's posframe."
(when (posframe-workable-p)
- (posframe-hide ivy-posframe-buffer))
- ;; The below cleanup is required or not? need more test!
- (when ivy-posframe-hide-minibuffer
- (with-current-buffer (window-buffer (active-minibuffer-window))
- (let ((overlays (overlays-at (point-min))))
- (dolist (overlay overlays)
- (when (and (overlayp overlay)
- (overlay-get overlay 'ivy-posframe))
- (delete-overlay overlay)))))))
+ (posframe-hide ivy-posframe-buffer)))
(defun ivy-posframe-dispatching-done ()
"Select one of the available actions and call `ivy-done'."
@@ -506,7 +499,12 @@ The return value is undefined.
"Advice function of FN, `ivy--minibuffer-setup' with ARGS."
(let ((ivy-fixed-height-minibuffer nil))
(apply fn args))
- (when ivy-posframe-hide-minibuffer
+ (when (and ivy-posframe-hide-minibuffer
+ ;; if display-function is not a ivy-posframe style
display-function.
+ ;; do not hide minibuffer.
+ ;; The hypothesis is that all ivy-posframe style display functions
+ ;; have ivy-posframe as name prefix, need improve!
+ (string-match-p "^ivy-posframe" (symbol-name
ivy--display-function)))
(let ((ov (make-overlay (point-min) (point-max) nil nil t)))
(overlay-put ov 'window (selected-window))
(overlay-put ov 'ivy-posframe t)
- [elpa] externals/ivy-posframe 8902638 100/195: define ivy-posframe-adbice-alist, (continued)
- [elpa] externals/ivy-posframe 8902638 100/195: define ivy-posframe-adbice-alist, Feng Shu, 2020/10/03
- [elpa] externals/ivy-posframe 212eaa1 138/195: indent ivy-posframe-mode, Feng Shu, 2020/10/03
- [elpa] externals/ivy-posframe b934152 125/195: move variables section above advice section, Feng Shu, 2020/10/03
- [elpa] externals/ivy-posframe 9e0c6da 118/195: generate readme, Feng Shu, 2020/10/03
- [elpa] externals/ivy-posframe 02a357d 104/195: define ivy-posframe-mode instead of ivy-posframe-enable, Feng Shu, 2020/10/03
- [elpa] externals/ivy-posframe aea9074 122/195: add ivy-posframe--read advice, Feng Shu, 2020/10/03
- [elpa] externals/ivy-posframe 76350e7 146/195: Update README, Feng Shu, 2020/10/03
- [elpa] externals/ivy-posframe c4091c3 120/195: remove unnesessary code, Feng Shu, 2020/10/03
- [elpa] externals/ivy-posframe e76a15d 162/195: Merge pull request #53 from gagbo/patch-1, Feng Shu, 2020/10/03
- [elpa] externals/ivy-posframe 83657be 114/195: add display-functions-alist to restore ivy variable, Feng Shu, 2020/10/03
- [elpa] externals/ivy-posframe 27e3cec 176/195: Try to fix Minibuffer is hiding always #66,
Feng Shu <=
- [elpa] externals/ivy-posframe c43acf3 132/195: alias ivy-posframe-enable as ivy-posframe-mode, Feng Shu, 2020/10/03
- [elpa] externals/ivy-posframe 3c3740e 142/195: Add ivy-posframe-lighter, Feng Shu, 2020/10/03
- [elpa] externals/ivy-posframe 6d697ff 190/195: Try to fix: Posframe max-width? #82, Feng Shu, 2020/10/03
- [elpa] externals/ivy-posframe ae9bafe 191/195: (defvar avy-pre-action), Feng Shu, 2020/10/03
- [elpa] externals/ivy-posframe 4242977 079/195: Remove #' (function quote) of `lambda`, Feng Shu, 2020/10/03
- [elpa] externals/ivy-posframe 0a870c1 080/195: Remove top-level ivy-posframe setup function executing, Feng Shu, 2020/10/03
- [elpa] externals/ivy-posframe 38aff80 084/195: Add ivy-posframe-demo, Feng Shu, 2020/10/03
- [elpa] externals/ivy-posframe 13180ce 087/195: Merge pull request #35 from conao3/fix-minibuffer-issue, Feng Shu, 2020/10/03
- [elpa] externals/ivy-posframe ba1bc4f 092/195: Update prompt in dynamic collections, Feng Shu, 2020/10/03
- [elpa] externals/ivy-posframe 233a3ec 070/195: Fix Strange behaviour #25, Feng Shu, 2020/10/03