emacs-elpa-diffs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[elpa] externals/modus-operandi-theme 45cc0a3 06/99: No more need for ':


From: Stefan Monnier
Subject: [elpa] externals/modus-operandi-theme 45cc0a3 06/99: No more need for ':extend t' in HELM faces
Date: Fri, 31 Jul 2020 09:25:16 -0400 (EDT)

branch: externals/modus-operandi-theme
commit 45cc0a3387dac699a15293298a08a731b8e08a96
Author: Protesilaos Stavrou <info@protesilaos.com>
Commit: Protesilaos Stavrou <info@protesilaos.com>

    No more need for ':extend t' in HELM faces
    
    A recent commit in Helm adds the necessary ':extend' attribute to the
    relevant faces (only relevant for >= Emacs27).  See
    
https://github.com/emacs-helm/helm/commit/d19592f593755a0d3daf09b4312daa0731d01dd6
    
    This attribute is always retained regardless of the active theme, unless
    it is explicitly overridden.  Meaning that support for it on the theme
    side is no longer required.
    
    Thanks to Manuel Uberti for bringing this issue to my attention:
    https://github.com/emacs-helm/helm/issues/2213
---
 modus-operandi-theme.el | 9 +++------
 modus-vivendi-theme.el  | 9 +++------
 2 files changed, 6 insertions(+), 12 deletions(-)

diff --git a/modus-operandi-theme.el b/modus-operandi-theme.el
index eccfad2..c46f357 100644
--- a/modus-operandi-theme.el
+++ b/modus-operandi-theme.el
@@ -1965,12 +1965,9 @@ Also bind `class' to ((class color) (min-colors 89))."
    `(helm-mode-prefix ((,class :inherit modus-theme-intense-magenta)))
    `(helm-non-file-buffer ((,class :foreground ,fg-alt)))
    `(helm-prefarg ((,class :foreground ,red-active)))
-   `(helm-resume-need-update ((,class ,@(and (>= emacs-major-version 27) 
'(:extend t))
-                                      :inherit modus-theme-refine-magenta)))
-   `(helm-selection ((,class ,@(and (>= emacs-major-version 27) '(:extend t))
-                             :inherit modus-theme-refine-blue :weight bold)))
-   `(helm-selection-line ((,class ,@(and (>= emacs-major-version 27) '(:extend 
t))
-                                  :inherit modus-theme-special-cold)))
+   `(helm-resume-need-update ((,class :inherit modus-theme-refine-magenta)))
+   `(helm-selection ((,class :inherit modus-theme-refine-blue :weight bold)))
+   `(helm-selection-line ((,class :inherit modus-theme-special-cold)))
    `(helm-separator ((,class :foreground ,fg-special-mild)))
    `(helm-time-zone-current ((,class :foreground ,green)))
    `(helm-time-zone-home ((,class :foreground ,magenta)))
diff --git a/modus-vivendi-theme.el b/modus-vivendi-theme.el
index 208b1bd..cb1860b 100644
--- a/modus-vivendi-theme.el
+++ b/modus-vivendi-theme.el
@@ -1965,12 +1965,9 @@ Also bind `class' to ((class color) (min-colors 89))."
    `(helm-mode-prefix ((,class :inherit modus-theme-intense-magenta)))
    `(helm-non-file-buffer ((,class :foreground ,fg-alt)))
    `(helm-prefarg ((,class :foreground ,red-active)))
-   `(helm-resume-need-update ((,class ,@(and (>= emacs-major-version 27) 
'(:extend t))
-                                      :inherit modus-theme-refine-magenta)))
-   `(helm-selection ((,class ,@(and (>= emacs-major-version 27) '(:extend t))
-                             :inherit modus-theme-refine-blue :weight bold)))
-   `(helm-selection-line ((,class ,@(and (>= emacs-major-version 27) '(:extend 
t))
-                                  :inherit modus-theme-special-cold)))
+   `(helm-resume-need-update ((,class :inherit modus-theme-refine-magenta)))
+   `(helm-selection ((,class :inherit modus-theme-refine-blue :weight bold)))
+   `(helm-selection-line ((,class :inherit modus-theme-special-cold)))
    `(helm-separator ((,class :foreground ,fg-special-mild)))
    `(helm-time-zone-current ((,class :foreground ,green)))
    `(helm-time-zone-home ((,class :foreground ,magenta)))



reply via email to

[Prev in Thread] Current Thread [Next in Thread]