emacs-elpa-diffs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[elpa] externals/modus-operandi-theme f76c36a 13/54: Major review of col


From: Stefan Monnier
Subject: [elpa] externals/modus-operandi-theme f76c36a 13/54: Major review of colours for tabs. Tweak faces.
Date: Thu, 4 Jun 2020 08:20:11 -0400 (EDT)

branch: externals/modus-operandi-theme
commit f76c36a071c32032b135b59d6878e63fd63ed802
Author: Protesilaos Stavrou <info@protesilaos.com>
Commit: Protesilaos Stavrou <info@protesilaos.com>

    Major review of colours for tabs. Tweak faces.
    
    The palette intended for tabbed interfaces has been designed anew.  It
    was essential to make these colours work in a broad range of scenaria,
    such as by accounting for their style relative to a buffer's header
    line or their foreground compared to that of a buffer.
    
    The face groups for tab-bar and tab-line (Emacs 27) have been reviewed
    to make better use of the new colours.  The centaur-tabs faces received
    some minor tweaks as well (in the interest of consistency).
    
    The present commit incorporates the feedback I received in issue 41:
    https://gitlab.com/protesilaos/modus-themes/-/issues/41
---
 modus-operandi-theme.el | 34 +++++++++++++++++-----------------
 modus-vivendi-theme.el  | 34 +++++++++++++++++-----------------
 2 files changed, 34 insertions(+), 34 deletions(-)

diff --git a/modus-operandi-theme.el b/modus-operandi-theme.el
index 99b987e..97e597a 100644
--- a/modus-operandi-theme.el
+++ b/modus-operandi-theme.el
@@ -643,9 +643,10 @@ AMOUNT is a customisation option."
     ("bg-paren-match" . "#efcabf")
     ("bg-region" . "#bcbcbc")
 
-    ("bg-tab-active" . "#ababab")
-    ("bg-tab-inactive" . "#dadada")
-    ("fg-tab-active" . "#000077")
+    ("bg-tab-bar" . "#d5d5d5")
+    ("bg-tab-active" . "#f6f6f6")
+    ("bg-tab-inactive" . "#bdbdbd")
+    ("fg-tab-active" . "#30169e")
 
     ("fg-escape-char-construct" . "#8b1030")
     ("fg-escape-char-backslash" . "#644f00")
@@ -993,13 +994,13 @@ Also bind `class' to ((class color) (min-colors 89))."
    `(cfw:face-toolbar-button-on ((,class (:background ,bg-main :foreground 
,blue-intense :weight bold))))
    ;;;; centaur-tabs
    `(centaur-tabs-active-bar-face ((,class (:background ,fg-tab-active))))
-   `(centaur-tabs-close-mouse-face ((,class (:underline t))))
+   `(centaur-tabs-close-mouse-face ((,class (:foreground ,red-active :weight 
bold :underline t))))
    `(centaur-tabs-close-selected ((,class (:inherit centaur-tabs-selected))))
    `(centaur-tabs-close-unselected ((,class (:inherit 
centaur-tabs-unselected))))
    `(centaur-tabs-modified-marker-selected ((,class (:inherit 
centaur-tabs-selected))))
    `(centaur-tabs-modified-marker-unselected ((,class (:inherit 
centaur-tabs-unselected))))
    `(centaur-tabs-default ((,class (:background ,bg-main :foreground 
,bg-main))))
-   `(centaur-tabs-selected ((,class (:background ,bg-tab-active :foreground 
,fg-main))))
+   `(centaur-tabs-selected ((,class (:background ,bg-tab-active :foreground 
,fg-main :weight bold))))
    `(centaur-tabs-selected-modified ((,class (:background ,bg-tab-active 
:foreground ,fg-main :slant italic))))
    `(centaur-tabs-unselected ((,class (:background ,bg-tab-inactive 
:foreground ,fg-dim))))
    `(centaur-tabs-unselected-modified ((,class (:background ,bg-tab-inactive 
:foreground ,fg-dim :slant italic))))
@@ -3290,20 +3291,19 @@ Also bind `class' to ((class color) (min-colors 89))."
      (custom-theme-set-faces
       'modus-operandi
       ;;;; tab-bar-mode
-      `(tab-bar ((,class (:background ,bg-alt :foreground ,fg-alt))))
-      `(tab-bar-tab ((,class (:box (:line-width 1 :color 
,fg-window-divider-inner)
-                                   :background ,bg-tab-active :foreground 
,fg-main))))
-      `(tab-bar-tab-inactive ((,class (:box (:line-width 1 :color 
,bg-tab-active)
+      `(tab-bar ((,class (:background ,bg-tab-bar :foreground ,fg-main))))
+      `(tab-bar-tab ((,class (:box (:line-width 2 :color ,bg-tab-active)
+                                   :background ,bg-tab-active :foreground 
,fg-main :weight bold))))
+      `(tab-bar-tab-inactive ((,class (:box (:line-width 2 :color 
,bg-tab-inactive)
                                             :background ,bg-tab-inactive 
:foreground ,fg-dim))))
       ;;;; tab-line-mode
-      `(tab-line ((,class (:height 0.95 :background ,bg-active :foreground 
,fg-active))))
-      `(tab-line-close-highlight ((,class (:foreground ,red-active))))
-      `(tab-line-highlight ((,class (:background ,bg-tab-active :foreground 
,fg-main))))
-      `(tab-line-tab ((,class (:box (:line-width 1 :color 
,fg-window-divider-inner)
-                                    :background ,bg-tab-active :foreground 
,fg-main))))
-      `(tab-line-tab-current ((,class (:box (:line-width 1 :color 
,fg-window-divider-inner)
-                                            :background ,bg-tab-active 
:foreground ,fg-main))))
-      `(tab-line-tab-inactive ((,class (:box (:line-width 1 :color 
,bg-tab-active)
+      `(tab-line ((,class (:height 0.95 :background ,bg-tab-bar :foreground 
,fg-main))))
+      `(tab-line-close-highlight ((,class (:foreground ,red))))
+      `(tab-line-highlight ((,class (:background ,blue-subtle-bg :foreground 
,fg-dim))))
+      `(tab-line-tab ((,class (:box (:line-width 2 :color ,bg-tab-active)
+                                    :background ,bg-tab-active :foreground 
,fg-main :weight bold))))
+      `(tab-line-tab-current ((,class (:inherit tab-line-tab))))
+      `(tab-line-tab-inactive ((,class (:box (:line-width 2 :color 
,bg-tab-inactive)
                                              :background ,bg-tab-inactive 
:foreground ,fg-dim))))))
    ;;; Theme Variables
    (custom-theme-set-variables
diff --git a/modus-vivendi-theme.el b/modus-vivendi-theme.el
index 9d00f91..4aeb119 100644
--- a/modus-vivendi-theme.el
+++ b/modus-vivendi-theme.el
@@ -643,9 +643,10 @@ AMOUNT is a customisation option."
     ("bg-paren-match" . "#6e3a50")
     ("bg-region" . "#3c3c3c")
 
-    ("bg-tab-active" . "#484848")
-    ("bg-tab-inactive" . "#2f2f2f")
-    ("fg-tab-active" . "#99efff")
+    ("bg-tab-bar" . "#2c2c2c")
+    ("bg-tab-active" . "#0e0e0e")
+    ("bg-tab-inactive" . "#3d3d3d")
+    ("fg-tab-active" . "#5ac3cf")
 
     ("fg-escape-char-construct" . "#e7a59a")
     ("fg-escape-char-backslash" . "#abab00")
@@ -993,13 +994,13 @@ Also bind `class' to ((class color) (min-colors 89))."
    `(cfw:face-toolbar-button-on ((,class (:background ,bg-main :foreground 
,blue-intense :weight bold))))
    ;;;; centaur-tabs
    `(centaur-tabs-active-bar-face ((,class (:background ,fg-tab-active))))
-   `(centaur-tabs-close-mouse-face ((,class (:underline t))))
+   `(centaur-tabs-close-mouse-face ((,class (:foreground ,red-active :weight 
bold :underline t))))
    `(centaur-tabs-close-selected ((,class (:inherit centaur-tabs-selected))))
    `(centaur-tabs-close-unselected ((,class (:inherit 
centaur-tabs-unselected))))
    `(centaur-tabs-modified-marker-selected ((,class (:inherit 
centaur-tabs-selected))))
    `(centaur-tabs-modified-marker-unselected ((,class (:inherit 
centaur-tabs-unselected))))
    `(centaur-tabs-default ((,class (:background ,bg-main :foreground 
,bg-main))))
-   `(centaur-tabs-selected ((,class (:background ,bg-tab-active :foreground 
,fg-main))))
+   `(centaur-tabs-selected ((,class (:background ,bg-tab-active :foreground 
,fg-main :weight bold))))
    `(centaur-tabs-selected-modified ((,class (:background ,bg-tab-active 
:foreground ,fg-main :slant italic))))
    `(centaur-tabs-unselected ((,class (:background ,bg-tab-inactive 
:foreground ,fg-dim))))
    `(centaur-tabs-unselected-modified ((,class (:background ,bg-tab-inactive 
:foreground ,fg-dim :slant italic))))
@@ -3290,20 +3291,19 @@ Also bind `class' to ((class color) (min-colors 89))."
      (custom-theme-set-faces
       'modus-vivendi
       ;;;; tab-bar-mode
-      `(tab-bar ((,class (:background ,bg-alt :foreground ,fg-alt))))
-      `(tab-bar-tab ((,class (:box (:line-width 1 :color 
,fg-window-divider-inner)
-                                   :background ,bg-tab-active :foreground 
,fg-main))))
-      `(tab-bar-tab-inactive ((,class (:box (:line-width 1 :color 
,bg-tab-active)
+      `(tab-bar ((,class (:background ,bg-tab-bar :foreground ,fg-main))))
+      `(tab-bar-tab ((,class (:box (:line-width 2 :color ,bg-tab-active)
+                                   :background ,bg-tab-active :foreground 
,fg-main :weight bold))))
+      `(tab-bar-tab-inactive ((,class (:box (:line-width 2 :color 
,bg-tab-inactive)
                                             :background ,bg-tab-inactive 
:foreground ,fg-dim))))
       ;;;; tab-line-mode
-      `(tab-line ((,class (:height 0.95 :background ,bg-active :foreground 
,fg-active))))
-      `(tab-line-close-highlight ((,class (:foreground ,red-active))))
-      `(tab-line-highlight ((,class (:background ,bg-tab-active :foreground 
,fg-main))))
-      `(tab-line-tab ((,class (:box (:line-width 1 :color 
,fg-window-divider-inner)
-                                    :background ,bg-tab-active :foreground 
,fg-main))))
-      `(tab-line-tab-current ((,class (:box (:line-width 1 :color 
,fg-window-divider-inner)
-                                            :background ,bg-tab-active 
:foreground ,fg-main))))
-      `(tab-line-tab-inactive ((,class (:box (:line-width 1 :color 
,bg-tab-active)
+      `(tab-line ((,class (:height 0.95 :background ,bg-tab-bar :foreground 
,fg-main))))
+      `(tab-line-close-highlight ((,class (:foreground ,red))))
+      `(tab-line-highlight ((,class (:background ,blue-subtle-bg :foreground 
,fg-dim))))
+      `(tab-line-tab ((,class (:box (:line-width 2 :color ,bg-tab-active)
+                                    :background ,bg-tab-active :foreground 
,fg-main :weight bold))))
+      `(tab-line-tab-current ((,class (:inherit tab-line-tab))))
+      `(tab-line-tab-inactive ((,class (:box (:line-width 2 :color 
,bg-tab-inactive)
                                              :background ,bg-tab-inactive 
:foreground ,fg-dim))))))
    ;;; Theme Variables
    (custom-theme-set-variables



reply via email to

[Prev in Thread] Current Thread [Next in Thread]