[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[elpa] externals/scanner 72ecf43 56/56: minor clean-ups
From: |
Stefan Monnier |
Subject: |
[elpa] externals/scanner 72ecf43 56/56: minor clean-ups |
Date: |
Fri, 10 Apr 2020 13:56:08 -0400 (EDT) |
branch: externals/scanner
commit 72ecf43d95ae8cc36bf10f9dba73cfac2d1d07f5
Author: Raffael Stocker <address@hidden>
Commit: Raffael Stocker <address@hidden>
minor clean-ups
---
Readme.org | 2 ++
scanner.el | 14 ++++++++------
2 files changed, 10 insertions(+), 6 deletions(-)
diff --git a/Readme.org b/Readme.org
index 73c3a6d..e23676e 100644
--- a/Readme.org
+++ b/Readme.org
@@ -27,6 +27,8 @@
file name or falls back to the configured default, see
~scanner-image-format~. The prefix argument works as in document mode.
+ The scanning commands are also available in the Tools->Scanner menu.
+
For both images and documents, you can customize the scan mode (e.g. "Color"
or "Gray") if your scanning device supports it.
diff --git a/scanner.el b/scanner.el
index e5e9dbd..99502f0 100644
--- a/scanner.el
+++ b/scanner.el
@@ -1,4 +1,4 @@
-;;; scanner.el --- Scan documents and images -*- lexical-binding: t -*-
+;;; scanner.el --- Scan documents and images -*- lexical-binding: t; -*-
;; Copyright (C) 2020 Raffael Stocker
@@ -54,6 +54,8 @@
;; file name or falls back to the configured default, see
;; ‘scanner-image-format’. The prefix argument works as in document mode.
;;
+;; The scanning commands are also available in the Tools->Scanner menu.
+;;
;; For both images and documents, you can customize the scan mode
;; (e.g. "Color" or "Gray") if your scanning device supports it.
;;
@@ -66,7 +68,7 @@
(require 'dash)
(require 'cl-lib)
-(require 'subr-x)
+(eval-when-compile (require 'subr-x))
(require 'menu-bar)
@@ -283,7 +285,7 @@ name, the device type, and the vendor and model names."
;; attempt to filter out any spurious error output or other non-relevant
;; stuff
(setq scanner--detected-devices
- (--filter (eql 3 (length it))
+ (--filter (= 3 (length it))
(mapcar (lambda (x) (split-string x "|")) scanners)))))
(defun scanner--scanimage-args (outfile scan-type switches img-fmt)
@@ -332,7 +334,6 @@ extensions depending on the selected output options, see
scanner-tesseract-switches
scanner-tesseract-outputs)))
-;; FIXME write log output
(defun scanner--ensure-init ()
"Ensure that scanning device is initialized.
If no scanning device has been configured or the configured
@@ -351,9 +352,9 @@ available options."
nil nil nil "-n"
"-d" scanner-device-name)))
(let ((num-devices (length (scanner--detect-devices))))
- (cond ((eql 0 num-devices)
+ (cond ((= 0 num-devices)
(user-error "No scanning device was found"))
- ((eql 1 num-devices)
+ ((= 1 num-devices)
(setq scanner-device-name (caar scanner--detected-devices)))
(t (call-interactively #'scanner-select-device)))))
(with-temp-buffer
@@ -375,6 +376,7 @@ MSG is a format string, with ARGS passed to ‘format’."
(goto-char (point-max))
(insert (apply #'format msg args) "\n")))
+;; FIXME use special mode in the log buffer
(defun scanner--log-buffer ()
"Return scanner log buffer or create it."
(get-buffer-create "*Scanner*"))
- [elpa] externals/scanner bc9b16c 27/56: correct a comment and whitespace, (continued)
- [elpa] externals/scanner bc9b16c 27/56: correct a comment and whitespace, Stefan Monnier, 2020/04/10
- [elpa] externals/scanner 930448a 24/56: improve docstrings, Stefan Monnier, 2020/04/10
- [elpa] externals/scanner 8219c0e 29/56: add ‘scanner-select-device’ to the menu, Stefan Monnier, 2020/04/10
- [elpa] externals/scanner 45a3e1c 34/56: use finer argument tests in language and output selection, Stefan Monnier, 2020/04/10
- [elpa] externals/scanner 52bb203 32/56: correct the license notice (GNU Emacs -> This program), Stefan Monnier, 2020/04/10
- [elpa] externals/scanner 6594fcb 17/56: put image scan sentinel back into scanner-scan-image, Stefan Monnier, 2020/04/10
- [elpa] externals/scanner cce46fd 01/56: initial commit, Stefan Monnier, 2020/04/10
- [elpa] externals/scanner 64f5514 37/56: update commentary and Readme.org, Stefan Monnier, 2020/04/10
- [elpa] externals/scanner eab3aea 40/56: cleanup scanner--ensure-init, Stefan Monnier, 2020/04/10
- [elpa] externals/scanner 1229f38 46/56: add ‘check’ to phony targets, Stefan Monnier, 2020/04/10
- [elpa] externals/scanner 72ecf43 56/56: minor clean-ups,
Stefan Monnier <=
- [elpa] externals/scanner c439a01 07/56: add scanner--ensure-init, Stefan Monnier, 2020/04/10
- [elpa] externals/scanner 9779064 13/56: remove an old FIXME, Stefan Monnier, 2020/04/10
- [elpa] externals/scanner 0b0fecf 19/56: make a basic Readme from the commentary, Stefan Monnier, 2020/04/10
- [elpa] externals/scanner 00ab593 23/56: rephrase commentary in active voice, Stefan Monnier, 2020/04/10
- [elpa] externals/scanner fdfdb62 33/56: add tesseract outputs selection command, Stefan Monnier, 2020/04/10
- [elpa] externals/scanner d011e65 36/56: implement multi-image scan, Stefan Monnier, 2020/04/10
- [elpa] externals/scanner e17e2fa 41/56: add section headings, Stefan Monnier, 2020/04/10
- [elpa] externals/scanner 6537d71 47/56: add image size customization and update tests, Stefan Monnier, 2020/04/10
- [elpa] externals/scanner bfaae5a 20/56: ignore PDF and text files, Stefan Monnier, 2020/04/10
- [elpa] externals/scanner b058e2f 26/56: autoload the menu, Stefan Monnier, 2020/04/10