[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[elpa] master 39f5c24 187/399: ivy-test.el: Use :expected-result
From: |
Oleh Krehel |
Subject: |
[elpa] master 39f5c24 187/399: ivy-test.el: Use :expected-result |
Date: |
Sat, 20 Jul 2019 14:57:20 -0400 (EDT) |
branch: master
commit 39f5c2407e199b4b6a9a7d7b89a8253c12a5edba
Author: Basil L. Contovounesios <address@hidden>
Commit: Oleh Krehel <address@hidden>
ivy-test.el: Use :expected-result
(counsel-find-file-with-dollars, counsel-find-file-with-dotfiles):
Use :expected-result in place of skip-unless, which was
unfortunately only added in Emacs 24.4.
Fixes #2050
---
ivy-test.el | 12 +++++++++---
1 file changed, 9 insertions(+), 3 deletions(-)
diff --git a/ivy-test.el b/ivy-test.el
index f4d727e..c7cf9b6 100644
--- a/ivy-test.el
+++ b/ivy-test.el
@@ -1096,7 +1096,9 @@ a buffer visiting a file."
""))))
(ert-deftest counsel-find-file-with-dollars ()
- (skip-unless (file-exists-p "test"))
+ ;; This should be `skip-unless' instead,
+ ;; but it was only added in Emacs 24.4.
+ :expected-result (if (file-exists-p "test") :passed :failed)
(should (string=
(file-relative-name
(ivy-with '(counsel-find-file) "fo C-m"
@@ -1104,8 +1106,12 @@ a buffer visiting a file."
"test/find-file/files-with-dollar/foo$")))
(ert-deftest counsel-find-file-with-dotfiles ()
- (skip-unless (and (file-exists-p "test")
- (= emacs-major-version 26)))
+ ;; This should be `skip-unless' instead,
+ ;; but it was only added in Emacs 24.4.
+ :expected-result (if (and (file-exists-p "test")
+ (= emacs-major-version 26))
+ :passed
+ :failed)
(should (string=
(file-relative-name
(ivy-with '(counsel-find-file) "f C-m"
- [elpa] master fa87b97 182/399: ivy-test.el: Print version, (continued)
- [elpa] master fa87b97 182/399: ivy-test.el: Print version, Oleh Krehel, 2019/07/20
- [elpa] master 8482f62 179/399: swiper.el (swiper-isearch-function): Fix str is " ", Oleh Krehel, 2019/07/20
- [elpa] master 482088c 178/399: swiper.el (swiper--avy-candidates): Fix for swiper-background-faces, Oleh Krehel, 2019/07/20
- [elpa] master 0e62f0d 185/399: counsel.el (counsel-switch-buffer-other-window): Update prompt, Oleh Krehel, 2019/07/20
- [elpa] master 5115df3 184/399: counsel.el: counsel-switch-buffer-other-window: new command., Oleh Krehel, 2019/07/20
- [elpa] master 0a12708 164/399: swiper.el: Add swiper background faces, Oleh Krehel, 2019/07/20
- [elpa] master 7e73580 171/399: ivy-test.el (counsel-find-file-with-dollars): Add test, Oleh Krehel, 2019/07/20
- [elpa] master c47a7dc 176/399: ivy.el (ivy--filter): Don't cache if the result of matching cache is empty, Oleh Krehel, 2019/07/20
- [elpa] master 4171364 183/399: ivy-test.el (counsel-find-file-with-dotfiles): Disable for emacs27, Oleh Krehel, 2019/07/20
- [elpa] master d829338 190/399: counsel.el (counsel-recentf): Require match, Oleh Krehel, 2019/07/20
- [elpa] master 39f5c24 187/399: ivy-test.el: Use :expected-result,
Oleh Krehel <=
- [elpa] master a9f9e41 189/399: Add counsel-descbinds-action-exec, Oleh Krehel, 2019/07/20
- [elpa] master 80d9c17 188/399: Makefile: Clone tests/ if needed, Oleh Krehel, 2019/07/20
- [elpa] master 6516265 192/399: ivy-overlay.el: Do not assume in-buffer completion, Oleh Krehel, 2019/07/20
- [elpa] master 6263d04 193/399: counsel.el (counsel-find-file): Improve mkdir action with ivy-call, Oleh Krehel, 2019/07/20
- [elpa] master 31e57e7 181/399: ivy-test.el (counsel-find-file-with-dotfiles): Disable for older Emacs, Oleh Krehel, 2019/07/20
- [elpa] master f52b0ac 175/399: ivy.el (ivy--filter): Don't cache if ivy--old-cands is empty, Oleh Krehel, 2019/07/20
- [elpa] master 2221a5c 177/399: ivy-test.el (counsel-find-file-with-dotfiles): Add test, Oleh Krehel, 2019/07/20
- [elpa] master 0467f5b 191/399: doc/ivy.org: Correct typo, Oleh Krehel, 2019/07/20
- [elpa] master e3f8908 186/399: ivy-test.el: Make friendlier, Oleh Krehel, 2019/07/20
- [elpa] master 891be1d 199/399: counsel.el (counsel-org-file): Handle ATTACH_DIR property, Oleh Krehel, 2019/07/20