[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[elpa] master 1439e8d 064/399: counsel.el: Simplify compile build dir co
From: |
Oleh Krehel |
Subject: |
[elpa] master 1439e8d 064/399: counsel.el: Simplify compile build dir collection |
Date: |
Sat, 20 Jul 2019 14:56:50 -0400 (EDT) |
branch: master
commit 1439e8dde2b2338e757c0efe24995b7d7f2991f5
Author: Basil L. Contovounesios <address@hidden>
Commit: Basil L. Contovounesios <address@hidden>
counsel.el: Simplify compile build dir collection
(counsel-compile-get-build-directories):
Remove one level of string consing.
---
counsel.el | 22 +++++++++-------------
1 file changed, 9 insertions(+), 13 deletions(-)
diff --git a/counsel.el b/counsel.el
index 1f05795..5072dd9 100644
--- a/counsel.el
+++ b/counsel.el
@@ -5218,19 +5218,15 @@ The optional BLDDIR is useful for other helpers that
have found
(defun counsel-compile-get-build-directories (&optional dir)
"Return a list of potential build directories."
(let* ((srcdir (or dir (funcall counsel-compile-root-function)))
- (blddir (counsel--find-build-subdir srcdir)))
- (when blddir
- (mapcar
- (lambda (sd)
- (propertize
- (concat
- (propertize "select build in "
- 'face 'font-lock-warning-face)
- (propertize sd 'face 'dired-directory))
- 'srcdir srcdir
- 'blddir sd
- 'recursive 't))
- (counsel--get-build-subdirs blddir)))))
+ (blddir (counsel--find-build-subdir srcdir))
+ (props `(srcdir ,srcdir blddir ,blddir recursive t)))
+ (mapcar (lambda (s)
+ (setq s (concat (propertize "Select build in "
+ 'face 'font-lock-warning-face)
+ (propertize s 'face 'dired-directory)))
+ (add-text-properties 0 (length s) props s)
+ s)
+ (and blddir (counsel--get-build-subdirs blddir)))))
;; No easy way to make directory local, would buffer local make more sense?
(defun counsel-compile-get-filtered-history (&optional dir)
- [elpa] master 50dc9e6 065/399: counsel.el (counsel--get-build-subdirs): Fix, (continued)
- [elpa] master 50dc9e6 065/399: counsel.el (counsel--get-build-subdirs): Fix, Oleh Krehel, 2019/07/20
- [elpa] master 4e0d403 066/399: counsel.el (counsel--find-build-subdir): Simplify, Oleh Krehel, 2019/07/20
- [elpa] master 144e7d9 069/399: counsel.el: Clean up recent compile variables, Oleh Krehel, 2019/07/20
- [elpa] master 82e6c54 067/399: counsel.el: Clean up compile make invocation, Oleh Krehel, 2019/07/20
- [elpa] master bb58a29 071/399: counsel.el (counsel-ag): Fix error in non-Git directory, Oleh Krehel, 2019/07/20
- [elpa] master f0d93cf 073/399: counsel.el (counsel-compile): counsel-compile-get-filtered-history, Oleh Krehel, 2019/07/20
- [elpa] master ce0c39e 076/399: counsel.el (counsel--git-root): Rename, Oleh Krehel, 2019/07/20
- [elpa] master a37d4e3 072/399: counsel.el (counsel-compile): fix breakage to subdir recursion, Oleh Krehel, 2019/07/20
- [elpa] master 86c904f 077/399: counsel.el (counsel-compile-root-functions): Change priority, Oleh Krehel, 2019/07/20
- [elpa] master c2788de 082/399: counsel.el (counsel--switch-buffer-update-fn): if to cond, Oleh Krehel, 2019/07/20
- [elpa] master 1439e8d 064/399: counsel.el: Simplify compile build dir collection,
Oleh Krehel <=
- [elpa] master 7e8a362 068/399: counsel.el (counsel--get-make-targets): Clean up, Oleh Krehel, 2019/07/20
- [elpa] master d64b268 074/399: counsel.el (counsel-compile): counsel--get-build-subdirs, Oleh Krehel, 2019/07/20
- [elpa] master 6f0f32f 084/399: counsel.el (counsel-git-grep-count-function): Promote to defcustom, Oleh Krehel, 2019/07/20
- [elpa] master 25336fd 075/399: counsel.el (counsel-compile): counsel-compile-local-builds, Oleh Krehel, 2019/07/20
- [elpa] master db905cc 088/399: counsel.el (counsel-compile-phony-pattern): Use plain regex, Oleh Krehel, 2019/07/20
- [elpa] master 4e07e6f 048/399: ivy.el (ivy-make-magic-action): Add docstring to the generated lambda, Oleh Krehel, 2019/07/20
- [elpa] master 8a40934 062/399: counsel.el: Clean up compile candidates list, Oleh Krehel, 2019/07/20
- [elpa] master 0c30e3f 063/399: counsel.el: Minor compile history cleanup, Oleh Krehel, 2019/07/20
- [elpa] master 114ae96 070/399: counsel.el: Find project root more flexibly, Oleh Krehel, 2019/07/20
- [elpa] master 5aa263c 079/399: counsel.el (counsel-compile-make-pattern): Fix regex, Oleh Krehel, 2019/07/20