[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[elpa] externals/phps-mode 5e30a65 076/405: Added TODO items
From: |
Stefan Monnier |
Subject: |
[elpa] externals/phps-mode 5e30a65 076/405: Added TODO items |
Date: |
Sat, 13 Jul 2019 09:59:46 -0400 (EDT) |
branch: externals/phps-mode
commit 5e30a6575db7057cbff3807ddc92912c421fca36
Author: Christian Johansson <address@hidden>
Commit: Christian Johansson <address@hidden>
Added TODO items
---
phps-functions.el | 6 ++++++
phps-test-functions.el | 9 +++++++++
2 files changed, 15 insertions(+)
diff --git a/phps-functions.el b/phps-functions.el
index 03f2d8c..0e84dc5 100644
--- a/phps-functions.el
+++ b/phps-functions.el
@@ -121,12 +121,18 @@
(when (not (equal indent-sum (current-indentation)))
;; (message "Indenting to %s current column %s" indent-sum
(current-indentation))
;; (message "inside scripting, start: %s, end: %s, indenting
to column %s " start end indent-level)
+
+ ;; TODO When indent is changed the trailing tokens just need
to adjust their token positions, this will improve speed of indent-region a lot
(indent-line-to indent-sum)
+
(let ((line-start (line-beginning-position)))
+
+ ;; Set point of change if it's not set or if it's larger
than current point
(when (or (not phps-mode/buffer-changes--start)
(< line-start phps-mode/buffer-changes--start))
;; (message "Setting changes start from %s to %s"
phps-mode/buffer-changes--start start)
(setq phps-mode/buffer-changes--start line-start))
+
(phps-mode/run-incremental-lex))))))))))
;; TODO Implement this?
diff --git a/phps-test-functions.el b/phps-test-functions.el
index c24b35b..ff3f82d 100644
--- a/phps-test-functions.el
+++ b/phps-test-functions.el
@@ -137,6 +137,15 @@
(let ((buffer-contents (buffer-substring-no-properties (point-min)
(point-max))))
(should (equal buffer-contents "<?php\nif (random_expression(\ntrue\n))
{\nsome_logic_here();\n}"))))
+ ;; TODO Test this
+ ;; if (empty(
+ ;; $this->var
+ ;; ) && !empty($this->var)
+ ;; ) {
+ ;; $this->var = 'abc123';
+ ;; }
+
+
)
(defun phps-mode/test-functions--get-point-data ()
- [elpa] externals/phps-mode 86ec35f 066/405: Incremental lexer working somewhat, (continued)
- [elpa] externals/phps-mode 86ec35f 066/405: Incremental lexer working somewhat, Stefan Monnier, 2019/07/13
- [elpa] externals/phps-mode ec71e15 074/405: Fixed bug where token-numbers are not defined, Stefan Monnier, 2019/07/13
- [elpa] externals/phps-mode 236f05e 071/405: Updated makefile to not use hard-coded path to emacs, Stefan Monnier, 2019/07/13
- [elpa] externals/phps-mode bf633d2 061/405: Added test for indent of final line of doc comment block, Stefan Monnier, 2019/07/13
- [elpa] externals/phps-mode ba8165a 063/405: Fixed bug with brace count not including braces inside double quoted strings, Stefan Monnier, 2019/07/13
- [elpa] externals/phps-mode 99dfc68 067/405: Incremental-lexer deletes affected overlays, Stefan Monnier, 2019/07/13
- [elpa] externals/phps-mode 90d059c 064/405: Fixed bug in incremental lexer logic, Stefan Monnier, 2019/07/13
- [elpa] externals/phps-mode 1be9270 068/405: Updated README, Stefan Monnier, 2019/07/13
- [elpa] externals/phps-mode e57f1e1 075/405: Skipping indentation if it's already correct, Stefan Monnier, 2019/07/13
- [elpa] externals/phps-mode c57fb5b 073/405: Improved indentation of trailing opening brace, Stefan Monnier, 2019/07/13
- [elpa] externals/phps-mode 5e30a65 076/405: Added TODO items,
Stefan Monnier <=
- [elpa] externals/phps-mode 94d4814 078/405: Added test for moving lexer tokens, Stefan Monnier, 2019/07/13
- [elpa] externals/phps-mode a59ef7b 079/405: More unit tests for moving lexer token positions, Stefan Monnier, 2019/07/13
- [elpa] externals/phps-mode 287d934 077/405: Updated comments are made un-tested function for moving token positions, Stefan Monnier, 2019/07/13
- [elpa] externals/phps-mode b3821a1 080/405: Updated TODOs, Stefan Monnier, 2019/07/13
- [elpa] externals/phps-mode f4cd90e 072/405: Updated readme and makefile for running all tests, Stefan Monnier, 2019/07/13
- [elpa] externals/phps-mode f79cf4f 081/405: Started on function for moving lexer states, Stefan Monnier, 2019/07/13
- [elpa] externals/phps-mode e340279 082/405: Added unit tests for moving lexer-state positions, Stefan Monnier, 2019/07/13
- [elpa] externals/phps-mode 89b12ab 084/405: Added autoloads and fixed bug with assigning variable, Stefan Monnier, 2019/07/13
- [elpa] externals/phps-mode a10cc79 085/405: Debugging a indentation case, Stefan Monnier, 2019/07/13
- [elpa] externals/phps-mode e30ac0c 083/405: Started implementation of moving lexer and state position when, Stefan Monnier, 2019/07/13