emacs-elpa-diffs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[elpa] externals/bnf-mode a4ca649 74/74: Remove wrongly used (and docume


From: Stefan Monnier
Subject: [elpa] externals/bnf-mode a4ca649 74/74: Remove wrongly used (and documented) syntax-propertize-function call
Date: Thu, 9 May 2019 08:27:56 -0400 (EDT)

branch: externals/bnf-mode
commit a4ca649e79479e0ee312c45668b56ae33966cceb
Author: Serghei Iakovlev <address@hidden>
Commit: Serghei Iakovlev <address@hidden>

    Remove wrongly used (and documented) syntax-propertize-function call
---
 CHANGELOG.org |  3 +++
 bnf-mode.el   | 15 ---------------
 2 files changed, 3 insertions(+), 15 deletions(-)

diff --git a/CHANGELOG.org b/CHANGELOG.org
index 2f32e6a..d886c8b 100644
--- a/CHANGELOG.org
+++ b/CHANGELOG.org
@@ -14,6 +14,9 @@ The format is based on [[http://keepachangelog.com][Keep a 
Changelog]] and this
 - Only setting =bnf-mode-algol-comments-style= to non-nil will allow use
   semicolons as a regular terminal symbols. For more see: 
[[https://github.com/sergeyklay/bnf-mode/pull/4][#4]] .
 
+** Removed
+- Removed wrongly used (and documented) =syntax-propertize-function= funcall
+
 ** [[https://github.com/sergeyklay/bnf-mode/compare/0.4.0...0.4.1][0.4.1]] - 
2019-04-21
 *** Fixes
 - Minor fix related to build & deploy BNF Mode on Travis CI.
diff --git a/bnf-mode.el b/bnf-mode.el
index 9fb3247..35b0fa4 100644
--- a/bnf-mode.el
+++ b/bnf-mode.el
@@ -244,21 +244,6 @@ Will be used only if `bnf-mode-algol-comments-style' is 
set to t")
       (setq-local comment-end "")
       (setq-local comment-start-skip "\\(?:\\(\\W\\|^\\);+\\)\\s-+")))
 
-  ;; Basically `syntax-propertize-function' is a construct which belongs
-  ;; to `font-lock'.  But correct indentation depends on
-  ;; syntax properties of the text, and that should ideally be
-  ;; independent of font-lock being activated or not.
-  ;;
-  ;; For `bnf-mode', this means that with `font-lock' disabled, we wont
-  ;; have our syntax properties set correctly, and indentation will
-  ;; suffer.
-  ;;
-  ;; To patch our way around this, we issue a `syntax-propertize' call
-  ;; manually, `font-lock' enabled or not.
-  (with-silent-modifications
-    (when bnf-mode-algol-comments-style
-        (funcall syntax-propertize-function (point-min) (point-max))))
-
   ;; Font locking
   (setq font-lock-defaults
         '(



reply via email to

[Prev in Thread] Current Thread [Next in Thread]