emacs-elpa-diffs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[elpa] externals/eglot e935718 20/62: Fix placement of diagnostics with


From: Stefan Monnier
Subject: [elpa] externals/eglot e935718 20/62: Fix placement of diagnostics with same start and end positions
Date: Sat, 29 Sep 2018 17:13:30 -0400 (EDT)

branch: externals/eglot
commit e9357186b75a61aac56e89ee10e391099bd26ff0
Author: mkcms <address@hidden>
Commit: João Távora <address@hidden>

    Fix placement of diagnostics with same start and end positions
    
    Some servers such as cquery and clangd publish diagnostic with
    identical start and end positions.
    
    * eglot.el (eglot-handle-notification
      :textDocument/publishDiagnostics): Add 1 to :line since LSP lines
      are 0-based.  Don't subtract 1 from :character, since both emacs and
      LSP have 0-based columns.
---
 eglot.el | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/eglot.el b/eglot.el
index 0bb162b..58efc16 100644
--- a/eglot.el
+++ b/eglot.el
@@ -929,8 +929,8 @@ Uses THING, FACE, DEFS and PREPEND."
                          (let* ((st (plist-get range :start))
                                 (diag-region
                                  (flymake-diag-region
-                                  (current-buffer) (plist-get st :line)
-                                  (1- (plist-get st :character)))))
+                                  (current-buffer) (1+ (plist-get st :line))
+                                  (plist-get st :character))))
                            (setq beg (car diag-region)
                                  end (cdr diag-region))))
                      (eglot--make-diag (current-buffer) beg end



reply via email to

[Prev in Thread] Current Thread [Next in Thread]