emacs-elpa-diffs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[elpa] externals/ebdb acaf3d0 350/350: Move the mail field sorting thing


From: Eric Abrahamsen
Subject: [elpa] externals/ebdb acaf3d0 350/350: Move the mail field sorting thing to a :before method
Date: Mon, 14 Aug 2017 11:47:09 -0400 (EDT)

branch: externals/ebdb
commit acaf3d08afd209b7e026244803d9be222024db91
Author: Eric Abrahamsen <address@hidden>
Commit: Eric Abrahamsen <address@hidden>

    Move the mail field sorting thing to a :before method
    
    * ebdb.el (ebdb-record-insert-field): Having it run :after meant the
      change wasn't actually written to the database. A :before method
      seems to work fine.
---
 ebdb.el | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/ebdb.el b/ebdb.el
index 67ea7ca..16af674 100644
--- a/ebdb.el
+++ b/ebdb.el
@@ -2801,10 +2801,7 @@ If FIELD doesn't specify a year, use the current year."
 (cl-defmethod ebdb-record-organizations ((_record ebdb-record-entity))
   nil)
 
-;; TODO: This is wrong, it will alter the database after the main body
-;; of `ebdb-record-insert-field' has run.  Can we simply switch it to
-;; :before?
-(cl-defmethod ebdb-record-insert-field :after ((record ebdb-record-entity)
+(cl-defmethod ebdb-record-insert-field :before ((record ebdb-record-entity)
                                               (_mail ebdb-field-mail)
                                               &optional _slot)
   "After giving RECORD a new mail field, sort RECORD's mails by



reply via email to

[Prev in Thread] Current Thread [Next in Thread]