[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[elpa] externals/ebdb fc813dd 193/350: Yet more fixes to proper name for
From: |
Eric Abrahamsen |
Subject: |
[elpa] externals/ebdb fc813dd 193/350: Yet more fixes to proper name formatting |
Date: |
Mon, 14 Aug 2017 11:46:35 -0400 (EDT) |
branch: externals/ebdb
commit fc813dd09e585541956c35f07ac0e21ac3715496
Author: Eric Abrahamsen <address@hidden>
Commit: Eric Abrahamsen <address@hidden>
Yet more fixes to proper name formatting
* ebdb.el (ebdb-name-fl): Pass the "full" flag to ebdb-name-given.
(ebdb-string): By default return the full name.
(ebdb-init-field): Hash against name both with and without full
given names.
Further fixes to problems revealed by 927c2ac. A back-and-forth pass
through ebdb-string --> ebdb-parse --> ebdb-string should always be
idempotent. That means use full given names everywhere by default,
and only remove middle names for convenience.
Now middle names are displayed by default in *EBDB* buffers. We'll
probably want a customization option for that.
---
ebdb.el | 14 +++++++++-----
1 file changed, 9 insertions(+), 5 deletions(-)
diff --git a/ebdb.el b/ebdb.el
index f0f9f32..a5b4244 100644
--- a/ebdb.el
+++ b/ebdb.el
@@ -878,8 +878,8 @@ first one."
(when prefix prefix)
(when given-string (format ", %s" given-string)))))
-(cl-defmethod ebdb-name-fl ((name ebdb-field-name-complex) &optional _full)
- (let ((given (ebdb-name-given name)))
+(cl-defmethod ebdb-name-fl ((name ebdb-field-name-complex) &optional full)
+ (let ((given (ebdb-name-given name full)))
(with-slots (prefix surname suffix) name
(ebdb-string-trim
(concat (when given
@@ -896,13 +896,17 @@ first one."
;; produces the name you'll see in the *EBDB* buffer, so this is the
;; bit that should be most customizable, and most flexible. This
;; value also gets stored in the cache.
- (ebdb-name-fl name))
+ (ebdb-name-fl name t))
(cl-defmethod ebdb-init-field ((name ebdb-field-name-complex) &optional record)
(when record
- (let ((lf (ebdb-name-lf name))
+ (let ((lf-full (ebdb-name-lf name t))
+ (fl-full (ebdb-name-fl name t))
(fl (ebdb-name-fl name)))
- (ebdb-puthash lf record)
+ (ebdb-puthash lf-full record)
+ (ebdb-puthash fl-full record)
+ ;; Also hash against "first last", as an alternate search
+ ;; strategy.
(ebdb-puthash fl record)
(object-add-to-list (ebdb-record-cache record) 'alt-names lf)
(object-add-to-list (ebdb-record-cache record) 'alt-names fl)))
- [elpa] externals/ebdb adfe13f 235/350: Fix stupidity, (continued)
- [elpa] externals/ebdb adfe13f 235/350: Fix stupidity, Eric Abrahamsen, 2017/08/14
- [elpa] externals/ebdb 817414a 234/350: Drop object-print for cl-print-object, Eric Abrahamsen, 2017/08/14
- [elpa] externals/ebdb a629bde 236/350: Last tweak to pop-up buffers, Eric Abrahamsen, 2017/08/14
- [elpa] externals/ebdb 444f762 231/350: Fix condition-case catch in ebdb-i18n-* methods, Eric Abrahamsen, 2017/08/14
- [elpa] externals/ebdb 2de4f0e 241/350: Apparently I was spelling vCard wrong, Eric Abrahamsen, 2017/08/14
- [elpa] externals/ebdb f9d5af6 243/350: Add close parenthesis to email regexp delimiter, Eric Abrahamsen, 2017/08/14
- [elpa] externals/ebdb 4882f66 238/350: Include addresses in vcard output, plus escaping, Eric Abrahamsen, 2017/08/14
- [elpa] externals/ebdb 440cb9e 245/350: More search functions can use prefixes: mention in manual, Eric Abrahamsen, 2017/08/14
- [elpa] externals/ebdb c8bdb70 194/350: Don't assume Chinese names have both surname and given-names, Eric Abrahamsen, 2017/08/14
- [elpa] externals/ebdb 212a1e1 212/350: Snarfing shouldn't pop up its own window, Eric Abrahamsen, 2017/08/14
- [elpa] externals/ebdb fc813dd 193/350: Yet more fixes to proper name formatting,
Eric Abrahamsen <=
- [elpa] externals/ebdb 06123d9 217/350: Make sure database files are decoded as utf-8-emacs, Eric Abrahamsen, 2017/08/14
- [elpa] externals/ebdb c07babf 203/350: If alt-names search fails, fall back on actual name field search, Eric Abrahamsen, 2017/08/14
- [elpa] externals/ebdb 501edfb 149/350: Give Org mode its own popup window, Eric Abrahamsen, 2017/08/14
- [elpa] externals/ebdb 0612d92 153/350: Comment out ebdb-mua-auto-snarf-signature, Eric Abrahamsen, 2017/08/14
- [elpa] externals/ebdb 957fc1b 157/350: Implement popping of buffer search history, Eric Abrahamsen, 2017/08/14
- [elpa] externals/ebdb 3cb827e 181/350: Check for existence of fiel-attribute-modification-time, Eric Abrahamsen, 2017/08/14
- [elpa] externals/ebdb aabe2c0 189/350: Stupid mistake in previous commit, Eric Abrahamsen, 2017/08/14
- [elpa] externals/ebdb 6549647 198/350: More tests, Eric Abrahamsen, 2017/08/14
- [elpa] externals/ebdb f316417 202/350: Change keybinding for ebdb-prev-field, Eric Abrahamsen, 2017/08/14
- [elpa] externals/ebdb bfc5d9d 208/350: Internationalized ebdb-parse method for names must accept slots arg, Eric Abrahamsen, 2017/08/14