[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[elpa] master 1c09e99 156/348: ivy.el (ivy-call): Use select-window, no
From: |
Oleh Krehel |
Subject: |
[elpa] master 1c09e99 156/348: ivy.el (ivy-call): Use select-window, not with-ivy-window |
Date: |
Sat, 8 Apr 2017 11:03:46 -0400 (EDT) |
branch: master
commit 1c09e99153b36626fcb3d272973e7ef3cb5ee679
Author: Oleh Krehel <address@hidden>
Commit: Oleh Krehel <address@hidden>
ivy.el (ivy-call): Use select-window, not with-ivy-window
Since `with-ivy-window' relies on `with-selected-window', which restores
the window state. This is bad if the purpose of the action was to change
the selected window.
So now we use only the first part of `with-ivy-window', which
is (select-window (ivy--get-window ivy-last)).
Fixes #639
---
ivy.el | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/ivy.el b/ivy.el
index 64d3429..a48d63a 100644
--- a/ivy.el
+++ b/ivy.el
@@ -955,7 +955,8 @@ Example use:
ivy-text)
(t
ivy--current))))
- (prog1 (with-ivy-window (funcall action x))
+ (select-window (ivy--get-window ivy-last))
+ (prog1 (funcall action x)
(unless (or (eq ivy-exit 'done)
(equal (selected-window)
(active-minibuffer-window))
- [elpa] master 1fa9a28 118/348: Ensure regex is a sting, (continued)
- [elpa] master 1fa9a28 118/348: Ensure regex is a sting, Oleh Krehel, 2017/04/08
- [elpa] master 70a5360 127/348: counsel.el (counsel-git-grep-proj-function): Use greedy regex, Oleh Krehel, 2017/04/08
- [elpa] master 83f7ae6 129/348: counsel.el (counsel-yank-pop): Fix candidates not showing sometimes, Oleh Krehel, 2017/04/08
- [elpa] master 8f282a5 136/348: counsel.el (counsel-git-grep-action): Reveal text in outlines, Oleh Krehel, 2017/04/08
- [elpa] master bc96feb 141/348: ivy.el (ivy--recompute-index): Update condition, Oleh Krehel, 2017/04/08
- [elpa] master 45e29af 147/348: counsel.el: Fix compile warning, Oleh Krehel, 2017/04/08
- [elpa] master 04c2160 151/348: Replace references to evil-jumper with evil-jumps, Oleh Krehel, 2017/04/08
- [elpa] master c2974a5 154/348: Depend on Emacs 24.3, since user-error is used, Oleh Krehel, 2017/04/08
- [elpa] master e9db958 145/348: Rename ivy-recentf -> counsel-recentf, Oleh Krehel, 2017/04/08
- [elpa] master 78be161 165/348: Fix alist and :predicate interaction, Oleh Krehel, 2017/04/08
- [elpa] master 1c09e99 156/348: ivy.el (ivy-call): Use select-window, not with-ivy-window,
Oleh Krehel <=
- [elpa] master ec42e8a 177/348: swiper.el (swiper-multi-action-1): Fix regression, Oleh Krehel, 2017/04/08
- [elpa] master 778c325 183/348: ivy.el (ivy-call): Don't switch windows for 'identity action, Oleh Krehel, 2017/04/08
- [elpa] master 1e96d20 201/348: ivy-overlay.el (ivy-display-function-overlay): Fix up, Oleh Krehel, 2017/04/08
- [elpa] master f5276b0 180/348: Add char-fold-to-regexp option to swiper, Oleh Krehel, 2017/04/08
- [elpa] master 9f5f6e0 202/348: ivy-overlay.el (ivy-overlay-cleanup): Fixup, Oleh Krehel, 2017/04/08
- [elpa] master 74d83ab 216/348: Sort virtual buffers after open buffers., Oleh Krehel, 2017/04/08
- [elpa] master 17f8fb3 219/348: ivy.el (ivy-switch-buffer-other-window): Obey ivy-ignore-buffers, Oleh Krehel, 2017/04/08
- [elpa] master 07388d0 226/348: Shrink ivy to suitable height when reading actions., Oleh Krehel, 2017/04/08
- [elpa] master 2237916 223/348: ivy.el (ivy-call): setq default-directory instead of let, Oleh Krehel, 2017/04/08
- [elpa] master 1d97984 227/348: Ensure that ivy--regex-ignore-order always returns legal regexps, Oleh Krehel, 2017/04/08