[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[elpa] master 03dd4e7 06/24: Comment and whitespace changes only
From: |
Michael Heerdegen |
Subject: |
[elpa] master 03dd4e7 06/24: Comment and whitespace changes only |
Date: |
Thu, 19 May 2016 20:46:37 +0000 (UTC) |
branch: master
commit 03dd4e7c674eee10c61c1ae683d6ea41b8d24258
Author: Michael Heerdegen <address@hidden>
Commit: Michael Heerdegen <address@hidden>
Comment and whitespace changes only
---
packages/el-search/el-search.el | 15 +++++++++++----
1 file changed, 11 insertions(+), 4 deletions(-)
diff --git a/packages/el-search/el-search.el b/packages/el-search/el-search.el
index 26857ef..9f115e0 100644
--- a/packages/el-search/el-search.el
+++ b/packages/el-search/el-search.el
@@ -65,7 +65,7 @@
;; `(defvar ,_)
;;
;; you search for all defvar forms that don't specify an init value.
-;;
+;;
;; The following will search for defvar forms with a docstring whose
;; first line is longer than 70 characters:
;;
@@ -163,7 +163,7 @@
;; (define-key isearch-mode-map [(control ?%)]
#'el-search-replace-from-isearch)
;;
;; The bindings in `isearch-mode-map' let you conveniently switch to
-;; elisp searching from isearch.
+;; "el-search" searching from isearch.
;;
;;
;; Bugs, Known Limitations
@@ -185,6 +185,8 @@
;;
;; the comment will be lost.
;;
+;; FIXME: when we have resumable sessions, pause and warn about this case.
+;;
;;
;; Acknowledgments
;; ===============
@@ -195,9 +197,13 @@
;; TODO:
;;
;; - detect infloops when replacing automatically (e.g. for 1 -> '(1))
+;; Should we just fall back to interactive mode?
;;
;; - implement backward searching
;;
+;; - Make `el-search-pattern' accept an &optional limit, at least for
+;; the non-interactive use case?
+;;
;; - improve docstrings
;;
;; - handle more reader syntaxes, e.g. #n, #n#
@@ -345,6 +351,7 @@ error."
Don't move if already at beginning of a sexp. Point must not be
inside a string or comment. `read' the expression at that point
and return it."
+ ;; This doesn't catch end-of-buffer to keep the return value non-ambiguous
(let ((not-done t) res)
(while not-done
(let ((stop-here nil)
@@ -680,7 +687,7 @@ of any kind matched by all PATTERNs are also matched.
((null (cdr patterns))
(let ((pattern (car patterns)))
`(app ,(apply-partially #'el-search--contains-p (el-search--matcher
pattern))
- (,'\` (t (,'\, ,pattern))))))
+ (,'\` (t (,'\, ,pattern))))))
(t `(and ,@(mapcar (lambda (pattern) `(contains ,pattern)) patterns)))))
(el-search-defpattern not (pattern)
@@ -1003,7 +1010,7 @@ Hit any key to proceed."
nil)
((or ?q ?\C-g)
(setq done t)
- t)
+ t)
(?? (ignore (read-char
el-search-search-and-replace-help-string))
nil)))))
(unless (or done (eobp)) (el-search--skip-expression nil t)))))
- [elpa] master f178717 12/24: Clarify the operation scope of replacing, (continued)
- [elpa] master f178717 12/24: Clarify the operation scope of replacing, Michael Heerdegen, 2016/05/19
- [elpa] master 91192f5 10/24: Add patterns for character properties, Michael Heerdegen, 2016/05/19
- [elpa] master 246e1ff 17/24: Small fix in el-search--setup-minibuffer, Michael Heerdegen, 2016/05/19
- [elpa] master 098582b 20/24: Reduce duration of a `sit-for', Michael Heerdegen, 2016/05/19
- [elpa] master 01e5bcd 22/24: Clean up el-search-read-expression-map; add some doc, Michael Heerdegen, 2016/05/19
- [elpa] master 0b9fe9c 23/24: Set initial input for replace when coming from el-search-pattern, Michael Heerdegen, 2016/05/19
- [elpa] master c0d9ca7 14/24: Make el-search-pattern accept an optional NO-ERROR arg, Michael Heerdegen, 2016/05/19
- [elpa] master 41fc28b 01/24: New user option: el-search-use-sloppy-strings, Michael Heerdegen, 2016/05/19
- [elpa] master 149acb9 07/24: Improve documentation and argument names of el-search-query-replace, Michael Heerdegen, 2016/05/19
- [elpa] master 3d0a12e 13/24: Fix el-search--ensure-sexp-start error at bob, Michael Heerdegen, 2016/05/19
- [elpa] master 03dd4e7 06/24: Comment and whitespace changes only,
Michael Heerdegen <=
- [elpa] master b885ef1 03/24: el-search--check-pattern-args: make arg TYPE a string, Michael Heerdegen, 2016/05/19
- [elpa] master 3d72d1d 11/24: Address compiler warnings, Michael Heerdegen, 2016/05/19
- [elpa] master 536fab6 15/24: Give el-search--s a more meaningful name, Michael Heerdegen, 2016/05/19
- [elpa] master 4b11cb8 09/24: Rename two functions, Michael Heerdegen, 2016/05/19
- [elpa] master 8d7b29c 21/24: Make sure not to lose the minibuffer-prompt face, Michael Heerdegen, 2016/05/19
- [elpa] master c356b2d 19/24: Rename a local variable, Michael Heerdegen, 2016/05/19
- [elpa] master bb98a1d 04/24: Rewrite replacement layout restoration, Michael Heerdegen, 2016/05/19
- [elpa] master 5f9accc 18/24: Make query-replace accept FROM -> TO style input, Michael Heerdegen, 2016/05/19
- [elpa] master 99e8724 08/24: Handle replacements containing another match, Michael Heerdegen, 2016/05/19
- [elpa] master b09bb1b 16/24: Use `pp-to-string' to print replacement expression, Michael Heerdegen, 2016/05/19