[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[elpa] externals/dash 1c4e5d7 125/439: Remove eval from --reduce, it is
From: |
Phillip Lord |
Subject: |
[elpa] externals/dash 1c4e5d7 125/439: Remove eval from --reduce, it is evil. |
Date: |
Tue, 04 Aug 2015 20:27:07 +0000 |
branch: externals/dash
commit 1c4e5d7d623d78fdfe20fbe588d37af59b6f1f2f
Author: Magnar Sveen <address@hidden>
Commit: Magnar Sveen <address@hidden>
Remove eval from --reduce, it is evil.
---
dash.el | 8 +++++---
1 files changed, 5 insertions(+), 3 deletions(-)
diff --git a/dash.el b/dash.el
index 3b870f4..b579013 100644
--- a/dash.el
+++ b/dash.el
@@ -107,9 +107,11 @@ exposed as `acc`."
(defmacro --reduce (form list)
"Anaphoric form of `-reduce'."
- (if (eval list)
- `(--reduce-from ,form ,(car (eval list)) ',(cdr (eval list)))
- `(let (acc it) ,form)))
+ (let ((lv (make-symbol "list-value")))
+ `(let ((,lv ,list))
+ (if ,lv
+ (--reduce-from ,form (car ,lv) (cdr ,lv))
+ (let (acc it) ,form)))))
(defun -reduce (fn list)
"Returns the result of applying FN to the first 2 items in LIST,
- [elpa] externals/dash f034c16 119/439: Add -union (thanks to @Fuco1), (continued)
- [elpa] externals/dash f034c16 119/439: Add -union (thanks to @Fuco1), Phillip Lord, 2015/08/04
- [elpa] externals/dash 5e72ff9 120/439: Include numbers in github ids., Phillip Lord, 2015/08/04
- [elpa] externals/dash a23aa4b 128/439: Add examples for -group-by, Phillip Lord, 2015/08/04
- [elpa] externals/dash c669282 123/439: Add @Fuco1 to list of contributors., Phillip Lord, 2015/08/04
- [elpa] externals/dash 7f7ac33 130/439: Add Takafumi Arakaki to list of contributors., Phillip Lord, 2015/08/04
- [elpa] externals/dash 467dfa7 133/439: Add -map-indexed, Phillip Lord, 2015/08/04
- [elpa] externals/dash 85bd4e0 131/439: Add @tali713's -applify, Phillip Lord, 2015/08/04
- [elpa] externals/dash 7e4ee06 135/439: 1.0.3, Phillip Lord, 2015/08/04
- [elpa] externals/dash 1284bc6 134/439: Move .el files out of root., Phillip Lord, 2015/08/04
- [elpa] externals/dash 1120417 127/439: Add -group-by, Phillip Lord, 2015/08/04
- [elpa] externals/dash 1c4e5d7 125/439: Remove eval from --reduce, it is evil.,
Phillip Lord <=
- [elpa] externals/dash 3044e83 129/439: Merge pull request #8 from tkf/group-by, Phillip Lord, 2015/08/04
- [elpa] externals/dash 78390f6 139/439: Merge pull request #12 from vemv/master, Phillip Lord, 2015/08/04
- [elpa] externals/dash 0731333 140/439: Add @vemv to list of contributors, Phillip Lord, 2015/08/04
- [elpa] externals/dash 002e4cd 132/439: Add tali713 to list of contributors., Phillip Lord, 2015/08/04
- [elpa] externals/dash 98a82ca 142/439: DRY up -repeat with --dotimes, Phillip Lord, 2015/08/04
- [elpa] externals/dash 8fe15ed 141/439: Group -repeat with -dotimes, Phillip Lord, 2015/08/04
- [elpa] externals/dash e4521af 136/439: Add -repeat, Phillip Lord, 2015/08/04
- [elpa] externals/dash e083087 145/439: Merge pull request #13 from nicferrier/master, Phillip Lord, 2015/08/04
- [elpa] externals/dash 50e9f46 144/439: -cons* for making improper lists., Phillip Lord, 2015/08/04
- [elpa] externals/dash a196ac1 137/439: Fix -repeat, Phillip Lord, 2015/08/04