emacs-diffs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

emacs-29 4f099a7217 1/2: ; Remove failing erc-reuse-buffers test


From: F. Jason Park
Subject: emacs-29 4f099a7217 1/2: ; Remove failing erc-reuse-buffers test
Date: Tue, 14 Feb 2023 11:30:44 -0500 (EST)

branch: emacs-29
commit 4f099a721730b3c5e75133f75d34ff8b379522a1
Author: F. Jason Park <jp@neverwas.me>
Commit: F. Jason Park <jp@neverwas.me>

    ; Remove failing erc-reuse-buffers test
    
    * test/lisp/erc/erc-scenarios-base-reuse-buffers.el
    (erc-scenarios-base-reuse-buffers-server-buffers--enabled): Delete
    test.
---
 test/lisp/erc/erc-scenarios-base-reuse-buffers.el | 36 -----------------------
 1 file changed, 36 deletions(-)

diff --git a/test/lisp/erc/erc-scenarios-base-reuse-buffers.el 
b/test/lisp/erc/erc-scenarios-base-reuse-buffers.el
index d23a0b3590..71027a0c13 100644
--- a/test/lisp/erc/erc-scenarios-base-reuse-buffers.el
+++ b/test/lisp/erc/erc-scenarios-base-reuse-buffers.el
@@ -63,42 +63,6 @@ collisions involving bouncers in ERC.  Run EXTRA."
       (should (cdr (erc-scenarios-common-buflist "127.0.0.1"))))
     (when more (funcall more port))))
 
-;; XXX maybe remove: already covered many times over by other scenarios
-(ert-deftest erc-scenarios-base-reuse-buffers-server-buffers--enabled ()
-  :tags '(:expensive-test)
-  (with-suppressed-warnings ((obsolete erc-reuse-buffers))
-    (should erc-reuse-buffers))
-  (let ((erc-scenarios-common-dialog "base/reuse-buffers/server"))
-    (erc-scenarios-common-with-cleanup
-        ((dumb-server (erc-d-run "localhost" t 'foonet 'barnet))
-         (port (process-contact dumb-server :service))
-         erc-autojoin-channels-alist)
-
-      (ert-info ("Connect to foonet")
-        (with-current-buffer (erc :server "127.0.0.1"
-                                  :port port
-                                  :nick "tester"
-                                  :password "foonet:changeme"
-                                  :full-name "tester")
-          (should (string= (buffer-name) (format "127.0.0.1:%d" port)))
-          (erc-d-t-search-for 12 "marked as being away")))
-
-      (ert-info ("Connect to barnet")
-        (with-current-buffer (erc :server "127.0.0.1"
-                                  :port port
-                                  :nick "tester"
-                                  :password "barnet:changeme"
-                                  :full-name "tester")
-          (should (string= (buffer-name) (format "127.0.0.1:%d" port)))
-          (erc-d-t-search-for 45 "marked as being away")))
-
-      (erc-d-t-wait-for 2 (get-buffer "foonet"))
-      (erc-d-t-wait-for 2 (get-buffer "barnet"))
-
-      (ert-info ("Server buffers are unique, no IP-based names")
-        (should-not (eq (get-buffer "foonet") (get-buffer "barnet")))
-        (should-not (erc-scenarios-common-buflist "127.0.0.1"))))))
-
 ;; FIXME no sense in running this twice (JOIN variant includes this)
 (ert-deftest erc-scenarios-base-reuse-buffers-server-buffers--disabled ()
   :tags '(:expensive-test)



reply via email to

[Prev in Thread] Current Thread [Next in Thread]