emacs-diffs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

emacs-28 60ac12d21f: Fix shaping with bitmap-only fonts on HarfBuzz 5.2.


From: YAMAMOTO Mitsuharu
Subject: emacs-28 60ac12d21f: Fix shaping with bitmap-only fonts on HarfBuzz 5.2.0 (Bug#57976)
Date: Fri, 23 Sep 2022 01:19:27 -0400 (EDT)

branch: emacs-28
commit 60ac12d21f9b5a97c33efc639c8204c39367292b
Author: YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
Commit: YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>

    Fix shaping with bitmap-only fonts on HarfBuzz 5.2.0 (Bug#57976)
    
    * src/ftcrfont.c (ftcrhbfont_begin_hb_font): Undo last change for
    HarfBuzz 5.2.0.
---
 src/ftcrfont.c | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/src/ftcrfont.c b/src/ftcrfont.c
index d5d3e440af..97b68ac013 100644
--- a/src/ftcrfont.c
+++ b/src/ftcrfont.c
@@ -570,8 +570,12 @@ ftcrhbfont_begin_hb_font (struct font *font, double 
*position_unit)
   hb_font_t *hb_font = fthbfont_begin_hb_font (font, position_unit);
   /* HarfBuzz 5 correctly scales bitmap-only fonts without position
      unit adjustment.
-     (https://github.com/harfbuzz/harfbuzz/issues/489) */
-  if (!hb_version_atleast (5, 0, 0)
+     (https://github.com/harfbuzz/harfbuzz/issues/489)
+
+     Update: HarfBuzz 5.2.0 no longer does this for an hb_font_t font
+     object created from a given FT_Face.
+     (https://github.com/harfbuzz/harfbuzz/issues/3788) */
+  if ((hb_version_atleast (5, 2, 0) || !hb_version_atleast (5, 0, 0))
       && ftcrfont_info->bitmap_position_unit)
     *position_unit = ftcrfont_info->bitmap_position_unit;
 



reply via email to

[Prev in Thread] Current Thread [Next in Thread]