emacs-diffs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

emacs-28 c69a617742: Add notes about command modes and nativecomp intera


From: Lars Ingebrigtsen
Subject: emacs-28 c69a617742: Add notes about command modes and nativecomp interaction
Date: Mon, 21 Mar 2022 10:54:05 -0400 (EDT)

branch: emacs-28
commit c69a6177422d52cb75f295ddf3ca29cd50337995
Author: Lars Ingebrigtsen <larsi@gnus.org>
Commit: Lars Ingebrigtsen <larsi@gnus.org>

    Add notes about command modes and nativecomp interaction
    
    * doc/lispref/commands.texi (Command Modes): Note interaction with
    native-compile (bug#54437).
    
    * src/data.c: Add comment about not being supported.
    
    Do not merge to master.
---
 doc/lispref/commands.texi | 5 +++++
 src/data.c                | 3 +++
 2 files changed, 8 insertions(+)

diff --git a/doc/lispref/commands.texi b/doc/lispref/commands.texi
index 0d13408e3f..d948af6b4f 100644
--- a/doc/lispref/commands.texi
+++ b/doc/lispref/commands.texi
@@ -682,6 +682,11 @@ different ways (e.g., @code{eww-open-in-new-buffer} and
 mode-specific, as they can be issued by the user from pretty much any
 context.
 
+Note that specifying command modes is not supported in native-compiled
+functions in Emacs 28.1 (but this is fixed in later Emacs versions).
+This means that @code{read-extended-command-predicate} isn't supported
+in native-compile builds, either.
+
 @node Generic Commands
 @subsection Select among Command Alternatives
 @cindex generic commands
diff --git a/src/data.c b/src/data.c
index 9bf9d605cf..57205d8808 100644
--- a/src/data.c
+++ b/src/data.c
@@ -1022,6 +1022,9 @@ Value, if non-nil, is a list (interactive SPEC).  */)
   return Qnil;
 }
 
+/* Note that this doesn't work for native-compiled functions in Emacs
+   28.1, but it's fixed in later Emacs versions. */
+
 DEFUN ("command-modes", Fcommand_modes, Scommand_modes, 1, 1, 0,
        doc: /* Return the modes COMMAND is defined for.
 If COMMAND is not a command, the return value is nil.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]