emacs-diffs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

master 2af8b18b2a: Make quitting work while DND is waitng for finish


From: Po Lu
Subject: master 2af8b18b2a: Make quitting work while DND is waitng for finish
Date: Sun, 20 Mar 2022 21:34:35 -0400 (EDT)

branch: master
commit 2af8b18b2a53c11d33813ff407384f5eb53d92b2
Author: Po Lu <luangruo@yahoo.com>
Commit: Po Lu <luangruo@yahoo.com>

    Make quitting work while DND is waitng for finish
    
    * src/xterm.c (x_dnd_cleanup_drag_and_drop):
    (x_dnd_begin_drag_and_drop, handle_one_xevent)
    (x_free_frame_resources): Clear waiting for finish flag.
    (x_filter_event): Don't filter if waiting for DND finish as
    well.
---
 src/xterm.c | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)

diff --git a/src/xterm.c b/src/xterm.c
index 7928f4fafb..ec5a65b3bb 100644
--- a/src/xterm.c
+++ b/src/xterm.c
@@ -1174,6 +1174,8 @@ x_dnd_cleanup_drag_and_drop (void *frame)
       x_set_dnd_targets (NULL, 0);
     }
 
+  x_dnd_waiting_for_finish = false;
+
   FRAME_DISPLAY_INFO (f)->grabbed = 0;
 #ifdef USE_GTK
   current_hold_quit = NULL;
@@ -1213,7 +1215,7 @@ x_dnd_begin_drag_and_drop (struct frame *f, Time time, 
Atom xaction,
   if (!FRAME_VISIBLE_P (f))
     error ("Frame is invisible");
 
-  if (x_dnd_in_progress)
+  if (x_dnd_in_progress || x_dnd_waiting_for_finish)
     error ("A drag-and-drop session is already in progress");
 
   ltimestamp = x_timestamp_for_selection (FRAME_DISPLAY_INFO (f),
@@ -1306,6 +1308,7 @@ x_dnd_begin_drag_and_drop (struct frame *f, Time time, 
Atom xaction,
              x_dnd_in_progress = false;
              x_dnd_frame = NULL;
              x_set_dnd_targets (NULL, 0);
+             x_dnd_waiting_for_finish = false;
            }
 
          FRAME_DISPLAY_INFO (f)->grabbed = 0;
@@ -1327,6 +1330,7 @@ x_dnd_begin_drag_and_drop (struct frame *f, Time time, 
Atom xaction,
   FRAME_XIC (f) = ic;
 #endif
   x_set_dnd_targets (NULL, 0);
+  x_dnd_waiting_for_finish = false;
 
 #ifdef USE_GTK
   current_hold_quit = NULL;
@@ -10432,7 +10436,7 @@ x_filter_event (struct x_display_info *dpyinfo, XEvent 
*event)
     f1 = x_any_window_to_frame (dpyinfo,
                                event->xclient.window);
 
-  if (x_dnd_in_progress)
+  if (x_dnd_in_progress || x_dnd_waiting_for_finish)
     return 0;
 
 #ifdef USE_GTK
@@ -17563,6 +17567,7 @@ x_free_frame_resources (struct frame *f)
        x_dnd_send_leave (f, x_dnd_last_seen_window);
 
       x_dnd_in_progress = false;
+      x_dnd_waiting_for_finish = false;
       x_dnd_frame = NULL;
     }
 



reply via email to

[Prev in Thread] Current Thread [Next in Thread]