emacs-diffs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

master 29157a9f88: Fix bookmark-bmenu-list sorting.


From: Karl Fogel
Subject: master 29157a9f88: Fix bookmark-bmenu-list sorting.
Date: Mon, 7 Mar 2022 00:15:23 -0500 (EST)

branch: master
commit 29157a9f88c957f26f29284a71dad63d70d40cfd
Author: Manuel Giraud <manuel@ledu-giraud.fr>
Commit: Karl Fogel <kfogel@red-bean.com>

    Fix bookmark-bmenu-list sorting.
    
    Do not sort bookmarks in `bookmark-bmenu-list' if `bookmark-sort-flag'
    is nil.
    
    Also, make the default order of bookmark-bmenu-list be the LIFO order
    defined in `bookmark-sort-flag's documentation.
---
 lisp/bookmark.el | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/lisp/bookmark.el b/lisp/bookmark.el
index 2751731817..80fb1cdfc7 100644
--- a/lisp/bookmark.el
+++ b/lisp/bookmark.el
@@ -1819,7 +1819,7 @@ Don't affect the buffer ring order."
                        (list location))])
               entries)))
     (tabulated-list-init-header)
-    (setq tabulated-list-entries entries))
+    (setq tabulated-list-entries (reverse entries)))
   (tabulated-list-print t))
 
 ;;;###autoload
@@ -1907,7 +1907,8 @@ Bookmark names preceded by a \"*\" have annotations.
           ,@(if bookmark-bmenu-toggle-filenames
                 '(("File" 0 bookmark-bmenu--file-predicate)))])
   (setq tabulated-list-padding bookmark-bmenu-marks-width)
-  (setq tabulated-list-sort-key '("Bookmark" . nil))
+  (when bookmark-sort-flag
+    (setq tabulated-list-sort-key '("Bookmark" . nil)))
   (add-hook 'tabulated-list-revert-hook #'bookmark-bmenu--revert nil t)'
   (setq revert-buffer-function 'bookmark-bmenu--revert)
   (tabulated-list-init-header))



reply via email to

[Prev in Thread] Current Thread [Next in Thread]