[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

scratch/so-long f019be5 03/10: Increase `so-long-threshold' and `so-long

From: Phil Sainty
Subject: scratch/so-long f019be5 03/10: Increase `so-long-threshold' and `so-long-max-lines' defaults
Date: Thu, 29 Jul 2021 23:59:37 -0400 (EDT)

branch: scratch/so-long
commit f019be5fb6988d3da7605f673f5737a7e99fe627
Author: Phil Sainty <psainty@orcon.net.nz>
Commit: Phil Sainty <psainty@orcon.net.nz>

    Increase `so-long-threshold' and `so-long-max-lines' defaults
    * lisp/so-long.el (so-long-threshold, so-long-max-lines): Increase
    default values to reduce false-positives.
    * etc/NEWS: Describe changes.
    Lines shorter than 10,000 characters shouldn't generally be causing
    problems, so testing this explicitly will largely eliminate
    false-positives.  We must also increase the maximum number of lines
    to check, because 'minified' code may still include newlines, and so
    there may be many lines shorter than the new threshold before we find
    a line which exceeds it.
    Previously we used a minimum-effort heuristic, testing a very small
    number of lines against a maximum length which, while not remotely
    long enough to cause problems, would nevertheless be uncommon in any
    normal file of programming code (and hence indicative that the file
    was likely to be minified code).
    Testing indicates that the performance penalty for the larger values
    should be negligible.
 etc/NEWS        |  7 +++++++
 lisp/so-long.el | 11 ++++++-----
 2 files changed, 13 insertions(+), 5 deletions(-)

diff --git a/etc/NEWS b/etc/NEWS
index 5f9be88..efeb523 100644
--- a/etc/NEWS
+++ b/etc/NEWS
@@ -2820,6 +2820,13 @@ GPG key servers can now be queried for keys with the
 'M-x epa-search-keys' command.  Keys can then be added to your
 personal key ring.
+** So Long
+*** 'so-long-threshold' and 'so-long-max-lines' have been raised to
+10000 characters and 500 lines respectively, to reduce the likelihood
+of false-positives when 'global-so-long-mode' is enabled.
 * New Modes and Packages in Emacs 28.1
diff --git a/lisp/so-long.el b/lisp/so-long.el
index 2434749..e949ccd 100644
--- a/lisp/so-long.el
+++ b/lisp/so-long.el
@@ -391,7 +391,8 @@
 ;; * Change Log:
-;; 1.1   - ?
+;; 1.1   - Increase `so-long-threshold' from 250 to 10,000.
+;;       - Increase `so-long-max-lines' from 5 to 500.
 ;; 1.0   - Included in Emacs 27.1, and in GNU ELPA for prior versions of Emacs.
 ;;       - New global mode `global-so-long-mode' to enable/disable the library.
 ;;       - New user option `so-long-action'.
@@ -491,14 +492,14 @@
   :prefix "so-long"
   :group 'convenience)
-(defcustom so-long-threshold 250
+(defcustom so-long-threshold 10000
   "Maximum line length permitted before invoking `so-long-function'.
 See `so-long-detected-long-line-p' for details."
   :type 'integer
-  :package-version '(so-long . "1.0"))
+  :package-version '(so-long . "1.1"))
-(defcustom so-long-max-lines 5
+(defcustom so-long-max-lines 500
   "Number of non-blank, non-comment lines to test for excessive length.
 If nil then all lines will be tested, until either a long line is detected,
@@ -510,7 +511,7 @@ be counted.
 See `so-long-detected-long-line-p' for details."
   :type '(choice (integer :tag "Limit")
                  (const :tag "Unlimited" nil))
-  :package-version '(so-long . "1.0"))
+  :package-version '(so-long . "1.1"))
 (defcustom so-long-skip-leading-comments t
   "Non-nil to ignore all leading comments and whitespace.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]