[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
master ff053c7: * lisp/emacs-lisp/cl-generic.el: Fix bug#49053 and bug#4
From: |
Stefan Monnier |
Subject: |
master ff053c7: * lisp/emacs-lisp/cl-generic.el: Fix bug#49053 and bug#47454 |
Date: |
Wed, 16 Jun 2021 12:54:08 -0400 (EDT) |
branch: master
commit ff053c706cb903534936c45b04a2aa38e3db1261
Author: Stefan Monnier <monnier@iro.umontreal.ca>
Commit: Stefan Monnier <monnier@iro.umontreal.ca>
* lisp/emacs-lisp/cl-generic.el: Fix bug#49053 and bug#47454
(cl-generic-define-method): Shorten the time window where the symbol is
defined to `dummy`.
---
lisp/emacs-lisp/cl-generic.el | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/lisp/emacs-lisp/cl-generic.el b/lisp/emacs-lisp/cl-generic.el
index 31aa0cb..544704b 100644
--- a/lisp/emacs-lisp/cl-generic.el
+++ b/lisp/emacs-lisp/cl-generic.el
@@ -568,17 +568,17 @@ The set of acceptable TYPEs (also called
\"specializers\") is defined
(cons method mt)
;; Keep the ordering; important for methods with :extra qualifiers.
(mapcar (lambda (x) (if (eq x (car me)) method x)) mt)))
- (let ((sym (cl--generic-name generic))) ; Actual name (for aliases).
+ (let ((sym (cl--generic-name generic)) ; Actual name (for aliases).
+ ;; FIXME: Try to avoid re-constructing a new function if the old one
+ ;; is still valid (e.g. still empty method cache)?
+ (gfun (cl--generic-make-function generic)))
(unless (symbol-function sym)
(defalias sym 'dummy)) ;Record definition into load-history.
(cl-pushnew `(cl-defmethod . ,(cl--generic-load-hist-format
(cl--generic-name generic)
qualifiers specializers))
current-load-list :test #'equal)
- ;; FIXME: Try to avoid re-constructing a new function if the old one
- ;; is still valid (e.g. still empty method cache)?
- (let ((gfun (cl--generic-make-function generic))
- ;; Prevent `defalias' from recording this as the definition site of
+ (let (;; Prevent `defalias' from recording this as the definition site of
;; the generic function.
current-load-list
;; BEWARE! Don't purify this function definition, since that leads
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- master ff053c7: * lisp/emacs-lisp/cl-generic.el: Fix bug#49053 and bug#47454,
Stefan Monnier <=