[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
scratch/so-long 4c9fc80 3/7: Increase `so-long-threshold' and `so-long-m
From: |
Phil |
Subject: |
scratch/so-long 4c9fc80 3/7: Increase `so-long-threshold' and `so-long-max-lines' defaults |
Date: |
Sun, 10 Jan 2021 08:06:59 -0500 (EST) |
branch: scratch/so-long
commit 4c9fc806df3340f984fe19df12143db74ce3a05d
Author: Phil Sainty <psainty@orcon.net.nz>
Commit: Phil Sainty <psainty@orcon.net.nz>
Increase `so-long-threshold' and `so-long-max-lines' defaults
* lisp/so-long.el (so-long-threshold, so-long-max-lines): Increase
default values to reduce false-positives.
* etc/NEWS: Describe changes.
Lines shorter than 10,000 characters shouldn't generally be causing
problems, so testing this explicitly will largely eliminate
false-positives. We must also increase the maximum number of lines
to check, because 'minified' code may still include newlines, and so
there may be many lines shorter than the new threshold before we find
a line which exceeds it.
Previously we used a minimum-effort heuristic, testing a very small
number of lines against a maximum length which, while not remotely
long enough to cause problems, would nevertheless be uncommon in any
normal file of programming code (and hence indicative that the file
was likely to be minified code).
Testing indicates that the performance penalty for the larger values
should be negligible.
---
etc/NEWS | 7 +++++++
lisp/so-long.el | 11 ++++++-----
2 files changed, 13 insertions(+), 5 deletions(-)
diff --git a/etc/NEWS b/etc/NEWS
index eaaf9bf..87124e0 100644
--- a/etc/NEWS
+++ b/etc/NEWS
@@ -1877,6 +1877,13 @@ could have saved enough typing by using an abbrev, a
hint will be
displayed in the echo area, mentioning the abbrev that could have been
used instead.
+** So Long
+
+---
+*** 'so-long-threshold' and 'so-long-max-lines' have been raised to
+10000 characters and 500 lines respectively, to reduce the likelihood
+of false-positives when 'global-so-long-mode' is enabled.
+
* New Modes and Packages in Emacs 28.1
diff --git a/lisp/so-long.el b/lisp/so-long.el
index 2440a71..8973cd4 100644
--- a/lisp/so-long.el
+++ b/lisp/so-long.el
@@ -391,7 +391,8 @@
;; * Change Log:
;;
-;; 1.1 - ?
+;; 1.1 - Increase `so-long-threshold' from 250 to 10,000.
+;; - Increase `so-long-max-lines' from 5 to 500.
;; 1.0 - Included in Emacs 27.1, and in GNU ELPA for prior versions of Emacs.
;; - New global mode `global-so-long-mode' to enable/disable the library.
;; - New user option `so-long-action'.
@@ -490,14 +491,14 @@
:prefix "so-long"
:group 'convenience)
-(defcustom so-long-threshold 250
+(defcustom so-long-threshold 10000
"Maximum line length permitted before invoking `so-long-function'.
See `so-long-detected-long-line-p' for details."
:type 'integer
- :package-version '(so-long . "1.0"))
+ :package-version '(so-long . "1.1"))
-(defcustom so-long-max-lines 5
+(defcustom so-long-max-lines 500
"Number of non-blank, non-comment lines to test for excessive length.
If nil then all lines will be tested, until either a long line is detected,
@@ -509,7 +510,7 @@ be counted.
See `so-long-detected-long-line-p' for details."
:type '(choice (integer :tag "Limit")
(const :tag "Unlimited" nil))
- :package-version '(so-long . "1.0"))
+ :package-version '(so-long . "1.1"))
(defcustom so-long-skip-leading-comments t
"Non-nil to ignore all leading comments and whitespace.
- branch scratch/so-long created (now 98cb78f), Phil, 2021/01/10
- scratch/so-long a799d9b 2/7: ; * lisp/so-long.el: Bump to version 1.1, Phil, 2021/01/10
- scratch/so-long 6ed757f 1/7: ; * lisp/so-long.el: Documentation, Phil, 2021/01/10
- scratch/so-long bb5fa1b 4/7: Make `global-so-long-mode' handle unrecognised file types, Phil, 2021/01/10
- scratch/so-long 4ff1dbc 6/7: ; * lisp/so-long.el: Minor bug fixes, Phil, 2021/01/10
- scratch/so-long 98cb78f 7/7: Support 'preserved' variables and minor modes in `so-long-mode', Phil, 2021/01/10
- scratch/so-long 4c9fc80 3/7: Increase `so-long-threshold' and `so-long-max-lines' defaults,
Phil <=
- scratch/so-long b5dd69a 5/7: * lisp/so-long.el (so-long-minor-modes): Add smartparens modes, Phil, 2021/01/10