[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
master 02e6ffe: Fix process-tests on MS-Windows
From: |
Eli Zaretskii |
Subject: |
master 02e6ffe: Fix process-tests on MS-Windows |
Date: |
Tue, 5 Jan 2021 13:27:08 -0500 (EST) |
branch: master
commit 02e6ffe860cacc2681448b40f8b3279d31442b58
Author: Eli Zaretskii <eliz@gnu.org>
Commit: Eli Zaretskii <eliz@gnu.org>
Fix process-tests on MS-Windows
It was again broken by recent changes.
* test/src/process-tests.el
(process-tests/fd-setsize-no-crash/make-serial-process): Skip test
on MS-Windows.
---
test/src/process-tests.el | 11 +++++++++++
1 file changed, 11 insertions(+)
diff --git a/test/src/process-tests.el b/test/src/process-tests.el
index 1f88232..ca98f54 100644
--- a/test/src/process-tests.el
+++ b/test/src/process-tests.el
@@ -646,6 +646,8 @@ FD_SETSIZE file descriptors (Bug#24325)."
(ert-deftest process-tests/fd-setsize-no-crash/make-serial-process ()
"Check that Emacs doesn't crash when trying to use more than
FD_SETSIZE file descriptors (Bug#24325)."
+ ;; This test cannot be run if PTYs aren't supported.
+ (skip-unless (not (eq system-type 'windows-nt)))
(with-timeout (60 (ert-fail "Test timed out"))
(process-tests--with-processes processes
;; In order to use `make-serial-process', we need to create some
@@ -667,6 +669,15 @@ FD_SETSIZE file descriptors (Bug#24325)."
(tty-name (process-tty-name host)))
(should (processp host))
(push host processes)
+ ;; FIXME: The assumption below that using :connection 'pty
+ ;; in make-process necessarily produces a process with PTY
+ ;; connection is unreliable and non-portable.
+ ;; make-process can legitimately and silently fall back on
+ ;; pipes if allocating a PTY fails (and on MS-Windows it
+ ;; always fails). The following code also assumes that
+ ;; process-tty-name produces a file name that can be
+ ;; passed to 'stat' and to make-serial-process, which is
+ ;; also non-portable.
(should tty-name)
(should (file-exists-p tty-name))
(should-not (member tty-name tty-names))
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- master 02e6ffe: Fix process-tests on MS-Windows,
Eli Zaretskii <=