emacs-diffs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

emacs-27 7384ec6 1/4: Add warning comments abound binding keys in Isearc


From: Eli Zaretskii
Subject: emacs-27 7384ec6 1/4: Add warning comments abound binding keys in Isearch maps
Date: Sat, 2 Jan 2021 03:28:27 -0500 (EST)

branch: emacs-27
commit 7384ec6416cbcea12a65db058e5a65e40d3a157f
Author: Eli Zaretskii <eliz@gnu.org>
Commit: Eli Zaretskii <eliz@gnu.org>

    Add warning comments abound binding keys in Isearch maps
    
    * lisp/isearch.el (isearch-mode-map)
    (minibuffer-local-isearch-map): Add comments which warn against
    wantonly rebinding unbound keys.
---
 lisp/isearch.el | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/lisp/isearch.el b/lisp/isearch.el
index ac0ebc7..cbe72ef 100644
--- a/lisp/isearch.el
+++ b/lisp/isearch.el
@@ -655,6 +655,10 @@ This is like `describe-bindings', but displays only 
Isearch keys."
                              (if isearch-success 'isearch-abort binding))))
     map))
 
+;; Note: Before adding more key bindings to this map, please keep in
+;; mind that any unbound key exits Isearch and runs the command bound
+;; to it in the local or global map.  So in effect every key unbound
+;; in this map is implicitly bound.
 (defvar isearch-mode-map
   (let ((i 0)
        (map (make-keymap)))
@@ -819,6 +823,10 @@ This is like `describe-bindings', but displays only 
Isearch keys."
             :image '(isearch-tool-bar-image "left-arrow")))
     map))
 
+;; Note: Before adding more key bindings to this map, please keep in
+;; mind that any unbound key exits Isearch and runs the command bound
+;; to it in the local or global map.  So in effect every key unbound
+;; in this map is implicitly bound.
 (defvar minibuffer-local-isearch-map
   (let ((map (make-sparse-keymap)))
     (set-keymap-parent map minibuffer-local-map)



reply via email to

[Prev in Thread] Current Thread [Next in Thread]