[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
master 070c606: Remove the "Recent message" section from the bug reports
From: |
Lars Ingebrigtsen |
Subject: |
master 070c606: Remove the "Recent message" section from the bug reports |
Date: |
Tue, 18 Aug 2020 14:16:16 -0400 (EDT) |
branch: master
commit 070c60665e71ac9dddf073c9c49c1f8e91a9811f
Author: Stefan Kangas <stefankangas@gmail.com>
Commit: Lars Ingebrigtsen <larsi@gnus.org>
Remove the "Recent message" section from the bug reports
* lisp/mail/emacsbug.el (report-emacs-bug): Don't include "Recent
messages" since it has privacy implications. Problem reported by
Lars Ingebrigtsen in:
https://lists.gnu.org/archive/html/emacs-devel/2019-11/msg01099.html
(bug#39185).
---
etc/NEWS | 5 +++++
lisp/mail/emacsbug.el | 12 ------------
2 files changed, 5 insertions(+), 12 deletions(-)
diff --git a/etc/NEWS b/etc/NEWS
index c608c61..8085f96 100644
--- a/etc/NEWS
+++ b/etc/NEWS
@@ -816,6 +816,11 @@ window after starting). This variable defaults to nil.
** Miscellaneous
---
+*** 'M-x report-emacs-bug' will no longer include "Recent messages" section.
+These were taken from the "*Messages*" buffer, and may inadvertently
+leak information from the reporting user.
+
+---
*** 'count-windows' now takes an optional parameter ALL-FRAMES.
The semantics are as with 'walk-windows'.
diff --git a/lisp/mail/emacsbug.el b/lisp/mail/emacsbug.el
index efbc066..6b9e1db 100644
--- a/lisp/mail/emacsbug.el
+++ b/lisp/mail/emacsbug.el
@@ -324,18 +324,6 @@ usually do not have translators for other
languages.\n\n")))
(let ((os (ignore-errors (report-emacs-bug--os-description))))
(if (stringp os)
(insert "System Description: " os "\n\n")))
- (let ((message-buf (get-buffer "*Messages*")))
- (if message-buf
- (let (beg-pos
- (end-pos message-end-point))
- (with-current-buffer message-buf
- (goto-char end-pos)
- (forward-line -10)
- (setq beg-pos (point)))
- (terpri (current-buffer) t)
- (insert "Recent messages:\n")
- (insert-buffer-substring message-buf beg-pos end-pos))))
- (insert "\n")
(when (and system-configuration-options
(not (equal system-configuration-options "")))
(insert "Configured using:\n 'configure "
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- master 070c606: Remove the "Recent message" section from the bug reports,
Lars Ingebrigtsen <=