master 7899fa4: Declare some ancient compat aliases obsolete (Bug#41328)

[Stefan Kangas]

branch: master
commit 7899fa43095f63845d471398c5229147d6f6c100
Author: Stefan Kangas <stefankangas@gmail.com>
Commit: Stefan Kangas <stefankangas@gmail.com>

    Declare some ancient compat aliases obsolete (Bug#41328)
    
    * lisp/comint.el (comint-read-noecho):
    * lisp/emacs-lisp/edebug.el (edebug-all-defuns):
    * lisp/man.el (manual-entry):
    * lisp/vc/log-edit.el (vc-log-mode-map, vc-log-entry-mode): Declare
    ancient backwards-compatibility aliases and functions obsolete.  The
    oldest in this list was added in 1992, and the most recent in 2004.
    
    * lisp/net/telnet.el (telnet-initial-filter): Don't use
    `comint-read-noecho'.
---
 lisp/comint.el            | 1 +
 lisp/emacs-lisp/edebug.el | 2 +-
 lisp/man.el               | 2 +-
 lisp/net/telnet.el        | 2 +-
 lisp/vc/log-edit.el       | 7 +++----
 5 files changed, 7 insertions(+), 7 deletions(-)

diff --git a/lisp/comint.el b/lisp/comint.el
index ea06f8a..4b3b583 100644
--- a/lisp/comint.el
+++ b/lisp/comint.el
@@ -2350,6 +2350,7 @@ a buffer local variable."
 
 ;; For compatibility.
 (defun comint-read-noecho (prompt &optional _ignore)
+  (declare (obsolete read-passwd "28.1"))
   (read-passwd prompt))
 
 ;; These three functions are for entering text you don't want echoed or
diff --git a/lisp/emacs-lisp/edebug.el b/lisp/emacs-lisp/edebug.el
index 7846118..a565e8f 100644
--- a/lisp/emacs-lisp/edebug.el
+++ b/lisp/emacs-lisp/edebug.el
@@ -555,7 +555,7 @@ already is one.)"
 
 
 ;; Compatibility with old versions.
-(defalias 'edebug-all-defuns 'edebug-all-defs)
+(define-obsolete-function-alias 'edebug-all-defuns #'edebug-all-defs "28.1")
 
 ;;;###autoload
 (defun edebug-all-defs ()
diff --git a/lisp/man.el b/lisp/man.el
index 3121334..e1dd503 100644
--- a/lisp/man.el
+++ b/lisp/man.el
@@ -838,7 +838,7 @@ POS defaults to `point'."
 
 ;; For compatibility with older versions.
 ;;;###autoload
-(defalias 'manual-entry 'man)
+(define-obsolete-function-alias 'manual-entry 'man "28.1")
 
 (defvar Man-completion-cache nil
   ;; On my machine, "man -k" is so fast that a cache makes no sense,
diff --git a/lisp/net/telnet.el b/lisp/net/telnet.el
index e8c0c1b..29c415e 100644
--- a/lisp/net/telnet.el
+++ b/lisp/net/telnet.el
@@ -149,7 +149,7 @@ rejecting one login and prompting again for a username and 
password.")
            ((string-match "passw" string)
             (telnet-filter proc string)
             (setq telnet-count 0)
-            (process-send-string proc (concat (comint-read-noecho "Password: " 
t)
+            (process-send-string proc (concat (read-passwd "Password: ")
                                                telnet-new-line))
             (clear-this-command-keys))
            (t (telnet-check-software-type-initialize string)
diff --git a/lisp/vc/log-edit.el b/lisp/vc/log-edit.el
index 906f9a9..cd19b4e 100644
--- a/lisp/vc/log-edit.el
+++ b/lisp/vc/log-edit.el
@@ -51,6 +51,9 @@
 
 ;; The main keymap
 
+(define-obsolete-variable-alias 'vc-log-mode-map 'log-edit-mode-map "28.1")
+(define-obsolete-variable-alias 'vc-log-entry-mode 'log-edit-mode-map "28.1")
+
 (easy-mmode-defmap log-edit-mode-map
   '(("\C-c\C-c" . log-edit-done)
     ("\C-c\C-a" . log-edit-insert-changelog)
@@ -67,10 +70,6 @@
   "Keymap for the `log-edit-mode' (to edit version control log messages)."
   :group 'log-edit)
 
-;; Compatibility with old names.  Should we bother ?
-(defvar vc-log-mode-map log-edit-mode-map)
-(defvar vc-log-entry-mode vc-log-mode-map)
-
 (easy-menu-define log-edit-menu log-edit-mode-map
   "Menu used for `log-edit-mode'."
   '("Log-Edit"