[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

master 2d12d4d: Handle auth-source-search failures in open-network-strea

From: Robert Pluim
Subject: master 2d12d4d: Handle auth-source-search failures in open-network-stream
Date: Mon, 25 Nov 2019 10:14:16 -0500 (EST)

branch: master
commit 2d12d4d2d467f5df81e232707ad9191264b7c2b0
Author: Robert Pluim <address@hidden>
Commit: Robert Pluim <address@hidden>

    Handle auth-source-search failures in open-network-stream
    If the user cancels the gpg decryption pop-up, auth-source-search
    fails *and* epa pops up an error buffer.  Fix epa to allow suppressing
    that, and ignore errors returned from auth-source-search.
    * lisp/epa.el (epa-suppress-error-buffer): New defvar.  Bind non-nil
    to stop epa popping up an error buffer.
    * lisp/net/network-stream.el: require epa when byte-compiling.
    (network-stream-certificate): ignore errors when calling
    auth-source-search, and suppress the epa error buffer.
 lisp/epa.el                |  4 +++-
 lisp/net/network-stream.el | 13 +++++++++----
 2 files changed, 12 insertions(+), 5 deletions(-)

diff --git a/lisp/epa.el b/lisp/epa.el
index a2be9a3..13708d0 100644
--- a/lisp/epa.el
+++ b/lisp/epa.el
@@ -179,6 +179,7 @@ You should bind this variable with `let', but do not set it 
 (defvar epa-list-keys-arguments nil)
 (defvar epa-info-buffer nil)
 (defvar epa-error-buffer nil)
+(defvar epa-suppress-error-buffer nil)
 (defvar epa-last-coding-system-specified nil)
 (defvar epa-key-list-mode-map
@@ -578,7 +579,8 @@ If SECRET is non-nil, list secret keys instead of public 
     (message "%s" info)))
 (defun epa-display-error (context)
-  (unless (equal (epg-context-error-output context) "")
+  (unless (or (equal (epg-context-error-output context) "")
+              epa-suppress-error-buffer)
     (let ((buffer (get-buffer-create "*Error*")))
        (unless (and epa-error-buffer (buffer-live-p epa-error-buffer))
diff --git a/lisp/net/network-stream.el b/lisp/net/network-stream.el
index 9a796d9..1e9317b 100644
--- a/lisp/net/network-stream.el
+++ b/lisp/net/network-stream.el
@@ -46,6 +46,9 @@
 (require 'nsm)
 (require 'puny)
+  (require 'epa)) ; for epa-suppress-error-buffer
 (declare-function starttls-available-p "starttls" ())
 (declare-function starttls-negotiate "starttls" (process))
 (declare-function starttls-open-stream "starttls" (name buffer host port))
@@ -225,10 +228,12 @@ gnutls-boot (as returned by `gnutls-boot-parameters')."
       ;; Either nil or a list with a key/certificate pair.
      ((eq spec t)
-      (let* ((auth-info
-             (car (auth-source-search :max 1
-                                      :host host
-                                      :port service)))
+      (let* ((epa-suppress-error-buffer t)
+             (auth-info
+              (ignore-errors
+                (car (auth-source-search :max 1
+                                         :host host
+                                         :port service))))
             (key (plist-get auth-info :key))
             (cert (plist-get auth-info :cert)))
        (and key cert (file-readable-p key) (file-readable-p cert)

reply via email to

[Prev in Thread] Current Thread [Next in Thread]